From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49DF2221FCA for ; Wed, 14 Jan 2026 03:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768361601; cv=none; b=DNZ+H8PruPw49QOUrbQt5QTmh3rJ0G5l7an5hBP+QL3FpawGJIQFsdLKM+yCXJUgETkHHFxdUtc+nLy9s4r1AHCjDa2xKXaKQ9c6GQ1A2pTSckZKicRU2Wyw4JUlVy1O8WelBIxxN4OIJVIH+qjaQlUlYo19PO37wygTZy4C/Ao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768361601; c=relaxed/simple; bh=1MAdkMPHziLGOXqx9t8w4oXYmcpTJYDHpQw+tpH0FcQ=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=jUdOg8kC4gTPKksVEpFkpR+S0sg1BL+59e6/LPBok0zeqEz3jR2crQHyEf+zaRViYN33SrH0+Pyt5YW+4mDCLOloYHw8gA2/8iQGMR5MZ8LAUP7U8wcA4ap4MnzRlz8Ty9PfY5KbRXu3+Mg++DF/JvBJAvowqSPHOei3c+10uys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=BZatBXrb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="BZatBXrb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 814CCC4CEF7; Wed, 14 Jan 2026 03:33:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1768361600; bh=1MAdkMPHziLGOXqx9t8w4oXYmcpTJYDHpQw+tpH0FcQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BZatBXrbvDbOvS9uRir5nnYoIHYTRR0VSTdYDD1a7xtfhvleLx6HAXZrArSy+FLyT IR0FDsGg4a9MKHaKobpi24wZYdsi5Q+8Qjgm11UMYvw9iPuAKtUJzMQMvqWceNOMKI aExcvMSWVZPeLMKZCuCXz2MnrMSGTwtOxHFLTxTc= Date: Tue, 13 Jan 2026 19:33:19 -0800 From: Andrew Morton To: Ian Rogers Cc: Joe Perches , Kuan-Wei Chiu , Dwaipayan Ray , Lukas Bulwahn , Stephen Rothwell , Andy Whitcroft , linux-kernel@vger.kernel.org, Namhyung Kim Subject: Re: [PATCH v1] checkpatch: Warn about sign offs if there's an accidental patch separator Message-Id: <20260113193319.701e5799059eb642bbfc9a04@linux-foundation.org> In-Reply-To: References: <20251205053457.8556-1-irogers@google.com> <195a2cba2b461a0ab99ae004bdf079b038db8b07.camel@perches.com> <45e299a4c4326d46360955758df7d3df58613255.camel@perches.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Mon, 5 Jan 2026 09:13:49 -0800 Ian Rogers wrote: > On Mon, Jan 5, 2026 at 8:46 AM Joe Perches wrote: > > > > On Mon, 2026-01-05 at 07:39 -0800, Ian Rogers wrote: > > > I was the author of it. The patch passed checkpatch.pl but then > > > created a commit with missing tags - ie it was broken. This patch is > > > fixing this issue so that checkpatch.pl will warn about the missing > > > tags prior to the patch being sent to LKML, which is kind of > > > checkpatch.pl's purpose. This is all detailed in the commit message. > > > > Whatever was the tool that applied the patch should be fixed instead. > > The tool was git. As I mentioned, we can patch git but old versions > will still have the '^---' rather than '^---$' behavior and so these > checkpatch.pl tests remain useful. > I was bitten by this recently. Someone's changelog had ----------- stuff here and git-quiltimport remove half the changelog and all the metadata. git is wrong. I say so coz I invented the --- convention. submitting-patches.rst says - A marker line containing simply ``---``. The astonishingly old https://www.ozlabs.org/~akpm/stuff/tpp.txt says "... scripts will treat a ^--- string as ...". I regret not explicitly using "^---$". I'd like checkpatch to emit a warning in this case. If a line starts with --- then please let's warn the user that downstream tooling will screw this up.