From: Frank Li <Frank.Li@nxp.com>
To: Vinod Koul <vkoul@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Frank Li <Frank.Li@nxp.com>
Subject: [PATCH 6/6] dmaengine: fsl-edma: use common dma_slave_get_cfg()
Date: Wed, 14 Jan 2026 12:12:47 -0500 [thread overview]
Message-ID: <20260114-dma_common_config-v1-6-64feb836ff04@nxp.com> (raw)
In-Reply-To: <20260114-dma_common_config-v1-0-64feb836ff04@nxp.com>
Use common dma_slave_get_cfg() to simple code. No functional change.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/dma/fsl-edma-common.c | 61 ++++++++++++++++++-------------------------
1 file changed, 26 insertions(+), 35 deletions(-)
diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
index 33fc4fa8d1302d899ce550b0ce5d4325fa2e3916..c4ac63d9612ce9f1f5826a2186938a785ed529d1 100644
--- a/drivers/dma/fsl-edma-common.c
+++ b/drivers/dma/fsl-edma-common.c
@@ -291,30 +291,32 @@ static void fsl_edma_unprep_slave_dma(struct fsl_edma_chan *fsl_chan)
fsl_chan->dma_dir = DMA_NONE;
}
+static enum dma_data_direction
+fsl_dma_dir_trans_to_data(enum dma_transfer_direction dir)
+{
+ if (dir == DMA_MEM_TO_DEV)
+ return DMA_FROM_DEVICE;
+
+ if (dir == DMA_DEV_TO_MEM)
+ return DMA_TO_DEVICE;
+
+ return DMA_NONE;
+}
+
static bool fsl_edma_prep_slave_dma(struct fsl_edma_chan *fsl_chan,
enum dma_transfer_direction dir)
{
struct dma_slave_config *cfg = &fsl_chan->vchan.chan.config;
+ struct dma_slave_cfg *c = dma_slave_get_cfg(cfg, dir);
struct device *dev = fsl_chan->vchan.chan.device->dev;
enum dma_data_direction dma_dir;
phys_addr_t addr = 0;
u32 size = 0;
- switch (dir) {
- case DMA_MEM_TO_DEV:
- dma_dir = DMA_FROM_DEVICE;
- addr = cfg->dst_addr;
- size = cfg->dst_maxburst;
- break;
- case DMA_DEV_TO_MEM:
- dma_dir = DMA_TO_DEVICE;
- addr = cfg->src_addr;
- size = cfg->src_maxburst;
- break;
- default:
- dma_dir = DMA_NONE;
- break;
- }
+ dma_dir = fsl_dma_dir_trans_to_data(dir);
+
+ addr = c->addr;
+ size = c->maxburst;
/* Already mapped for this config? */
if (fsl_chan->dma_dir == dma_dir)
@@ -484,6 +486,7 @@ void fsl_edma_fill_tcd(struct fsl_edma_chan *fsl_chan,
bool disable_req, bool enable_sg)
{
struct dma_slave_config *cfg = &fsl_chan->vchan.chan.config;
+ struct dma_slave_cfg *c = dma_slave_get_cfg(cfg, cfg->direction);
u32 burst = 0;
u16 csr = 0;
@@ -507,26 +510,14 @@ void fsl_edma_fill_tcd(struct fsl_edma_chan *fsl_chan,
* If we don't have either of those, will use a major loop reading from addr
* nbytes (29bits).
*/
- if (cfg->direction == DMA_MEM_TO_DEV) {
- if (fsl_chan->is_multi_fifo)
- burst = cfg->dst_maxburst * 4;
- if (cfg->dst_port_window_size)
- burst = cfg->dst_port_window_size * cfg->dst_addr_width;
- if (burst) {
- nbytes |= EDMA_V3_TCD_NBYTES_MLOFF(-burst);
- nbytes |= EDMA_V3_TCD_NBYTES_DMLOE;
- nbytes &= ~EDMA_V3_TCD_NBYTES_SMLOE;
- }
- } else {
- if (fsl_chan->is_multi_fifo)
- burst = cfg->src_maxburst * 4;
- if (cfg->src_port_window_size)
- burst = cfg->src_port_window_size * cfg->src_addr_width;
- if (burst) {
- nbytes |= EDMA_V3_TCD_NBYTES_MLOFF(-burst);
- nbytes |= EDMA_V3_TCD_NBYTES_SMLOE;
- nbytes &= ~EDMA_V3_TCD_NBYTES_DMLOE;
- }
+ if (fsl_chan->is_multi_fifo)
+ burst = c->maxburst * 4;
+ if (c->port_window_size)
+ burst = c->port_window_size * c->addr_width;
+ if (burst) {
+ nbytes |= EDMA_V3_TCD_NBYTES_MLOFF(-burst);
+ nbytes |= EDMA_V3_TCD_NBYTES_DMLOE;
+ nbytes &= ~EDMA_V3_TCD_NBYTES_SMLOE;
}
fsl_edma_set_tcd_to_le(fsl_chan, tcd, nbytes, nbytes);
--
2.34.1
next prev parent reply other threads:[~2026-01-14 17:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 17:12 [PATCH 0/6] dmaengine: Add common dma_slave_config and split it into src and dst parts Frank Li
2026-01-14 17:12 ` [PATCH 1/6] dmaengine: Move struct dma_chan after struct dma_slave_config Frank Li
2026-01-14 17:12 ` [PATCH 2/6] dmaengine: Add common slave configuration to dma_chan Frank Li
2026-01-14 17:12 ` [PATCH 3/6] dmaengine: fsl-edma: use dma_chan common config Frank Li
2026-01-14 17:12 ` [PATCH 4/6] dmaengine: imx-sdma: use common config at dma_chan Frank Li
2026-01-14 17:12 ` [PATCH 5/6] dmaengine: Add union and dma_slave_get_config() helper for dma_slave_config Frank Li
2026-01-14 17:12 ` Frank Li [this message]
2026-03-09 11:24 ` [PATCH 0/6] dmaengine: Add common dma_slave_config and split it into src and dst parts Vinod Koul
2026-03-09 14:27 ` Frank Li
2026-03-17 10:26 ` Vinod Koul
2026-03-17 13:56 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260114-dma_common_config-v1-6-64feb836ff04@nxp.com \
--to=frank.li@nxp.com \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®