mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: chao@kernel.org, djwong@kernel.org, amir73il@gmail.com,
	hch@lst.de,  linux-fsdevel@vger.kernel.org,
	linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	 Hongbo Li <lihongbo22@huawei.com>
Subject: Re: [PATCH v14 00/10] erofs: Introduce page cache sharing feature
Date: Wed, 14 Jan 2026 16:34:46 +0100	[thread overview]
Message-ID: <20260114-komma-begeistern-20adeb35fdb8@brauner> (raw)
In-Reply-To: <0f33bd17-7a03-4c06-a492-e514935faed6@linux.alibaba.com>

On Wed, Jan 14, 2026 at 06:28:34PM +0800, Gao Xiang wrote:
> Hi Christian,
> 
> On 2026/1/12 22:40, Gao Xiang wrote:
> > Hi Christian,
> > 
> > On 2026/1/12 17:14, Christian Brauner wrote:
> > > On Fri, Jan 09, 2026 at 10:28:46AM +0000, Hongbo Li wrote:
> > > > Enabling page cahe sharing in container scenarios has become increasingly
> > > > crucial, as it can significantly reduce memory usage. In previous efforts,
> > > > Hongzhen has done substantial work to push this feature into the EROFS
> > > > mainline. Due to other commitments, he hasn't been able to continue his
> > > > work recently, and I'm very pleased to build upon his work and continue
> > > > to refine this implementation.
> > > 
> > > I can't vouch for implementation details but I like the idea so +1 from me.
> > 
> > Thanks, I think it should be fine.
> > Let me finalize the review this week.
> 
> I wonder if it's possible that you could merge v14
> PATCH 1 and 2 now to the vfs-iomap branch (both
> patches are reviewed or acked):
> https://lore.kernel.org/linux-fsdevel/20260109102856.598531-2-lihongbo22@huawei.com
> https://lore.kernel.org/linux-fsdevel/20260109102856.598531-3-lihongbo22@huawei.com
> 
> since these two patches are almost independent to the
> main feature and can be merged independently as I said
> in the previous cycle.
> 
> Merging those patches into a vfs branch also avoids
> other iomap conflicts.

Done.

> 
> For the other patches (since PATCH 3), how about going
> through erofs tree (I will merge your iomap branch),

Fine.

> since it seems at least it will cause several conflicts
> with my other ongoing work, does it sound good to you?

All good.

  reply	other threads:[~2026-01-14 15:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09 10:28 Hongbo Li
2026-01-09 10:28 ` [PATCH v14 01/10] iomap: stash iomap read ctx in the private field of iomap_iter Hongbo Li
2026-01-09 18:14   ` Darrick J. Wong
2026-01-10 11:55     ` Gao Xiang
2026-01-09 10:28 ` [PATCH v14 02/10] erofs: hold read context in iomap_iter if needed Hongbo Li
2026-01-09 10:28 ` [PATCH v14 03/10] fs: Export alloc_empty_backing_file Hongbo Li
2026-01-12  9:10   ` Christian Brauner
2026-01-09 10:28 ` [PATCH v14 04/10] erofs: decouple `struct erofs_anon_fs_type` Hongbo Li
2026-01-09 10:28 ` [PATCH v14 05/10] erofs: support user-defined fingerprint name Hongbo Li
2026-01-09 10:28 ` [PATCH v14 06/10] erofs: support domain-specific page cache share Hongbo Li
2026-01-09 10:28 ` [PATCH v14 07/10] erofs: introduce the page cache share feature Hongbo Li
2026-01-14 10:18   ` Gao Xiang
2026-01-15  1:21     ` Hongbo Li
2026-01-15  1:43       ` Gao Xiang
2026-01-09 10:28 ` [PATCH v14 08/10] erofs: support unencoded inodes for page cache share Hongbo Li
2026-01-14 14:51   ` Gao Xiang
2026-01-15  1:36     ` Hongbo Li
2026-01-15  1:46       ` Gao Xiang
2026-01-15  1:47         ` Hongbo Li
2026-01-09 10:28 ` [PATCH v14 09/10] erofs: support compressed " Hongbo Li
2026-01-14 14:53   ` Gao Xiang
2026-01-09 10:28 ` [PATCH v14 10/10] erofs: implement .fadvise " Hongbo Li
2026-01-12  9:14 ` [PATCH v14 00/10] erofs: Introduce page cache sharing feature Christian Brauner
2026-01-12 14:40   ` Gao Xiang
2026-01-14 10:28     ` Gao Xiang
2026-01-14 15:34       ` Christian Brauner [this message]
2026-01-14 15:33 ` (subset) " Christian Brauner
2026-01-14 15:35 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260114-komma-begeistern-20adeb35fdb8@brauner \
    --to=brauner@kernel.org \
    --cc=amir73il@gmail.com \
    --cc=chao@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=lihongbo22@huawei.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®