From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f176.google.com (mail-dy1-f176.google.com [74.125.82.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 822EE18871F for ; Wed, 14 Jan 2026 05:36:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768369012; cv=none; b=PkJ+WCUcZuzatAHTPtx0lYD8QMg3gU5K/imnSoRT13l09bOgj4SnZub53sGcEz5GRV71CxLPaemXgCSTHXYFkcOex9Jl+3XViv4md6f2Zd8kZA5l367S5Xl/sGBGXtRj4kU34YsnCCg0uZOCW71GrKsYSEBIsWVlRm2fKJyBr+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768369012; c=relaxed/simple; bh=GVYwNtq82+vv7MWdJtztjjuDn1cNdSTPyWMUQ3cg0MQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lYArEhPTmozk+NNK+sLC3L4+HDfZdTMIhgu3QCCGbKznZ72jd/LmaGlAMOAhDxNC4d99hlyGhPsVAo8PCzZ77PkdwWYLjQ8fMBvGukJpePsd6l3qIXIycB1skmGyyMKxmLCEuQIeDtgqXFrUvcQgk9kaZmw1ygSbfBsZnq4u4+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JPCRnE9r; arc=none smtp.client-ip=74.125.82.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JPCRnE9r" Received: by mail-dy1-f176.google.com with SMTP id 5a478bee46e88-2ac3d5ab81bso6222235eec.1 for ; Tue, 13 Jan 2026 21:36:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768369002; x=1768973802; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RdIivE2ldlrwLIiUkZ/Pij3yXzKqAKo3oC21HuvVTz8=; b=JPCRnE9rz8oIsShuR40iD77WQHob0HsqHuD3iKBqldm8RfC/OX1JvuMl8rfUyTcvzZ 1fMPsOpYZMJVpKkzjxavbp7VWIQKQjVG1oivQFwhKlMOsqGG/ouHkOLPvAt2vxiBOVtl 7QOKZ89XzkBNRAbbydOyFg7eLUHINmM4UjA+RvbV6oDR3Oiao8NgD38VjBVr8vfi4CSH rTQnRKfNs3N1uYjNW/smWdw2pX64g36WhsSTKqczQiQ1tRiqeKaAJuy1EfGlPBZbfYlN lUHTUQ+VbyJx9iszckH43ZCw1kjLpIUrcCWluf0iNgFlWED9bsB9tnEVTEjpNqaTClkB HBxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768369002; x=1768973802; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RdIivE2ldlrwLIiUkZ/Pij3yXzKqAKo3oC21HuvVTz8=; b=i5erBa0c31532ZHp6LgYc4rHhH5B7WLNfaofNZjgSwUEHg4mCwjIzF700H45NOtVtG 3eQgByVill6BRK+nlwVihW+l3yY/2CSfURJRQ4lmym45rMB9J0OTzk14jiO5WKA4urP0 o/sNw3H959tPxgd6IDs0Sq6AKL8RfCSJzQqvzJWdNhJC+8sooAMJn5CezM9iyQo40rl5 soMteVhJPgVY3pact6khAOvtJJx8PBTUy3PO5S9H31YQM7qMVYpQ0zt6OQ+huk2i8oeS lXAvMivO94NY7Hb2C/UbNdvEcyhoC8RXyHeFdG//zrghmHIFUh1pFXCFBPFs+UYy1rSp iRjg== X-Forwarded-Encrypted: i=1; AJvYcCXfZGCnKCFbGeaID6R7SDq6aAdV9IFhVpWCPCN2ensBgFkzU1qUjNEh7xom1xzlKcHBUqvqqJh8pcOFKLI=@vger.kernel.org X-Gm-Message-State: AOJu0YzqCviiHFJTsSZqEiaga6SunQ048hJmsX1YMI6qxEM5Hr/mLarL QX7p11JvToSk6R0SpvTka8nvipfL+XsePQRs6jsnXJi4qFoQdwcCt5jI X-Gm-Gg: AY/fxX7V4mmS6Gw6bJux2Wz8YQAmyLpBeTAK4XhHI3ss1Vq4wnkl7Zq0WLtJP34faxb JdmwRe3K+PZj43BqTUH2cwub7AWqhEy1eQ4cLcmg+NbEVA6JWW9iKb+3IY2wv5oXNLauys8H1CV gu+9hoHWAIxlpW2eKVLc0RLGa98qC3wgATW6HzBjNjjyrEIRNIXC3JYAQk945mjY1ACU89SEelc HPJvGbtGfOLOfpDhcQU0Nj5cVU5U1Y//1o+U2wADVlmebmm6LLyWvl1tg+iyfdPgULvIqMW0yM8 x/x2SMvy8dU4sCduuL/Eiy0pyDvyt9BvOYN+sO34YJW70C2Itqu3raLpmFdGN9SDWPbLh/zHZXw S2zbVXwjOjk4KR3uq5O8VCYsSh1qOvs/nd/aVP/bf7ct3RlUV53bfsVjZo8ma+5jUc5tW9nruUL gHdwET/B5ldew= X-Received: by 2002:a05:7300:1484:b0:2ae:5d3b:e1c6 with SMTP id 5a478bee46e88-2b48706e7b7mr2010368eec.21.1768369001549; Tue, 13 Jan 2026 21:36:41 -0800 (PST) Received: from localhost.localdomain ([2607:f130:0:11a::31]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b1706a6386sm19226783eec.14.2026.01.13.21.36.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 13 Jan 2026 21:36:41 -0800 (PST) From: wang lian To: sj@kernel.org Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, wang lian Subject: Re: [PATCH 08/11] mm/damon/lru_sort: support active:inactive memory ratio based auto-tuning Date: Wed, 14 Jan 2026 13:36:28 +0800 Message-ID: <20260114053629.85750-1-lianux.mm@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260113152717.70459-9-sj@kernel.org> References: <20260113152717.70459-9-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > Doing DAMOS_LRU_[DE]PRIO with DAMOS_QUOTA_[IN]ACTIVE_MEM_BP based quota > auto-tuning can be easy and intuitive, compared to the manual > [de]prioritization target access pattern thresholds tuning. For > example, users can ask DAMON to "find hot/cold pages and > activate/deactivate those aiming 50:50 active:inactive memory size." But > DAMON_LRU_SORT has no interface to do that. Add a module parameter for > setting the target ratio. > Signed-off-by: SeongJae Park ``` > +static int damon_lru_sort_add_quota_goals(struct damos *hot_scheme, > + struct damos *cold_scheme) > +{ > struct damos_quota_goal *goal; > + > + if (!active_mem_bp) > + return 0; > + goal = damos_new_quota_goal(DAMOS_QUOTA_ACTIVE_MEM_BP, active_mem_bp); > + if (!goal) > + return -ENOMEM; > + damos_add_quota_goal(&hot_scheme->quota, goal); > + /* aim 0.2 % goal conflict, to keep little ping pong */ > + goal = damos_new_quota_goal(DAMOS_QUOTA_INACTIVE_MEM_BP, > + 10000 - active_mem_bp + 2); > + if (!goal) > + return -ENOMEM; > + damos_add_quota_goal(&hot_scheme->quota, goal); > + return 0; > +} The second goal (Inactive ratio target) is added to hot_scheme again. Should this be cold_scheme? Currently the cold_scheme parameter appears to be unused. -- Best Regards, wang lian