mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Del Regno <angelogioacchino.delregno@collabora.com>,
	Tianping Fang <tianping.fang@mediatek.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: Fix I2C bus node names in examples
Date: Wed, 14 Jan 2026 10:33:17 +0200	[thread overview]
Message-ID: <20260114083317.GH30544@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20260114081322.53411-2-krzysztof.kozlowski@oss.qualcomm.com>

On Wed, Jan 14, 2026 at 09:13:23AM +0100, Krzysztof Kozlowski wrote:
> I2C bus node names are expected to be just "i2c", if there is just one
> such node in given example.  Replace remaining bad examples with
> scripted:
> 
>   git grep -l '\si2c[0-9] {' Documentation/devicetree/ | xargs sed -i -e 's/i2c[0-9] {/i2c {/'
> 
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
> Like Rob's commit 20a72af11f41 ("dt-bindings: Fix SPI and I2C bus node
> names in examples"). I checked also for SPI.
> 
> Rebased on Rob's tree - can you pick it up directly? Applies also on
> linux-next, so I do not expect conflicts.
> ---
>  .../bindings/embedded-controller/lenovo,yoga-c630-ec.yaml       | 2 +-
>  Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml   | 2 +-
>  Documentation/devicetree/bindings/usb/ite,it5205.yaml           | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-c630-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-c630-ec.yaml
> index a029b38e8dc0..c88fbd6ad940 100644
> --- a/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-c630-ec.yaml
> +++ b/Documentation/devicetree/bindings/embedded-controller/lenovo,yoga-c630-ec.yaml
> @@ -50,7 +50,7 @@ additionalProperties: false
>  examples:
>    - |+
>      #include <dt-bindings/interrupt-controller/irq.h>
> -    i2c1 {
> +    i2c {
>          clock-frequency = <400000>;
>  
>          #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> index a89f740214f7..dffd23ca4839 100644
> --- a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> @@ -95,7 +95,7 @@ examples:
>      #include <dt-bindings/gpio/gpio.h>
>      #include <dt-bindings/media/video-interfaces.h>
>  
> -    i2c0 {
> +    i2c {
>          #address-cells = <1>;
>          #size-cells = <0>;
>  
> diff --git a/Documentation/devicetree/bindings/usb/ite,it5205.yaml b/Documentation/devicetree/bindings/usb/ite,it5205.yaml
> index 889710733de5..045fcb41ac4b 100644
> --- a/Documentation/devicetree/bindings/usb/ite,it5205.yaml
> +++ b/Documentation/devicetree/bindings/usb/ite,it5205.yaml
> @@ -49,7 +49,7 @@ additionalProperties: false
>  examples:
>    - |
>      #include <dt-bindings/interrupt-controller/irq.h>
> -    i2c2 {
> +    i2c {
>          #address-cells = <1>;
>          #size-cells = <0>;
>  

-- 
Regards,

Laurent Pinchart

  parent reply	other threads:[~2026-01-14  8:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14  8:13 Krzysztof Kozlowski
2026-01-14  8:30 ` AngeloGioacchino Del Regno
2026-01-14  8:33 ` Laurent Pinchart [this message]
2026-01-15 18:56 ` Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260114083317.GH30544@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=tianping.fang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®