From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 683793328F0 for ; Wed, 14 Jan 2026 09:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768384204; cv=none; b=O+zoIhcgVYpgt8fXPXUaC30x7vNsBWO9FtQ77iNFR4a/yHvWiX7ShYQYdMAD7Z7SkDY9cedYjf07UROvyKE3Ptbpab0GPEYRJoUlFY3/wfO5bQmUFBDGK86EUYQap18QQ9XmUpNr8sImAm6xGsClC47dt6QoHaFFQDxhPzuzc9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768384204; c=relaxed/simple; bh=2BZXXupFU5NWzrKtEZRxWs+Za6jqLWEwHJNePGwzcnM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k99/5gAbqZvsJh2BPNiZJeRuVWhdjwWUkxBkK6vaAMGdmvFh9TLfnR27xByCRx7tsfsFom+6tQ56KmVp0jynV8GNFq0tHxdif543Cocs7LOFLDhPB5E/OOMvNCY7hEYLoM7Pwnsb5tNpmGmiA7cCQZoM1iTbWSFqFzl4pTCBg6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GnsWd1eD; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GnsWd1eD" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-47ee3a63300so5259015e9.2 for ; Wed, 14 Jan 2026 01:50:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768384202; x=1768989002; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=OfY55XGSJk78sfMp/SpFvAqiDsLzQ6V5RhLxtmJkoLM=; b=GnsWd1eDaByO5KFf/zfjAGEoLTHtLC0i2LzlxqUemyfu5xS4EkcrgzVZtZCSCjnIJA n+kdKUuAUmbaQqlVWTqrbmaNDLUTcsnw0WXzmDZd8xbvOaJS4985SPbcbYnQcYFbpeW7 RYIfFlOcT9fZaMUeVGQQYnELk/TRex1hEAfn/Vw9YMEuaimwDtqqPbWmE2rGN2g5rajb r7UTVcfq/VrsfbiTFAUs09CSZAaRWh873wRWZa57Etjok0f4Q7Q5imlVxA+9gOABKr74 HnNLZZkcQlqbGV2bsWAR98iXkm1ieRXC5L1+jdA0gWDkEOCjzeRHehkP+RIHGzxcTNav NjwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768384202; x=1768989002; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OfY55XGSJk78sfMp/SpFvAqiDsLzQ6V5RhLxtmJkoLM=; b=GLXp7cbd0BFaizseS9qi/AsZJ7VMFZ+tazDW9uHB+69Nx4Uk7vctcgfe6eMt/u8eY8 a5hTLV4VAcDifO05zIA5305hQBS598o2tnyhU1Zmn4c6u5h0xOQ8UvRif5SiVYvj0v0y jziDS2dx1nlfXSaFQB5evNeUWb84Wgnhmi3EeKBNEHK9+g1vdlBFAR02YeSo9Dgs6Kq5 Xo4YGA6GJS9nvPFklKtao+108tTDYGes8yMneFsuuL3J8+DiKcRMLGznAUDkFLCVN/cd 6M2sv9VRzExRoubT2O3OWqBwa8x+h8v+WejkOj+tLtjxNygtp+7ehC8RoNtzs5RPZvUG 84mA== X-Forwarded-Encrypted: i=1; AJvYcCWtWvKfKzniJ+GEhTZ1haYQed7aPBtGf7J59/n994TrZLX/PhTHJxa8hS2QyUuHCQ5Ak8HWErkxwHMla7Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzUpSkb06xMKeugLG4DpFLuEAuKeJgqfTnVbT1Xc0aTL6/TkvX7 rGG4LmqvN1KsqhA5DqYgkYr7yBBe9ZJoIqYfjz3pcsu/3zn/y8OsCDtS02nGSA== X-Gm-Gg: AY/fxX4/kgZyJI+5AqIFdkJC4VSBcdfcKk4E+gbV/8UVbJJ8GNXn73vLGF7ZM3wobxj LguVQqgs0LQYR5sQWlJCkLzh8A0XKDrzMaDE/NMv+M/6xJ+B6d14Nc7jHyrinZckM/d4Xsce3Sf 1sRWvmFzE/txyY63yyXY+NKK9cDPuaRn7LaguBDzP/2XMzqWa57KfI03oYPyueBKWNL4jtd06yp sNXBCG0ZZoD8PmottHC1/Q83IbF9xdhpC+oVEUZ7XXjqvD6iur7fTlho0Wd+ANIM8TqWKE3XPsP MN+BW4xwzK8aLrHbInT6vj6lxkAv7yxIpZ9EbT8u1HEkqXqtYkyoKrWackeYbcbLnRXoQMYxbR0 3ahZPDJyROh+nN1jTa+a2B6uc3VNo4JBaAIIHO4ysmRD5APLjMlv3gAtlJXupF17GeZzdPKG39x M/m0gTwUs2/YnTnAjfzFvlQZCMFMZwNauXFwk25S6Sg7eaJZB035I0 X-Received: by 2002:a05:600c:8b33:b0:477:5b0a:e616 with SMTP id 5b1f17b1804b1-47ee32e5c71mr21545705e9.5.1768384201496; Wed, 14 Jan 2026 01:50:01 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5edb7esm49023514f8f.30.2026.01.14.01.50.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 01:50:01 -0800 (PST) Date: Wed, 14 Jan 2026 09:49:59 +0000 From: David Laight To: Andrew Mark Cc: armin.wolf@embedded-designs.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] hwmon: (dell-smm) Extend fan support to 5 fans Message-ID: <20260114094959.71b35f05@pumpkin> In-Reply-To: <20260114025457.134659-1-android606@gmail.com> References: <20260110034732.236285-1-android606@gmail.com> <20260114025457.134659-1-android606@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 14 Jan 2026 02:54:57 +0000 Andrew Mark wrote: > Dell Precision Tower workstations have 5 fan connectors, but the > driver was limited to 4 fans after commit dbcfcb239b3b ("hwmon: > (dell-smm) Increment the number of fans"). > > This patch increases DELL_SMM_NO_FANS to 5 and adds the necessary > hwmon channel info for the fifth fan and its PWM control. > > Without this patch, the PCIe/GPU cooling fan (fan 5) is not > controllable, which can lead to overheating on systems with > high-power fanless GPUs that depend on chassis cooling. > > Tested on Dell Precision Tower 5810 (BIOS A34) with all 5 fans > responding correctly to PWM control. > > Fan mapping for Precision Tower 5810: > - fan0: CPU heatsink > - fan1: Second CPU (dual-CPU systems only) > - fan2: Right DIMM bank > - fan3: Left DIMM bank > - fan4: PCIe/GPU cooling > > Signed-off-by: Andrew Mark > --- > v2: > - Removed DMI quirks changes. Setting fan type names in sensors3 config > instead. > > drivers/hwmon/dell-smm-hwmon.c | 5 +++++ > 1 file changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c > index 6040a8940..88263fa53 100644 > --- a/drivers/hwmon/dell-smm-hwmon.c > +++ b/drivers/hwmon/dell-smm-hwmon.c > @@ -74,7 +74,7 @@ > #define DELL_SMM_LEGACY_EXECUTE 0x1 > > #define DELL_SMM_NO_TEMP 10 > -#define DELL_SMM_NO_FANS 4 > +#define DELL_SMM_NO_FANS 5 > > /* limit fan multiplier to avoid overflow */ > #define DELL_SMM_MAX_FAN_MULT (INT_MAX / U16_MAX) > @@ -1129,12 +1129,15 @@ static const struct hwmon_channel_info * const dell_smm_info[] = { > HWMON_F_INPUT | HWMON_F_LABEL | HWMON_F_MIN | HWMON_F_MAX | > HWMON_F_TARGET, > HWMON_F_INPUT | HWMON_F_LABEL | HWMON_F_MIN | HWMON_F_MAX | > + HWMON_F_TARGET, > + HWMON_F_INPUT | HWMON_F_LABEL | HWMON_F_MIN | HWMON_F_MAX | > HWMON_F_TARGET I'd have used a different indentation rule to get each value on one line... > ), > HWMON_CHANNEL_INFO(pwm, > HWMON_PWM_INPUT | HWMON_PWM_ENABLE, > HWMON_PWM_INPUT | HWMON_PWM_ENABLE, > HWMON_PWM_INPUT | HWMON_PWM_ENABLE, > + HWMON_PWM_INPUT | HWMON_PWM_ENABLE, > HWMON_PWM_INPUT | HWMON_PWM_ENABLE > ), That code is just crying out for: #define HWMON_CHANNEL_INFO_N(stype, count, val) \ HWMON_CHANNEL_INFO(stype, [0 ... (count) - 1] = val) so you can do: HWMON_CHANNEL_INFO_N(pwm, DELL_SMM_NO_FANS, HWMON_PWM_INPUT | HWMON_PWM_ENABLE) David > NULL