From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02D642BE629 for ; Wed, 14 Jan 2026 11:19:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768389599; cv=none; b=bvT+ZgaoMuLhgKHET+gNNH3lIgf54dLQzqniMFKStXTygsLPYW3RMVV2hVb37uoWtqkMXiHHd0L6z+Dbf1JTbMz2Lnflw0+kwK8aJ0z1kk8/YnSMwsGUv6OjyX9Zt4e/c6fozuMILa5HknqjuJK0USrOLYHNjAsMAZJKYRAERzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768389599; c=relaxed/simple; bh=MqXtvw9jMvRMDLcm4XFYyiWar+3k9k8u5KTsoF0ewAI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H1/ADMC0yAHg1d3nwZlWfVAszaWV5CNsB8+s+06tyS0Tt6x0PnwESwuVdUyCwrHTCjn5W3oJFFiTwRvexfYaFTrXD1vTmaGSX1jEmPBXKdvVp1I86ej5yAVqjYuD1fLE5v8Ez/AD8l7Jd5jDcYEtl41AyTt5l8Wljh+HW2SSIpw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=TB0fqjlQ; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="TB0fqjlQ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QFWsIQq39cFqX3EjhB4EXs7b0HQMssnj1ADqj+F36qQ=; b=TB0fqjlQ+z6SFqruWOfNBK/uHp Mbr1DV6a3xOVdncIYbhvx0f+YCml1jUiL4KLHdiHeqDDUuKnTEVRCPglVhltP5/JW+T/ZdJr3oxwA LMCZT8mC19rsE9dP+O7RwIdDU4Ev4ACk7rzNS//BmMfWnTolPDh+A4wh4IItLD3nD5xdTK9ERGw/5 zkdgJXJ2KYV6EoxFLm5OO3/bT8zjAd+1XSLZ9Et2aMgHLjHPK8if7+wCbCY+S7bd+2ZaRaUMAMPBQ 4aa+6iTU60oRsxHp07GvnS/k9IFo78r4i7T5I3WA8Cz/MZR3VYxcMSgREOYbRym/LVCTcetinv5oJ 08FFbU0g==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vfyuo-000000066gn-32cX; Wed, 14 Jan 2026 11:19:54 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 49E0C3005AA; Wed, 14 Jan 2026 12:19:54 +0100 (CET) Date: Wed, 14 Jan 2026 12:19:54 +0100 From: Peter Zijlstra To: Zhan Xusheng Cc: Ingo Molnar , linux-sched@vger.kernel.org, linux-kernel@vger.kernel.org, Zhan Xusheng Subject: Re: [PATCH] sched/fair: Fix math notation errors in avg_vruntime comment Message-ID: <20260114111954.GA830755@noisy.programming.kicks-ass.net> References: <20260114090035.19033-1-zhanxusheng@xiaomi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260114090035.19033-1-zhanxusheng@xiaomi.com> On Wed, Jan 14, 2026 at 05:00:35PM +0800, Zhan Xusheng wrote: > The avg_vruntime comment contains a couple of mathematical notation > issues: > > - The summation over w_i * (V - v_i) is written in an ambiguous form > - The delta term refers to v instead of v0, which is inconsistent > with the code and preceding explanation > > Fix these to make the comment mathematically correct and consistent > with the implementation. > > Signed-off-by: Zhan Xusheng Fair enough. Thanks!