From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDF8D354AF9 for ; Wed, 14 Jan 2026 22:38:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768430346; cv=none; b=UYr6GYSGRJRhb96/dXDzaKvIGplzcocV5g+Qsc4pTGbPIJBoXWKFM14a7eYAg8rDy73poXyrRySp/5a+dWYK4Fr5+UxewQ9+vLlZcLyrgSbMc+lIQEQtpRJBEVqLBp5uEk4RzkaGhFI77wiQe8X/MUKsDQfD9f+RGCy7zvN5K4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768430346; c=relaxed/simple; bh=LiPMNGSYuDYKND7hjpCb2VOdDYbgBQygqfIWwd0xZ2o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cBE+xYw0oOuU0Ps9vNDnJDj+Oj+Fzm8pVgE6YmRSI5Km38iNyHNYTc1+15u1Dk/3uzffv0NwMfVd7XextMEHtIAXiroxFLdQDFwrqrMxTWF0yVRgCcDm8JPHICrgZL5bNbCpbTQTIacgcy9hVqlUyl69XefbWRIMCrCKIbaqevU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O33VKL+q; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O33VKL+q" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-47ee66dab14so405075e9.3 for ; Wed, 14 Jan 2026 14:38:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768430332; x=1769035132; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UpLrsuBP5cyvqPyFlCwBE8b4I6p1F6uTyQHUxukXoTo=; b=O33VKL+qJikSrFjNwPNF+t/liIjkVgBsuZh4JGnVYrcyC5/a71GxNagxBF8Aumdn8t O/BccIvh68/QUEPr3HA/ENakTnyy0iEKh6b0Vx1gGI42q6ppfXY2Bwck0A+bc+qVcCHf pXuQct4M2HOqXre2zZSPN92Jh5aEVTKvepFHzhC81Qe5i6iub3PJwKMdgRbSfZnkkWw0 l7+Xxm17++uHDwvUF1M6TDC3Q6tmnLXK8YV1IwMjBv19PpOPIavLHy8wLsHShmzXx3u2 hbd3O6Z4VkTdHrPBwRCJpQBlGhtmDwLBfJWTKoxfpsgoG7Waqc+05qjMVDCIIjGP8sui /nug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768430332; x=1769035132; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UpLrsuBP5cyvqPyFlCwBE8b4I6p1F6uTyQHUxukXoTo=; b=gVW1tRNNq6mqXaQMUg6SpB+h+b5e4PWvOCDvkd6VyDK7kpynPCjFvWu7fRGNv0ISIY RYqhtLW/wDVZxmM6aUwiDFQPf9wQu5kUw9dv03glsU8yQD6RMrAlJDlyPnnAbtPFVrRs fUXS6y4n/OY8VkgCUA6V8xp07RHzaOnsf665x3cQ3OX/8BztZvx3ip2MyT5HxzxEYjxO BuGT1KpqHBMbAQIC9H3daIw25MN3uw8zhz6Jajwqrf4+SjigV8EVTKzpQy9oEQ6llnAA EJnRYQ9nj6GspDrDrGuOQd4KkTVrXJKafqAP9kbrdWSIfjwubAdS+iUQXpdwqoG+8eqq BMLw== X-Forwarded-Encrypted: i=1; AJvYcCX8H343dSYrOUTAEyOuLV3aT62fT0tgAkzqMIG6yrhkgRbLvEX/kzEErOqStHg9OSy6HSO7WerekjYpgtI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2a9kb6IrJHlsoAhAoS9LYNxlEBDB9N3P7lPml3LXkYIqS/LnG rI/Kw8wYbITcFWiKuD+T9Cup4GcCngPLoHIeAtlSzAn3qZgnXiQbcp6i X-Gm-Gg: AY/fxX5xu/kInZdx7bUHJ6gXJ7C+5Bvq7S80kJuDhtZw8l8Aj2Rx8MSNYYPCsSTCpUl sJSELZAIVHXkpRQvoAUufSNXdlcxEKVbBNCAKyM+n4jjapEKlM8GbmYhtoXjvB1uQ9O5oZtM1hu zw2nZ9SzyWcvfhvpAMne8xzquG+flzRmJHDid+vhzykMYHBy9Ja1Lh00M/gIO99MsGf4f9ABuM4 f31tPUC8iT2vokeWONQHX6+a8wbGA0HGGO8dh2vlwi3CPpSENWBAg8UZkE2rQVvP1ZCcDWT8dYb CWvGvd8Bdw+aER7iUrh9ivkoP1gFnh5b6xnB3E9TdGY/u6x0hKnv7cRA6qa+MH+cfFqG9hDght7 lRrnkNliyrIXOB/REJ5qjvpaRaubiygHGIUmsvB1gxCtYFFGQH63HQo4S+aCSd4yL8Lj5DCSZv0 5arA== X-Received: by 2002:a05:600c:3510:b0:47a:94fc:d063 with SMTP id 5b1f17b1804b1-47ee32e0ce4mr29774335e9.1.1768430331927; Wed, 14 Jan 2026 14:38:51 -0800 (PST) Received: from skbuf ([2a02:2f04:d703:5400:d5b0:b41:b5b3:8c4d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f42907141sm12480585e9.9.2026.01.14.14.38.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 14:38:51 -0800 (PST) Date: Thu, 15 Jan 2026 00:38:48 +0200 From: Vladimir Oltean To: Daniel Golle Cc: Hauke Mehrtens , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Chen Minqiang , Xinfa Deng Subject: Re: [PATCH net-next 3/3] net: dsa: mxl-gsw1xx: add support for Intel GSW150 Message-ID: <20260114223848.4s6r4ncuzstq6e4e@skbuf> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 13, 2026 at 03:25:34AM +0000, Daniel Golle wrote: > Add support for the Intel GSW150 (aka. Lantiq PEB7084) switch IC to > the mxl-gsw1xx driver. This switch comes with 5 Gigabit Ethernet > copper ports (Intel XWAY PHY11G (xRX v1.2 integrated) PHYs) as well as > one GMII/RGMII and one RGMII port. > > Signed-off-by: Daniel Golle > --- > drivers/net/dsa/lantiq/mxl-gsw1xx.c | 63 ++++++++++++++++++++++++++--- > drivers/net/dsa/lantiq/mxl-gsw1xx.h | 2 + > 2 files changed, 60 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/dsa/lantiq/mxl-gsw1xx.c b/drivers/net/dsa/lantiq/mxl-gsw1xx.c > index 4390c2df2e4bd..1c6a5456a5caf 100644 > --- a/drivers/net/dsa/lantiq/mxl-gsw1xx.c > +++ b/drivers/net/dsa/lantiq/mxl-gsw1xx.c > +static void gsw150_phylink_get_caps(struct dsa_switch *ds, int port, > + struct phylink_config *config) > +{ > + config->mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE | > + MAC_10 | MAC_100 | MAC_1000; > + > + switch (port) { > + case 0: /* port 0~4: built-in 1GE PHYs */ > + case 1: > + case 2: > + case 3: > + case 4: I think there's a syntax for this, see mt7530_mac_port_get_caps(): case 0 ... 4: also, you can drop "port X: " from the comments. > + __set_bit(PHY_INTERFACE_MODE_INTERNAL, > + config->supported_interfaces); > + break; > + case 5: /* port 5: GMII or RGMII */ > + __set_bit(PHY_INTERFACE_MODE_GMII, > + config->supported_interfaces); > + fallthrough; > + case 6: /* port 6: RGMII */ > + phy_interface_set_rgmii(config->supported_interfaces); > + break; > + } > + > + gsw1xx_phylink_get_lpi_caps(config); > }