From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F5022D7D2F for ; Thu, 15 Jan 2026 19:17:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504627; cv=none; b=C+3zMdJHGV9fb2Zqp1JbeAts3jvuDTAhvmSgrlTjUaWtm3PFPICGX+ZuBGGVyDkfbeChTo/a9CZb7lYO2iJlph826RL5QNdmqzIBD7NYI+sfjm910+eUBibdODrzbZqSAXWnmMZHePFgGXXOPT1Izh8m0DpPJqyUcjitON4Vdsc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768504627; c=relaxed/simple; bh=p7/JBpmEwg/DLwt21Ltch9GHHNbDYW0F+YNcovqYc6M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fXtRtykSOpgWBwzeGyitLHO6BFVd82oMd5f1Cf/izH3tuW5LdDxK6XdSmYLN6F8YeURL9crISKaaXYv8OQENEF8eNWmGaMfmT0Gvt9nNvueXSf1m+UZe4SeD7WjY9dw2jfy4u4TI0L7x8lai+/C70U4hRCc8A+cSMXNFhEsY8B0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Gze0JJsT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Gze0JJsT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25815C16AAE; Thu, 15 Jan 2026 19:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768504626; bh=p7/JBpmEwg/DLwt21Ltch9GHHNbDYW0F+YNcovqYc6M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gze0JJsTR4dkLJ8HSQtzZheXfVmd6BQo5UzzVu0W2rLaaeGj1I9OVOW5kRWJ0xtx1 KU6RdCEcSHuCo1JrYpU1UPoRxLZV5BVVIUp5BwpeTieWbzVJ5neMuiMOqqHsb4TaAw 1MEDPn+ftAfF6yb0qH6ipouKsz8SFyXkT4lEd1g1iUV0XBPc7L7XR8I+eUuGpHJHMS 3KfxvJqN82X5+ykgoFShDW8t5ieEhijUzrM+MLPmnIqgxyHAXm+/JD7wfTwhNhe1cq /NSlcHaNIgK9orqUOhReR+5JCYVyfYoLUmB+HuyCD6+gMGuzQblVgXD4r/jOOuDQRo 6QQFbPXFQNnZw== From: Conor Dooley To: Zilin Guan Cc: conor@kernel.org, Conor Dooley , daire.mcnamara@microchip.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Jianhao Xu Subject: Re: [PATCH] soc: microchip: mpfs: Fix memory leak in mpfs_sys_controller_probe() Date: Thu, 15 Jan 2026 19:17:02 +0000 Message-ID: <20260115-jukebox-material-b3a74f84744a@spud> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251228124836.3681318-1-zilin@seu.edu.cn> References: <20251228124836.3681318-1-zilin@seu.edu.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=542; i=conor.dooley@microchip.com; h=from:subject:message-id; bh=lUBg3Z2kDNpx01FYQs5VphyryZRhXcrmuNWIkmfWTn8=; b=owGbwMvMwCVWscWwfUFT0iXG02pJDJmZtnoPH7DeFovdFX5j+71IlZvTnzoyXDcyWKTbFhS17 szB1Ie7O0pZGMS4GGTFFFkSb/e1SK3/47LDuectzBxWJpAhDFycAnCRL4wMDwS+fHt2ZY2XEUvo Q1PnjXUpwhOsVaf58s6+y8coVFNsyvBXlG9Bv6+ESsv640v7XQvVkw179hn+nXvY/ejfbdeZ3tT zAwA= X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C Content-Transfer-Encoding: 8bit From: Conor Dooley On Sun, 28 Dec 2025 12:48:36 +0000, Zilin Guan wrote: > In mpfs_sys_controller_probe(), if of_get_mtd_device_by_node() fails, > the function returns immediately without freeing the allocated memory > for sys_controller, leading to a memory leak. > > Fix this by jumping to the out_free label to ensure the memory is > properly freed. > > [...] Applied to riscv-soc-fixes, thanks! [1/1] soc: microchip: mpfs: Fix memory leak in mpfs_sys_controller_probe() https://git.kernel.org/conor/c/5a741f8cc6fe Thanks, Conor.