mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jianping Li <jianping.li@oss.qualcomm.com>
To: srini@kernel.org, amahesh@qti.qualcomm.com, arnd@arndb.de,
	gregkh@linuxfoundation.org, linux-arm-msm@vger.kernel.org
Cc: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>,
	thierry.escande@linaro.org, abelvesa@kernel.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	quic_chennak@quicinc.com, stable@kernel.org,
	Jianping Li <jianping.li@oss.qualcomm.com>
Subject: [PATCH v2 2/4] misc: fastrpc: Fix initial memory allocation for Audio PD memory pool
Date: Thu, 15 Jan 2026 16:28:49 +0800	[thread overview]
Message-ID: <20260115082851.570-3-jianping.li@oss.qualcomm.com> (raw)
In-Reply-To: <20260115082851.570-1-jianping.li@oss.qualcomm.com>

From: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>

The initially allocated memory is not properly included in the pool,
leading to potential issues with memory management. The issue is
actually a memory leak because the initial memory is never used by
Audio PD. It will immediately make a remote heap request as no memory is
added to the pool initially. Set the number of pages to one to ensure
that the initially allocated memory is correctly added to the Audio PD
memory pool.

Fixes: 0871561055e66 ("misc: fastrpc: Add support for audiopd")
Cc: stable@kernel.org
Co-developed-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
Signed-off-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
Signed-off-by: Jianping Li <jianping.li@oss.qualcomm.com>
---
 drivers/misc/fastrpc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index 515a43c9d95d..4f12fa5a05aa 100644
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -1328,7 +1328,9 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl,
 		err = PTR_ERR(name);
 		goto err;
 	}
-
+	inbuf.client_id = fl->client_id;
+	inbuf.namelen = init.namelen;
+	inbuf.pageslen = 0;
 	if (!fl->cctx->remote_heap) {
 		err = fastrpc_remote_heap_alloc(fl, fl->sctx->dev, init.memlen,
 						&fl->cctx->remote_heap);
@@ -1351,12 +1353,10 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl,
 				goto err_map;
 			}
 			scm_done = true;
+			inbuf.pageslen = 1;
 		}
 	}
 
-	inbuf.client_id = fl->client_id;
-	inbuf.namelen = init.namelen;
-	inbuf.pageslen = 0;
 	fl->pd = USER_PD;
 
 	args[0].ptr = (u64)(uintptr_t)&inbuf;
-- 
2.43.0


  parent reply	other threads:[~2026-01-15  8:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15  8:28 [PATCH v2 0/4] Add missing bug fixes Jianping Li
2026-01-15  8:28 ` [PATCH v2 1/4] misc: fastrpc: Add NULL check to fastrpc_buf_free to prevent crash Jianping Li
2026-01-15 20:43   ` Dmitry Baryshkov
2026-02-02  6:33     ` Jianping
2026-01-16 14:49   ` Greg KH
2026-02-02  7:13     ` Jianping
2026-02-02  8:41       ` Greg KH
2026-02-03 11:00         ` Jianping
2026-02-03 12:08         ` Jianping
2026-02-03 21:32           ` Bjorn Andersson
2026-02-05  9:07             ` Jianping
2026-01-15  8:28 ` Jianping Li [this message]
2026-01-15 20:45   ` [PATCH v2 2/4] misc: fastrpc: Fix initial memory allocation for Audio PD memory pool Dmitry Baryshkov
2026-02-02  6:42     ` Jianping
2026-01-15  8:28 ` [PATCH v2 3/4] misc: fastrpc: Remove buffer from list prior to unmap operation Jianping Li
2026-01-15 20:47   ` Dmitry Baryshkov
2026-02-02  6:51     ` Jianping
2026-02-03 21:15       ` Dmitry Baryshkov
2026-02-05  9:00         ` Jianping
2026-01-15  8:28 ` [PATCH v2 4/4] misc: fastrpc: Allocate entire reserved memory for Audio PD in probe Jianping Li
2026-01-15 20:49   ` Dmitry Baryshkov
2026-02-02  7:06     ` Jianping
2026-02-03 21:19       ` Dmitry Baryshkov
2026-02-03 21:42         ` Bjorn Andersson
2026-02-05  9:04           ` Jianping
2026-02-05  9:02         ` Jianping

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260115082851.570-3-jianping.li@oss.qualcomm.com \
    --to=jianping.li@oss.qualcomm.com \
    --cc=abelvesa@kernel.org \
    --cc=amahesh@qti.qualcomm.com \
    --cc=arnd@arndb.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ekansh.gupta@oss.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_chennak@quicinc.com \
    --cc=srini@kernel.org \
    --cc=stable@kernel.org \
    --cc=thierry.escande@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®