From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B746633291B for ; Thu, 15 Jan 2026 09:15:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768468555; cv=none; b=NKt6QnLh3CwJJ/LothVMXyX7YRjcocbZcBkAoCjwo5jIY+qf+y84sjMJgToltXg7+nf347WY2H8qZ6V9PUtZ29AMo2hlra259MV99QOCJoJWATmVYMHH6omY/PWTBtXc3686B/VugOSqSZSYaoABwqZhCmKciBwFyvhoJG2obiw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768468555; c=relaxed/simple; bh=0HijuXWJpjwbVYBFjlsD56UImJ6stIXjhDyb2cKuonk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QCgu0AD7Xh6QKHpmA1bf/Pl5dPyoCVnnoiriRKngz8cRHGReYGS4w30ST67zAh8xQAEn4Z0HnZsLkqvR1mVQl3YK+etMm6f09RbAwchS6JpEBxW050nSWcoUmPrM9Q3IL+mElRuug1jSWeMV2x+jYGHVTi92ERv/TLqe3TVqBrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OTXX7YUn; arc=none smtp.client-ip=209.85.210.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OTXX7YUn" Received: by mail-pf1-f193.google.com with SMTP id d2e1a72fcca58-81ecbdfdcebso415852b3a.1 for ; Thu, 15 Jan 2026 01:15:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768468551; x=1769073351; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0HijuXWJpjwbVYBFjlsD56UImJ6stIXjhDyb2cKuonk=; b=OTXX7YUnCYhrg1AwTXyxej5XtK6qSMAW5E6Pnnx48K2lMGod0kyMc9Tfzx0+A/YQO2 /wZbfVE4KfE6jtOm/62GgTY51NmPs++pVlc/zNY1CJxnIreB6l6GJ/DMhFBDh7xtbCwO syCskqbMTE3S00xjM02cggneEp9xgPNaZaavvjL4YRFhZOUvwzs3LVIdOcxHI9U6jztA znGqyqQAN8vndJKpH//bWCgytt+P0vKEHSZnx8DeTdIahjzNk6CVKiazLb4ZsXP8bzuM 4gy+g7saZx7gOekMwrB5u90+sipTnxO8bLir7cjavgJbX7YnEkh+BAYyt3kHEh8Epme2 3l1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768468551; x=1769073351; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0HijuXWJpjwbVYBFjlsD56UImJ6stIXjhDyb2cKuonk=; b=ffdq64zOnE5L94gsjxnY6idmFoC4fD4feuLuFRGuB5/cOcoQd2A7aHkRVT8s6u9aKn 0G0SSXAFhSdCv2mtfhcyz+JizW470PUcAtmx/4BfDima0gJ6BqwM2XVJ4YH388AqnLGL IRfKAZpBtEVQ6hzDUVRKkIqtTBbD1gtR6JaAFPYdvON69aB6DDB5fBg5upeBCqXkTlfo G9rxEzGE8twOB+gAI8uLGXQYkvKrS3lESglB975FYTx/DnNb4THwIAAr2YuGNKuQSKEW u6fC9+0r1fv7pvl6Cto12YRKNPjduX+/1eAzCVgL8NefvqrPegO53gFeAYhV6uv7Qob4 yDCg== X-Forwarded-Encrypted: i=1; AJvYcCV5w1K+e6eMjB+0k+r1p5KaGdZKgOmSdQHRgs6xFZtNsZTAxPZttTvxsrTBOu0wtuBhtyYvEpLDosL5EdQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwiPxOEw+5waXI1l7AnHlrHI2X2XipIi7Q8h/QMG0nINyNuXVEk 33xAqW6bv4tu3iGKoT2B9f1uxTQ+76rA06GMtrtk1mEaQQNQEKdHyashdN4DWlCAQX5/ X-Gm-Gg: AY/fxX65ZBuolFb/NCVi3RBURiH3BxXT37UI2iJEozSzTEQ6z67AyXPAt1QFV26ZVfS ll7/2OKL2OU7WpGFgydVzAbAMBEZClIznPYvo38Q76g0Z8EPAdN0YNXnmq6ngTKTm3pvg8TlbNx ODpq4zdb8rFPKAdXdD3/V4fsRBm7WWFURA0OfKcxAUePX5Af2Xot0IhpvqMvA16XWfJzK1pAQfm b/+CXnjBgTCSQOusbBAAzDYc6dmeHY4vPWwWUHBZp7KKmCIvsrYxXKtHQvky/Bor/LszBT8TKYw J2NhTxZFJsBEE81N2oocPKnT32vWqaTuHe4Li3uZMuTfOtc6/s1GLiKybQShja5qNSPIrAChFi0 aljxHiiQ3sl/Ktzh2sg/xlBURlopRB/mWZTu30XiUQS9Q0NZvHz49p1uahxW5OhiJ2t8+NDXYpC gL7lyZQV3hBakWFuifnFJXBDnrYjCap8E= X-Received: by 2002:a17:90b:3cc7:b0:34c:e5fc:faec with SMTP id 98e67ed59e1d1-351090bdf07mr5514921a91.2.1768468550753; Thu, 15 Jan 2026 01:15:50 -0800 (PST) Received: from localhost.localdomain ([64.114.211.100]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-352675f8e97sm1554321a91.0.2026.01.15.01.15.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 01:15:50 -0800 (PST) From: Jinseok Kim To: kuba@kernel.org Cc: always.starving0@gmail.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, quic_luoj@quicinc.com Subject: Re: [PATCH] net: qualcomm: ppe: Remove redundant include of dev_printk.h Date: Thu, 15 Jan 2026 01:11:23 -0800 Message-ID: <20260115091439.2216-1-always.starving0@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260113190210.5387bde1@kernel.org> References: <20260113190210.5387bde1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Thanks for the review! I suggested removing the direct #include because this is the only file under net/ethernet/qualcomm/ that explicitly includes it. All other files use dev_err() etc. just fine via . But you're right — relying on indirect includes isn't ideal... I'll leave it as-is for now.