From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D29D6355807 for ; Thu, 15 Jan 2026 09:15:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.109.113.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768468541; cv=none; b=UuZl1SQTHYM98I0MOemn25PDrSiJH0PwcOEFv8JYjSPcf9h6C/1sphai7IbQs4mFh/T9Ry8TViyaqNr40x6MsglZIYG+BMma1TifsJ2H9RSL/98Ag6Ffw1SoSdUTzbmXWyi+lC80W9zyiux0sgkIZ57uWnjodSwClaHewqA6pPM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768468541; c=relaxed/simple; bh=MPR9KavO5le86ow7dJoKIRX+tKduALpqUa0AePcvBPE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SfTogW+ru9sNlAjHWKRLmZctuo7imUTtWbuu1CIHGkCBEHfNXfx5HFBNxTA04/5jlc6tBdPNxX7pt9nrjntWmVN0/GUCOF6NcoENDD0g63siXwggNRrUMx1hIoNyU6eJqpPNU0GMhHmtTJEYu7buI/Jii1dVTrOmzhnI3npmBno= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de; spf=pass smtp.mailfrom=alien8.de; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b=AHB23mS5; arc=none smtp.client-ip=65.109.113.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b="AHB23mS5" Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id B459F40E0252; Thu, 15 Jan 2026 09:15:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id wHa4IiSPLtWb; Thu, 15 Jan 2026 09:15:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1768468529; bh=MpFeEPdx/HwMDFlhkyWR1GrXuBvpju/ZBMFFI7lWMEo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AHB23mS5rd2UMxhKIr2VAljWDDjORnouieVbj7QjgYloOdNDU7yWMInTvl1PfwRfR lqrCdU6r5U1WwHxOavRTmh+jgtPSBVXFlQqQ0S6qe2A1ouX9nMgyIfGIY1LXRQn3hk BRjTREYY7iviplQmYVk8tbeFuoUXHa5vpNpcxeiG7xIte/5t9gU5PnCmuqumFsVejl ZHqiFg8nZCDe28wbIBY2AVl9MBzFoiFOablFn1TWlbbnsYPxq1p3clFmR8y+jPKgag h5VxT3MUvm8+rhrfTvu8ea5A9LQB36wKeE/TvWZRcJ0rgRJIh/FzAkGZSrmFUn7kMA TJTQSE83WXH5QQjZ1v2n5SXbhthEbANm6NL6oWBOz360Dyk/KHagAjX3Enr3xDm0Sk Kb/OSAVjDwwxWTvJfuuqhLDgkTj/HZA0OSjAObgpnwEx7z+/EO1LNee175abss4HnY +QWyvYmIkHa9JcYwTL/xQevZHXBggZf3GfbUdQ0Ykkw/THX/sO1YEObbI6krNLkcYR FmzBkgEENb1FVGhJZZ2B+RS4IGzGLxkYfQ/jabjG+FlqnVr/cuZClfY6TMqFubfwoZ jH7FqZeYSrjoR4dmRo+MvYGDllAsE8aIzVqxD32Km0MC2I+0rZtDD8C/OK5bYATEO5 J5NjX1mZKsSYcfOIIMvhPWZk= Received: from zn.tnic (pd953023b.dip0.t-ipconnect.de [217.83.2.59]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with UTF8SMTPSA id E057540E0028; Thu, 15 Jan 2026 09:15:13 +0000 (UTC) Date: Thu, 15 Jan 2026 10:15:06 +0100 From: Borislav Petkov To: Hou Wenlong Cc: linux-kernel@vger.kernel.org, Rik van Riel , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Will Deacon , Ryan Roberts , Jann Horn , Barry Song Subject: Re: [PATCH v2] x86/mm: Hide mm_free_global_asid() definition under 'CONFIG_BROADCAST_TLB_FLUSH' Message-ID: <20260115091506.GAaWiwGnvRTOOUVGtv@fat_crate.local> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Thu, Jan 15, 2026 at 11:38:34AM +0800, Hou Wenlong wrote: > When 'CONFIG_BROADCAST_TLB_FLUSH' is not enabled, mm_free_global_asid() > remains a globally visible symbol and generates a useless function call > to it in destroy_context(). Therefore, hide the mm_free_global_asid() > definition under 'CONFIG_BROADCAST_TLB_FLUSH' and provide a static > inline empty version when it is not enabled to remove the function call. > > Reviewed-by: Rik van Riel > Signed-off-by: Hou Wenlong > --- > v1->v2: > Keep the declarations of mm_init_global_asid() and mm_free_global_asid() > in 'asm/mmu_context.h' to fix the compilation failure of module > building. > --- > arch/x86/include/asm/mmu_context.h | 2 -- > arch/x86/include/asm/tlbflush.h | 3 +++ > arch/x86/mm/tlb.c | 4 ++-- > 3 files changed, 5 insertions(+), 4 deletions(-) Did you run the build tests I asked you to do before you sent this? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette