From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D1063054D0 for ; Thu, 15 Jan 2026 09:18:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768468737; cv=none; b=oExu1ELLflg3/q5BDhR0kg01w56e+SMeutruiXrdNNW+GJDVujKQyT6OVxukQZr+E8YPFkNOy6scOIM59O28+RhKTyNDNpmO2T3MGoTmG0meEXRlPqEiv99twDcCHddZ9ymOsivM7MSSI7jIYzMmNSazD/VZkGGGGGah2s3L9hM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768468737; c=relaxed/simple; bh=Uime7dZmNkMTLPWVfuwrvyaoBD7BKWQj9kmzWs//XRo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QNRkhGAeWf8YzBGPssjRM1Go4GRx+9wtwc2uaXerVv/lHYYjjXAiu1UiVf0zd+2mKrX3VGXgYR4d0TjUdYLATeOMgHUf+Pu+VPwTdBtpHuBShvCH0RWp3pm7S+y1oGDIh9E1qBnTGJKXp2TCUWJGWBgNnA9nGRbeBqLRadtyIlw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mej2Oa1O; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gf/RdC16; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mej2Oa1O"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gf/RdC16" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60F6fkjG606445 for ; Thu, 15 Jan 2026 09:18:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=fzkDdKXt9AvR9DQcSSyHWpFEK7AjBSdC9iV pDB6Axzc=; b=mej2Oa1O86atLwqoE8xQjXpPiUT3Cm6lpuRArsjgvD7D01xXRvr e9CV0LjlmmY5oy21RAUFqyj03jifY3Fitieq76hTy0hO1o1ALBRZxl0zRmvUNQoP M0jfKB9a//w/b+e3xRes2hsGxNgADyUZCUssrpfAJ8GbSVF7a4HWWhao3GyESuRQ 1fBEdtVsehMjY/oiWlGMxykPm3SLRnLGUZ8vTcCr8ykAySzGIyv6Tp0bXJQTiYUN fA19iRCedcJuJZjtnLWGI5qDoJvSKPPy1pp4LJuXc6CqMkAa7+r2Vrq+2HlZ0ZJj QOebA6G7cYX3CyLJcZa9E2Y+5Mak6qls+Mw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bptna0hmw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 15 Jan 2026 09:18:55 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c52f07fbd0so312422885a.2 for ; Thu, 15 Jan 2026 01:18:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768468735; x=1769073535; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fzkDdKXt9AvR9DQcSSyHWpFEK7AjBSdC9iVpDB6Axzc=; b=gf/RdC16UeMj+2rXFBa/2tsK8e9N8cYtqOQX2Nqg8etl/vJvnupaE8LuhcZjCHzuQ/ AypYxsi/t/FUdA4HJd9GY0PNRuMMl4o+I3p3ONT8AxcqzHOFoN6QJhUfHyL3L4Uv3bzi xAAS16SZF9MAVIrIDMdniOLxPvJ5+keEm09p5zFUCDGMH2v+YrVwyWbgfS7Z5o1iw+mD Q6Vt7tqXY/qM95rfE8CkLmoWLGmB49PRutzS7r37nJm+rW+Wf4fb9+yiO4NU1hLCtQQC pIxlIl0sMxdZLKWTXLNqfT1jWM+/dTMZD0s3PjFBV4zIEljuXhbAnR1nwk2SeOU/RfCQ 4G6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768468735; x=1769073535; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fzkDdKXt9AvR9DQcSSyHWpFEK7AjBSdC9iVpDB6Axzc=; b=blQ3B9vQVxOy86ki4aroncf9Dihux/UJtOAuqCXdSv6f8Ru2zCdnYNcgn+5iPDUGOj 7dwPOZa196f+sfOrcKBD7GFVDx3DSik5uiVdwI8KEv64YidDckNcI9QR4X7qiRKqO4UQ AeEWnnCN7hJrGLMdTt5ldHYChR6Rw5Jhb4VU4Kql5+OW3lo4Bmf2EjFRg3Anou0KHY9X KH1lWkrDVHfjnKT/yBeWulVGmG/rMdpOD46MOA+JaIuFeXJasrOHtxQ8ldwbpS52Jc5N jtOnECOZ2IqhfwtHaJd2bDR7vLF2Z1YT6VLqgPJPjKero45bAGu+OETEBuSk+RgmH6M7 F2FA== X-Forwarded-Encrypted: i=1; AJvYcCU9jCxCAK+jwaLVbKM2odZvq/5Llw6eK/NjGUOJEDFpHgj4K7cJVLYv4WWJYWycz5SgfYjI47IGt2TVwts=@vger.kernel.org X-Gm-Message-State: AOJu0YxyjbsRuPzs0/Bh/sERThfN0xYq16F4m1TV3v1JA6STxut8Iy3K SfNN0D2SjaAj45GNJsaOg5StCQwLjVyFThp1t1j8iwpO6RHseJuZ7npRP7bEVXYPX12FwXY4TPH H48ce9DMp3dms8yZv+f8vk0qy12MOPVuCM97xXrijmTn4h03qVB209yKAror3gklvHlg= X-Gm-Gg: AY/fxX4mF5YxrgoSIaKvKvmxVBdJYq3g34sHnTb0Jvp5/s+NQVPL+ZJx7bByGXSeWnp t5T2lvmI84wEJrQaW9kq1uSrYqmT8phPd28GiVWvjuzuttXxhOJ9c+M1/aYg8PxK1umJNhHa0Dk GFn7sbzdctD8YnyYuSLipoWKaRBR4XEBAzpm3M169jYE1OSAiua30BTwZVnho5Nrt1pjDjDYhz/ xVjWwbLTwvTFIt6C1GQGjT8LVU0RGXIV3QN/5i6MSSxG0MJOEEWgL1QB7yyUTkrubOoPSeiJfiT GeGU/xauKS33RC/8mSkJ/UXVEaGHwrwuDoU2C/Mptgcr+/hflmRGT0sFRT8CcUip9/a7V0gR+Fj JIRLuWzPJvVbnnozHzVdW7h9ezdtgHdDY5O6nCA== X-Received: by 2002:a05:620a:290b:b0:8c5:c9a0:ac28 with SMTP id af79cd13be357-8c5c9a0afc6mr296272885a.21.1768468734909; Thu, 15 Jan 2026 01:18:54 -0800 (PST) X-Received: by 2002:a05:620a:290b:b0:8c5:c9a0:ac28 with SMTP id af79cd13be357-8c5c9a0afc6mr296270785a.21.1768468734515; Thu, 15 Jan 2026 01:18:54 -0800 (PST) Received: from brgl-qcom.home ([2a01:cb1d:dc:7e00:b2fd:6f9c:25ce:7df7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-434af6fca57sm4459984f8f.42.2026.01.15.01.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 01:18:53 -0800 (PST) From: Bartosz Golaszewski To: Rob Herring , Saravana Kannan Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH] of: guard pointers to key OF nodes with an #ifdef Date: Thu, 15 Jan 2026 10:18:39 +0100 Message-ID: <20260115091839.8206-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: XMsdOKaDsRqVcnNDNduba7bGNi0zRtTi X-Proofpoint-ORIG-GUID: XMsdOKaDsRqVcnNDNduba7bGNi0zRtTi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE1MDA2NCBTYWx0ZWRfX1cIa0YtY9XZX Cvy6416pfjiVki/FGW4mmeSzHJ0xWPWrwfGrssP+eeHTR+dFwjEhOSpn4UZC1NN7VOAkiBWGo/9 77INuD51PyoDyMD9sp2O5TSaOO0WPCzL7NZ5k9KmYNTT56sUdjnybzDY2wp/nk2a5p1WU7bz+3y HptC4ULz19OQ5G/KoQH6LdJiTMZn3Q5oKH+/KqeLvQVwgebYki0GY437NOiSzqTD3FcdmQUrFOz vmpJs7MpEpoOsqWmMbBjNcntOjJsovlsigwoDgVL3gtwligEX+PUrie5Y9Sv/02zFd98toi3KVB qs+mEuZpg5kc5OiXfVdIJ5JsrMb1O6NeYoGVrfg7biNKppzJjt2UMtm/36PIgDj2HJ6EzUz/VCa OVeZNrg3AXyD8WmteVjVkcXQR0xdwCixJtlm2L2OEC0wpnuiW5IYFZ38mLeEgZIOJ1dvs3g5ZiT CUnLzzj/mY+Fm6K4/4Q== X-Authority-Analysis: v=2.4 cv=fsHRpV4f c=1 sm=1 tr=0 ts=6968b0ff cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=CLJF6lgPrjtTUpQcK-wA:9 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-15_02,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 bulkscore=0 adultscore=0 spamscore=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601150064 We declare the pointers to some key OF-nodes unconditionally in linux/of.h but only export them with CONFIG_OF=y. If anyone uses them in code built without devicetree support enabled, the problem will only come to light at link-time. Add an #ifdef guard to catch it at compile-time. Signed-off-by: Bartosz Golaszewski --- include/linux/of.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/of.h b/include/linux/of.h index 9bbdcf25a2b4..bc57dff819f8 100644 --- a/include/linux/of.h +++ b/include/linux/of.h @@ -138,10 +138,12 @@ static inline void of_node_put(struct device_node *node) { } DEFINE_FREE(device_node, struct device_node *, if (_T) of_node_put(_T)) /* Pointer for first entry in chain of all nodes. */ +#if IS_ENABLED(CONFIG_OF) extern struct device_node *of_root; extern struct device_node *of_chosen; extern struct device_node *of_aliases; extern struct device_node *of_stdout; +#endif /* * struct device_node flag descriptions -- 2.47.3