From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCB9742049 for ; Thu, 15 Jan 2026 16:50:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768495858; cv=none; b=Rd8/Nllv/LsUO/lhuv14UfYFFCFTSw7fq+ggUg5oLQffrv8KHzUh0xcojL+kqvzc76itLoz7oYGD1NWwEac8Z0iB6VNj2tBBuY/+4FFCkws/l7BWVG42KxUwPlrr2A3qeFLkiaaELU/rAxc9SOxzmwQfzzI1yguw7a7QCGH9KaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768495858; c=relaxed/simple; bh=0bAHEY7ff2Q8E5C6vXUVAPLo5jv8Vnp2PPLiRrb00mY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ffp9FOgZqNgPCKHSigyetBhF+rviCE0Ug1dvUlGFteyb/Ikr4hyo1s6vTWnYxe7nL0gHiacruHE4Il26nbh8HhVSmf2eyl0Fnwe38jzAUUg/UO8nm3hVj8tWx4bwyiSRM72wWYlJo0ecOw+abBWyHX7KuTZmw37jo1XlKkg7E3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EbIoOOAX; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=DCV78onY; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EbIoOOAX"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="DCV78onY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768495855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SljNJ9ya7guEeZDCesmPS6qTlCZIDBdh9EBAuJaiH00=; b=EbIoOOAXqZCoNaTl1R3mE/eL/2NoYooj15JxVZ08ls3ycbqMyx1yr4NuhFcv5Y+BC9ybk7 Xa35qzXorhcyognZdNj86kH13ecNXXDqGvVjkuE74ZjMlvSREJnbRjoS/DWpLdhwZaM+3P w2n/nSePQItE3SLfhTb4C4WGZuO+pZE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-e_IoUj12MiuOGKfeqhH-sw-1; Thu, 15 Jan 2026 11:50:54 -0500 X-MC-Unique: e_IoUj12MiuOGKfeqhH-sw-1 X-Mimecast-MFC-AGG-ID: e_IoUj12MiuOGKfeqhH-sw_1768495853 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-47edfdc6c1aso8086385e9.3 for ; Thu, 15 Jan 2026 08:50:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768495853; x=1769100653; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SljNJ9ya7guEeZDCesmPS6qTlCZIDBdh9EBAuJaiH00=; b=DCV78onY2krCTTrP+URc/4FHWkSj9kMT9anFNiog87H/KXvh/QQXic64HVV6cZF+t/ 9pmjvYw9vnqE2qgoIQ2/4th0Pbv3ra0PigzBOSo/Xh4ooWeFJ/Es6j5i/m6uutGOCFOt 4Vkv3ZHICQcaXKWXbqPEy58RsmCKkZj11GcbG4CfDBHG7WLH2DJlY+iX+6Y2LCDHIDGC /rTBYvNr6o4dSiaokIS+mQzOQ0gUO9HBFb92vAXHY12DMjfgZUSIWanMmvji+SWUi2Et bjv5+JzvueZ0A+sSww4ezs/c5tlwRHeSYM7H0zf8y0PvjpF4nRTVhd1ab8iGMRQkMLEt p5Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768495853; x=1769100653; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SljNJ9ya7guEeZDCesmPS6qTlCZIDBdh9EBAuJaiH00=; b=tZyNlnBz+bjgTbZXFGNj2AZt7pwbFNtrjyQWPduIQaumToXV9u4b7AA+a/gp9psnGF L0/c1TbealdhTNRUwRLxMxXCbliyBXjjYz/Tat4t9NqRfJ0LBpKWZLoDGriT2guXVdhZ U7Q3VLCBq9dxoHoNkyH8F9DCuyzq78GQWtivdHRNqGfothjApNtUY2i4dsidWxAJ3eru MLvKb/p6o1ypjapN1K9l5Re0MQ1a+MC+bQLVla28qEPswx2BbtVmpMXtIELc5x4UEfKj K6dXS32KBfbjwL6Rf1Qpe1qH8etXpg8n9X3PrQh/W0e2Q7Itw1FJ/t7ETq4lVJDBCEWH eZog== X-Forwarded-Encrypted: i=1; AJvYcCXnhBFCqB+bQYnO/ubKL8sFBrMCKVBhhmKyd/t5NuR+P3EEOL+7wKTyPGrYoXt6yoBAxCbJ9CQ6z7TnS4s=@vger.kernel.org X-Gm-Message-State: AOJu0Yww9gpVx/xI+phF59E5c5OZ5vOx34OSZn94oZ8uotVf0SQ1h4Zb LuDS0AclM8T9Bfa+/Avksaiy+sVMcKsdXt2smB6gXXErEgR1lDGMAolbAJC9kFmLSh5CnyqVA/O mNjhW0Bq1iGELN9MOmBkZ2ZmAkMXf8k6oFAQ/fFz+TuwA7+pwxgF82JCBA0YWG6xyyQ== X-Gm-Gg: AY/fxX6XUGGHNJ1i1GqypyzzMRId4OeB2JRRrPwBDYS/juucc+GggsiTwNF+X/Rde/D BFuZ5EjNOTjFpMwn9n3+cLcNDEmrQDTnaHHErInxkjfFqou5cbwndrjCAs8ce8uf9uJAHM2MNTk Ygl8Cy38H4vnFSbkgZQ/QIAcZRDOsfVpIGmCnzx8BWPJfuv46ZYlTYpoWfgNkMBPw0lBe3eWbrP M9mMqTqwkS8BBKoaU42jvChRKgKdi2E+SdvjW8g4eGCDTIIV4RLcrkcV+0dU4U3RztORVY6otN8 1klKFrTkV+vDcjTVnBaw6ioFoGkl1+PdbiYCE/M4cnvqv1esJ9KuuwvjKpfVXZtQSr7QYePrmL/ MabU/KqpDj09wojW0U12QvsifxT07GA== X-Received: by 2002:a05:600c:45d5:b0:47d:264e:b35a with SMTP id 5b1f17b1804b1-4801e30aecbmr4637235e9.13.1768495853179; Thu, 15 Jan 2026 08:50:53 -0800 (PST) X-Received: by 2002:a05:600c:45d5:b0:47d:264e:b35a with SMTP id 5b1f17b1804b1-4801e30aecbmr4636905e9.13.1768495852632; Thu, 15 Jan 2026 08:50:52 -0800 (PST) Received: from redhat.com (IGLD-80-230-35-22.inter.net.il. [80.230.35.22]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f4289b7aasm57337815e9.2.2026.01.15.08.50.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 08:50:51 -0800 (PST) Date: Thu, 15 Jan 2026 11:50:47 -0500 From: "Michael S. Tsirkin" To: "David Hildenbrand (Red Hat)" Cc: Lorenzo Stoakes , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Broadcom internal kernel review list , linux-doc@vger.kernel.org, virtualization@lists.linux.dev, Andrew Morton , Oscar Salvador , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Arnd Bergmann , Greg Kroah-Hartman , Jerrin Shaji George , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Zi Yan Subject: Re: [PATCH v2 22/23] mm: rename CONFIG_MEMORY_BALLOON -> CONFIG_BALLOON Message-ID: <20260115114849-mutt-send-email-mst@kernel.org> References: <20260115092015.3928975-1-david@kernel.org> <20260115092015.3928975-23-david@kernel.org> <219f7be4-8355-4376-bf97-3410c6e23867@lucifer.local> <37fdb994-59d1-4196-b377-f3f749148b19@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37fdb994-59d1-4196-b377-f3f749148b19@kernel.org> On Thu, Jan 15, 2026 at 05:33:56PM +0100, David Hildenbrand (Red Hat) wrote: > On 1/15/26 14:55, Lorenzo Stoakes wrote: > > On Thu, Jan 15, 2026 at 10:20:12AM +0100, David Hildenbrand (Red Hat) wrote: > > > Let's make it consistent with the naming of the files but also with the > > > naming of CONFIG_BALLOON_MIGRATION. > > > > > > While at it, add a "/* CONFIG_BALLOON */". > > > > Probably not relevant but cheap for me to share :) so grepped for > > 'memory_balloon' and saw: > > > > include/uapi/linux/virtio_ids.h > > 44:#define VIRTIO_ID_MEMORY_BALLOON 13 /* virtio memory balloon */ > > > > This maybe relevant (I guess this isn't actually used anywhere?) though > > interesting there is also VIRTIO_ID_BALLOON... hmm :) > > Yeah, we want to leave the virtio stuff alone. > > Now you'll learn something you probably wish you wouldn't know: > > As you spotted, there is > > #define VIRTIO_ID_BALLOON 5 /* virtio balloon */ > > And > > #define VIRTIO_ID_MEMORY_BALLOON 13 /* virtio memory balloon */ > > > The virtio-spec [1] defines ID 5 to be the "Traditional Memory Balloon Device". > > And in there, we document that > > "This is the traditional balloon device. The device number 13 is reserved for > a new memory balloon interface, with different semantics, which is expected > in a future version of the standard. " > > That's in the spec already like, forever. Likely, at some point someone wanted to implement a > new version (for whatever reason) and defined ID 13. But that never happened. yea Rusty wanted to do that. balloon has lots of weird bugs like it does not really works with large guests. We really need to get around to fixing this, and maybe it's cleaner to do that with a new ID than trying and failing to use the old one, was the thinking. > So now we have these beautiful two device IDs. > > I'll note that the spec also defines a "DEVICE ID of Virtio Cpu balloon device as 47". But > no changes really happened in the spec with that for the last two years (only the > id is reserved). > > > [1] https://docs.oasis-open.org/virtio/virtio/v1.4/virtio-v1.4.html#x1-4260001 > > -- > Cheers > > David