From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0875F1E834E for ; Thu, 15 Jan 2026 23:25:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768519555; cv=none; b=HfyzV9TmbYIQgZowGifpZRTg+O6QOAWn9DFrWAlaqJOpHGCPd1kjAo3zMD2tL1cwFHZC+tKcWYdL9gT2xSJI4ISN1Hoz/MEAxrzwgXN3e1WqsBYZcWcDeB8lNC9HZEUt3TCuY89BuJ/HmW2hE/k4fwwdVBegGh4Bt8wQgCUUR40= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768519555; c=relaxed/simple; bh=KNI/oHIqBgfFMx6fcMtlSdr/1pF66dBuyIEfjvW5BCI=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=ERuVCX3z0/rJ68kradClpnviUU/MaoeSyWQa9Cc9ueoVpSMBwMNuAcQByk+AqCu5D8Qq7OPWaPkmJ95H4BuBehIB13wd0OsFVcoCNeTelsmLAGN8LfNaIDwi2Z4PQGdOaP+HtKZDzr47Ws3nmTAfgrVJbCcVA4OhpmXXt8mrpbc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=FTE+9Tee; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="FTE+9Tee" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6725EC116D0; Thu, 15 Jan 2026 23:25:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1768519554; bh=KNI/oHIqBgfFMx6fcMtlSdr/1pF66dBuyIEfjvW5BCI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FTE+9TeeEEAG4pXswNt4OyPdglAjdYLJe/pzK6B3nrjYX3SqXI5Gc+N6i8v/7or3f 8Eu9PDuruH3sHUyqe5XcIRMsEnAnAfqzWfwRul7b/pORFHmx8/Z3IEsrCP7bctrpOX cGInBrbbDu98DSivWANNSLRM2zVmYVEEQeM3sYu8= Date: Thu, 15 Jan 2026 15:25:53 -0800 From: Andrew Morton To: Sergey Senozhatsky Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chris Mason Subject: Re: [PATCH 2/2] zram: fixup read_block_state() Message-Id: <20260115152553.ecaef2749017cf2e8f171390@linux-foundation.org> In-Reply-To: References: <20251216022727.578BFC4CEF5@smtp.kernel.org> <20260115033031.3818977-1-senozhatsky@chromium.org> <20260115140743.f7ada77bc912595a580eaf7c@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 16 Jan 2026 07:54:25 +0900 Sergey Senozhatsky wrote: > On (26/01/15 14:07), Andrew Morton wrote: > > On Thu, 15 Jan 2026 12:30:06 +0900 Sergey Senozhatsky wrote: > > > > > ac_time is now in seconds, do not use ktime_to_timespec64() > > > > Please help me out here - which patch introduced the issue which Chris > > found? > > This one: > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/zram-use-u32-for-entry-ac_time-tracking.patch I figured that out when I fouf Chris's email ;) > > > Reported-by: Chris Mason > > > > The Closes: link would be helpful. > > I thought that for fixup patches that are still in your tree we > don't need Closes: tags. If you prefer to have them, it should > be this email: > http://lore.kernel.org/linux-kernel/20260114124522.1326519-1-clm@meta.com Yep, got it thanks. Closes: tags are helpful when reviewing, to see all the info. Fixes: tags aren't useful because the hashes are unstable and because the fix is destined to become part of the thing which it fixes anyway.