From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 400CA2550D4 for ; Thu, 15 Jan 2026 23:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768519738; cv=none; b=iiQm1sV0H2wkEdsgyGWeMGjHwZIhMojj0xWF7nr5vUKA+09DR9r+kpA5V2T0lZRZGmLScGEy8cNnEicV/5Bl3ib0EURSeU6jiYWo1U8q6nHCuMxxTaZy1S70o9aaNK4iPevVmN3tk6uz+rYAORkwODeD2VJQEIFedT/xm3m7DlM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768519738; c=relaxed/simple; bh=Bvwc3X3WJBJbTg1N2DXq3p4kRKsWdIQU6EYjrve+vxw=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=GvOSBlPiug3PWwyIn3WEwOPuJMLfAmcN6HEDKmR9lLMulh9Sd6FmJ27K59wZ+fkkaQ9neiiXltLWIPVP9TLCpJD76FV/N7AzTTnErfm0hVfl3lZPhwO2GrVPBZIvAxWKgyRiILcxDM6xcb0dNqF/OGTj2fg4cMm5GO8HzrP5MPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=ZU24qkv9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="ZU24qkv9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5FA0C116D0; Thu, 15 Jan 2026 23:28:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1768519737; bh=Bvwc3X3WJBJbTg1N2DXq3p4kRKsWdIQU6EYjrve+vxw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZU24qkv9XZto10pPpWBvkasZo4wUruWwuxIfB6fsnX0Acm/WNrzbPKNUG/T8xTzYQ wYoeUi/9VIzoety/1gqQHozIzjhuuaFX4BqZVX1c59Rg34bIFHO1wEVRUmyDm5Gfaz /zNDqgYZP2tl8W8WbxfkOMo2jYrF4SUXGGAigLy0= Date: Thu, 15 Jan 2026 15:28:57 -0800 From: Andrew Morton To: Harry Austen Cc: Huacai Chen , linux-kernel@vger.kernel.org, Lillian Berry Subject: Re: [PATCH] init/main.c: prevent warning on lack of default implicit rdinit Message-Id: <20260115152857.12f32b47493d61d9948afd85@linux-foundation.org> In-Reply-To: References: <20260114220139.4685-1-hpausten@protonmail.com> <20260115120215.1575388b1f01776a8e2a8fbe@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 15 Jan 2026 23:09:07 +0000 Harry Austen wrote: > On Thursday, 15 January 2026 at 20:02, Andrew Morton wrote: > > > > > > > On Wed, 14 Jan 2026 22:02:27 +0000 Harry Austen hpausten@protonmail.com wrote: > > > > > If rdinit was not explicitly provided on cmdline, and default /init does > > > not exist, no warning should be printed. > > > > > > Seems that we already have a very similar patch from Lillian: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/init-mainc-check-if-rdinit-was-explicitly-set-before-printing-warning.patch > > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/init-mainc-check-if-rdinit-was-explicitly-set-before-printing-warning-fix.patch > > > > What's happening here? > > Oh, interesting. Have those already been accepted? They're in the mm.git queue for the next merge window. As such they are subject to test/review/alteration/dropping/etc. > Looks like there's no > additional ENOENT check, so the warning gets printed even less often, which is fine by me. > > Apologies for missing that this appears to have already been fixed and feel free > to ignore my patch. OK, no probs, thanks, please send along any alterations to Lillian's patch if you see a need. linux-next would be a suitable base for that.