From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 466802566F7 for ; Thu, 15 Jan 2026 20:07:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768507678; cv=none; b=N/nPK4atkhvP61D1iGbv+IQ8T9IRDc0yUdWkXb2SlVCN6l7uNlTHUXtpxzAcyJZxrxD6C4OmxgenqnJ9+7QtCpZrtBY2TrvPDgle5hdUL11V6fA0hhNM5Xe5Og635lrPIiIR8XMK5WKRYf+kE4QY8NdJN8jmo8sU8Bv5s3kWxI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768507678; c=relaxed/simple; bh=yrE7IOQqthOedlGVLcfQ1vEPrkgd7l4yvg6Kz/NXsy8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EOekAKcHIqRs5QzpnnksBP0kYA9n61WdzKB5t3MrH1YYCwMbf1rll1ft+VsWR3S5qxS4JL4azW3iUqQahpORAXkLool7ueM4fPg2FcSfSOq6NwwBGbXisz5NMDT6cug2pjDpAzVmuXiHaic8fdY8Uyee1Sh14I7fnUKa5FKbT+0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hkiHdU0H; arc=none smtp.client-ip=209.85.128.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hkiHdU0H" Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-790948758c1so13081327b3.1 for ; Thu, 15 Jan 2026 12:07:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768507676; x=1769112476; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5VF9kI5O9H97HnOZtL/a0iX1DIBiawVieSoxgvaDO+U=; b=hkiHdU0HN+z9psewIYdlLRAlhKObf79/onEQChIPFYjb+8cFMMp4dbSv6G6gkIY0DW LzYTfRt5nYTQSwkwjJmnxJKKzWro5HfbuIPoYI0s6q52aATofH+jNFoAkj9PR5pRxVTp IHTcZuw+pd46G10phtAUshbI3y1GWgrAcjd5RZCReBdTcd+kvOIoTeVP2hcsvSYlNF/8 lbEn6SMo4CqYi6otjvXmuZFJFZ4iDQ/Ai0qSBDI5oe8AglwS/bN4LY19S5PpbDQUT1S9 3LZrjv8HrP6dVsKMu4ucowPncyiVyPjXID7ABOS5CYz5/YYGWKeIafD0fgmxEvhAabdK HuFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768507676; x=1769112476; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5VF9kI5O9H97HnOZtL/a0iX1DIBiawVieSoxgvaDO+U=; b=G1C8DSpm/mxqOBY56mvlTJW6TKpAU7Bea2MvUxctVcQEHkkInappNRM6tAgwliooec hrWYT9mZ/9fv8kpi64ehrRQ04X3ne2MLwkdf7o6l7BqNJzxFiNXS2b60gve7JwQkE1cp VpXDQMtbZAw7AeCZZkanx38WHkdvlXD+TRU8nOyFqfzXB/Yzks5C3ya30AQb3kmLfHmg M7DpJ0/QuCJqK4jsaDPy2iY1iOC4kaGVeDJ4SxulAt71+CSZKqrPjI2vnUIgtOG/U5U8 l4ODC9cjwnArjMzHD2WwkBtJT2w77+mVP5ZwqcM/yMhfMSqFNJjBxPs/oONfSOXGzuTJ FGGw== X-Forwarded-Encrypted: i=1; AJvYcCV2lRPnp38mQwt3y3E1E87QvQOYmM9HJP/LupF6sPOlcA+F5MrdYQXAMSlRFUsRdmPvz5Objlhr7ERhSVQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyOCokWrEt33X+G3HfcfdgiPFQTy9khlElPlRfLMvV6Nz1pntp/ PCWipWp+vk/32jTGHi/15wT8z7JxBucogTSrnGW/0e+d2QY70ctDmHXV X-Gm-Gg: AY/fxX72fpg2u1w8clIcCPPiskXma7DHZXYZog9bAybFxxxXLCBPiEB5coGTjdQXb/f d1j2orQyV/iobI7DrY57cASdRiqgd3GAgZmDIEc3JnnHOW/kLVcMtUO4qCjhErPOWv8KtzGB5lH 0z6duTIXRNjUPxilwiGHuIY+JtXUd3/Me0c4XZT2COOMGOrCt/VsQ8NJvd0St3C5TzJv/3tEyIj J1NcvAXw3aAKLrD7SLzcLyQIPe0mmDJKExKugprPXkq4JaVCybU/JW0d9/W9/cD7xvBalv1qtwM r5bCpNBiTYuHWlwSGdFNOIynnep0QJWxCY/F33/WILCugTBABwmWkno6+KQKOrpCg1rmeIXtkYn HNd9H/CefQCiY7vCqXoaWQCGSyYOs+gpVFODBa6KfnOMcuoOd6VL/kpC0tRWT5Z+aeIvXsDoeLd zq4ZVkJfG3zg== X-Received: by 2002:a05:690c:1a:b0:786:5620:fae9 with SMTP id 00721157ae682-793c53c6ba6mr8735327b3.54.1768507675354; Thu, 15 Jan 2026 12:07:55 -0800 (PST) Received: from localhost ([2a03:2880:25ff:70::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-793c68c4167sm1111377b3.52.2026.01.15.12.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 12:07:54 -0800 (PST) From: Joshua Hahn To: Manish Kumar Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: prefer 'unsigned int' over bare 'unsigned' in page_alloc.c Date: Thu, 15 Jan 2026 15:07:52 -0500 Message-ID: <20260115200753.1002036-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260115194845.118064-1-manish1588@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, 16 Jan 2026 01:18:45 +0530 Manish Kumar wrote: > Change the declaration of 'seq' from 'unsigned' to 'unsigned int' > to follow kernel coding style. No functional change. > > Signed-off-by: Manish Kumar Hello Manish, I hope you're doing well! The patch looks good to me. However, I just have a few comments about the other patches that you've recently sent out as well. I think it could be very helpful for reviewers, if you grouped related commits together (in this case, mm/page_alloc.c cleanups) into a single patchset. This lets the reviewers view all related commits together, in each others' contexts. It would also be super helpful to Cc some of the reviewers / maintainers who are relevant to the change you are making! scripts/get_maintainer.pl will give you a good idea of who might be people who are expereinced in the area and are willing to review the patch. Thank you for the patchset, have a great day! Reviewed-by: Joshua Hahn