From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f48.google.com (mail-yx1-f48.google.com [74.125.224.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38F0229E117 for ; Thu, 15 Jan 2026 20:11:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768507873; cv=none; b=pAeKxM3xwstPuq4nUgmTcAX4npvCIjbCkYrwd3z/8OR5Kqq5IT9xA6Aex/4CfhBbE0rfWekq+sy7B/oZkfWtDIjXqHMAfbBpsjMDrAVcIEJDsxsItclASfeBfnMf7fRI1T6K54X2YVdlvfehBAexTWKpgb2jUytmWMrkFy8qRiQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768507873; c=relaxed/simple; bh=STQlD/PFWClSPedFmYeeH5BjF+JZ683tYfsyUeNGEu8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ksQ1tCd1QYV878TSmAHMkywV/c/HQNSz86Rth0rzuRqvB7WCpXkRVBqcx81hC+D+Klx34Z71u8JgClTW0dXt73gVM+dSHoe+B+u74EBPmcl6BvR9chfGTX4+Hant3R7Q+jmg9Eoawsusu+2cAKXmOhG2F/TKtx7pauue9Sm7TrQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mS+OSRHx; arc=none smtp.client-ip=74.125.224.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mS+OSRHx" Received: by mail-yx1-f48.google.com with SMTP id 956f58d0204a3-6481bd173c0so1215256d50.2 for ; Thu, 15 Jan 2026 12:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768507871; x=1769112671; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+DJvmUAxFA7f3CQLgPdeGUDeqhnxQ4o2avS319E39OU=; b=mS+OSRHxEkUk/XSdYfqy+dtvbsbK7jvtDBtH6f1+qJ2thL785QkfccLjzXDE52o1zp YAGH6KtwP8UGmbwI2gCSgz9YJUmKtZEhD1dnpE8HYnMMHH/Lbz+U/bonvO7tqqxPHZ1H PrmFdhsXeFgEnwfrhO19HL/oApQqngef4gWhSlY8c8VPit0D1ld0mKONOAXzbqxPW1t4 G91HQMk3lSMqEub33TpVvMnYfRFulbgrBfrv5fDW5WIyn5DaS1gI9WAdOzWbiAb7rlDa bc9GG/4nt1FJDuTlrBR0rGJThCGYPxEYyxho0ZNEzclvGS8Keo2oTIJRjpHyjD5fA59m 0t8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768507871; x=1769112671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+DJvmUAxFA7f3CQLgPdeGUDeqhnxQ4o2avS319E39OU=; b=RRbU1UyMF/BugfY8/ATwLE0son/9iS/aBSLHTi3ZJ8cgKSYMNXhRZ6aCCSZ0dBNiKh nlyGAAwXyBbeP5ms8Dc4v61XB8p3npslsK2l4syTp4xNsrTLfQDi7GyrP7AWM1WUh3JU eCDT/Mw6tUcV6CLdinXy/93EIB/YWal9HS923EVhZYsmyOL/n9ikD8DsntSKJMYljZL9 5o/iktfKQF8McDLHO9mBf1fGO8dTvqrG0ZekMzIGUUJGOrkVQe+zERmdpDsqe2LgHm2e 1Z9uCctsrXVGK0OsP0ip7aOAxz8O2vOUn72yN82nqGfQwPwHZ2lprFolUbEblEgkENLj UUiw== X-Forwarded-Encrypted: i=1; AJvYcCU7TCE5K/UHgsjAmavbNgCQM8Bxu/yOedgtqP3+6twt20YjXHpFTARY0/VD0Fh9caqh+Ya50inr4Q7Tut4=@vger.kernel.org X-Gm-Message-State: AOJu0YwreRXxyZaVz5/Jb1lw+vVzek/So65+IcacpxZoHuiZ2u3YObIT x2E60MXsqRrdptWp/uFmL2YDGZEdemfmOMUs1MF2NdYrHzqTWMYOfghE X-Gm-Gg: AY/fxX7VUkZ91gGTjOzwrkP8dQgFlnzNNLd2+sIzUCgMMlyjL7R3wWSA87iFACMwCH/ IqpCPC1mnH1ga1AzUvZRHXOJtVZr43EEgMC4QYlmV7rZQy/ilFEQx4oKV5oXRFVRP9dbQgGfFyd jzocmaHJ1l9ov2gqwIW45f4GKUUH46RHdNtUIcbqTkQBr6TOnNhDMfOs3fF6mkpJORcRiru7ZXJ UnQICIX0FpMrBNkOJDhfb1Ii5scsOzkdMh+Y27ONIE5q8sDLEyZ8trGT0SOKGYj3aK3pq2ILD0M 88I5GH0Y/+WxVEPu3be1PSKxB2JtGRiXXNRFsiUE7ysM1xvHJxnVJDpp4q6DwACV7N9mqmDxb5h uFFB+aWqtB1pQL/9/wSfzlCZIEevioH1QUyR4C+XwgYHsyzgY5q30Bnn/Wc22q1Nim2xYI3BuNY 6r9sDttHrC9w== X-Received: by 2002:a05:690e:d46:b0:63f:ad6d:cbd5 with SMTP id 956f58d0204a3-64917750a39mr255389d50.60.1768507871038; Thu, 15 Jan 2026 12:11:11 -0800 (PST) Received: from localhost ([2a03:2880:25ff:47::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-793c66f6f97sm1285097b3.16.2026.01.15.12.11.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 12:11:10 -0800 (PST) From: Joshua Hahn To: Joshua Hahn Cc: Manish Kumar , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: prefer 'unsigned int' over bare 'unsigned' in page_alloc.c Date: Thu, 15 Jan 2026 15:11:07 -0500 Message-ID: <20260115201108.1028113-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260115200753.1002036-1-joshua.hahnjy@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, 15 Jan 2026 15:07:52 -0500 Joshua Hahn wrote: > On Fri, 16 Jan 2026 01:18:45 +0530 Manish Kumar wrote: > > > Change the declaration of 'seq' from 'unsigned' to 'unsigned int' > > to follow kernel coding style. No functional change. > > > > Signed-off-by: Manish Kumar > > Hello Manish, I hope you're doing well! > > The patch looks good to me. However, I just have a few comments about the > other patches that you've recently sent out as well. > > I think it could be very helpful for reviewers, if you grouped related commits > together (in this case, mm/page_alloc.c cleanups) into a single patchset. > This lets the reviewers view all related commits together, in each others' > contexts. > > It would also be super helpful to Cc some of the reviewers / maintainers who > are relevant to the change you are making! scripts/get_maintainer.pl will > give you a good idea of who might be people who are expereinced in the area > and are willing to review the patch. > > Thank you for the patchset, have a great day! > > Reviewed-by: Joshua Hahn Whoops, one more thing. The deletion of an empty tab is included in this patch, but it's not mentioned at all in the changelog. Before adding my reviewed-by, please elaborate on it in the changelog, or submit it in a separate patch.