From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECE3086250 for ; Thu, 15 Jan 2026 21:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768511483; cv=none; b=R3yofyEukFbbS5xiBtsiAQDFcqTTykBsJLSpHvh6e2MX4sQi+4inPU+npDbBSc2Yqx7jC1oCkwMKpJEH0hL6yJFS/T8WgP5LdPqfgNUmmPJkx6BAmEbxvXL73HwPsYah7DbkcDuknhPqybZQp3NIOc5vkzG4Hu3RsDT5lBxfiX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768511483; c=relaxed/simple; bh=PNFl6HfGx25rqKKLo0l5Uw3/d3nTe/CXXMPZwih3HQY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=otudQoc3wjURbgm3QwIHznWYwmwt6tNx6GyusD1JeB3iH7O98Pqt6x7BE2YBSmjrTsAt3AEaIvPVL7EWbbcx7tQ69hFl61/o3MiEAmwgaq92uOKZ6yC/Umv/oJ7qlhHDqnFMG0L1evsDf4d21a6q2GEGF2a9IRxORpCy9jktvgw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=km4r/K0U; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="km4r/K0U" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-6455a60c12bso1158667d50.3 for ; Thu, 15 Jan 2026 13:11:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768511481; x=1769116281; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rBUMRSearfqlg3Cc70zgYWNZYbsBrCb0aDCW/HMIjHY=; b=km4r/K0UWVooGm4rjv/2y5dzCoIhwvOih0fOTbrqtWfNFLu7HAL1C7hWCNGGk0ykQi IenxK0gKpCbHHQZ72DRjxj8lKUKsw0YTWvrXowiuCqEUTyfYz4e0ieQVy2TQ80tKJXVZ 3ruJrYXSeTOxKI+Hydmh9WkWsOjQQKvJBrl5yDs5259zSn985AjP3bZrG1LQRZ9dQxrp I2Fe2xP2RXC9X7uQnS9Acx7UZg9Z6XRXShW/fWR9GQQZfkZ78KTTUeTjgfD2DaZnoYtZ zxKozVM+7Oasez8QQbuA0y7QyIyPM2OKZ5y26z6+8mwnaY3YZs7Qv4uKVuRHu1nml6++ xRfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768511481; x=1769116281; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rBUMRSearfqlg3Cc70zgYWNZYbsBrCb0aDCW/HMIjHY=; b=MxQ+SWRUZD4+pHX5sdWthxPxcxBw1SBaIN1w8tnaHQ5sG05l/x3EZIznsWOlu5uK/O HEbwU7KNamlr6LTtxktVWjrWdXIvS0+7nljPvwwNOehZTZVkbVWbMK+pmbpGscnI6Wyb BfaoHf4fy6K5DDzQO7HeOV8OWXUubI/HP0aVfP+LDkeYn4gcLgNcs5P1UEov9vJcREUV 2MhnucddpQlzn2BHi3GuyBHiCGZrMRRDu2oyWgO3mGsxd/INpsXTHMw6B42Gb6CehntW i4GZUSDDBHHMPsKrTJoKovhC2uTa3PnGZUR4g6Y80hxi2cY8p3g4uhvrEylUHPzMNnlC HUOw== X-Forwarded-Encrypted: i=1; AJvYcCWNZP9rPF8cxrDM2AFVJZrq9T8SUdBvgOuKk4HDJLzNyr/Xms+VOdq960aRwjdaQcKkYDtkkbahvAmEN/s=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+GnWijyTbW/Gv0CUu5H31jWEWFeiqk3+T6/EAIJI0SvEGsk5M 3saqTJGkBHllezSfYLSYr7grgG/BUt95enjbISDjSE8quDmzcyWNysQlNIrRQQ== X-Gm-Gg: AY/fxX7mAWXG93/UK4tjBqigMgMyLGNxzFANRfGxWCbw6j854p3jVyWuAkSIV2aPa++ XZ6vNgN1QyS4LwcIIVYJ0Vqc84t5hNPUzgWBh5NrwyBpE9fuQC349s4cI56Vm/kiv60JWqCA+Pi NsBqcsAnSbZUX6UyOcRaM1/XX1CZOA3V/jTd5p3Ac3uuO1tGc9YqpeOFotXHwvrjGy4lOmqwPNs kVz96ipO87hg5Nb9N5v48EfwnoEReRd/WOqJs5pKSWZ691kOusfWo9gynlgso1luZ8nqrvm+f81 wTq6sQO2d6rfPFF2Z3ctMiXeZuCWG06ndltR5y0lSyCGSTmy9Am7L8FxORKemwqdNKU+9GceeJw Cm+vZHwU/hDeTklhfDsldnQ0GeZzCpCZX9/EgbAl+fO7LR6RmA6Ji633FPpQMQToPmKZUZVHwSq UAXi1e/KwrPw== X-Received: by 2002:a05:690e:14c1:b0:644:6af1:1922 with SMTP id 956f58d0204a3-64917750ad0mr392799d50.53.1768511480901; Thu, 15 Jan 2026 13:11:20 -0800 (PST) Received: from localhost ([2a03:2880:25ff:50::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-793c68bec97sm1712297b3.50.2026.01.15.13.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 13:11:20 -0800 (PST) From: Joshua Hahn To: "David Hildenbrand (Red Hat)" Cc: Andrew Morton , Muchun Song , Oscar Salvador , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/3] mm/hugetlb: Remove unnecessary if condition Date: Thu, 15 Jan 2026 16:10:51 -0500 Message-ID: <20260115211053.1406264-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, 15 Jan 2026 21:14:15 +0100 "David Hildenbrand (Red Hat)" wrote: > On 1/15/26 19:14, Joshua Hahn wrote: > > if (map_chg) is always true, since it is nested in another if statement > > which checks for it already. Remove the check and un-indent for readability. > > > > if (unlikely(map_chg == MAP_CHG_NEEDED && retval == 0)) { > > ... > > > > if (map_chg) { > > ... > > } > > } > > > > No functional change intended. > > > > Signed-off-by: Joshua Hahn > > --- > > mm/hugetlb.c | 12 +++++------- > > 1 file changed, 5 insertions(+), 7 deletions(-) > > > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index 88b9e997c9da..432a5054ca1d 100644 > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -3019,13 +3019,11 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma, > > > > rsv_adjust = hugepage_subpool_put_pages(spool, 1); > > hugetlb_acct_memory(h, -rsv_adjust); > > - if (map_chg) { > > - spin_lock_irq(&hugetlb_lock); > > - hugetlb_cgroup_uncharge_folio_rsvd( > > - hstate_index(h), pages_per_huge_page(h), > > - folio); > > - spin_unlock_irq(&hugetlb_lock); > > - } > > + spin_lock_irq(&hugetlb_lock); > > + hugetlb_cgroup_uncharge_folio_rsvd( > > + hstate_index(h), pages_per_huge_page(h), > > + folio); > > + spin_unlock_irq(&hugetlb_lock); > > } > > } > > > > MAP_CHG_NEEDED = 1 > > Acked-by: David Hildenbrand (Red Hat) Thank you David, I agree it's helpful to include MAP_CHG_NEEDED != 0. Will add in the v2! Have a great day : -) Joshua