From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f50.google.com (mail-yx1-f50.google.com [74.125.224.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 132C829D289 for ; Thu, 15 Jan 2026 21:14:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768511691; cv=none; b=HEAs3vxTXFhpFYWFwL2lDxqNlWvFXpsByBIQtQgnCf2NC1puMUz+u8kuFGCd9F8Xw+Bdi5cvK6hIYfDsBt5REjQ/J46mL7MvLcBOjkblDJuvOzRyU4ab0pYhQGJCVPtV0CM1f0P3kcurewAHGa0StHyhjO1o3Q/C2gPQrgBy/tg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768511691; c=relaxed/simple; bh=VDIGMO8leVvqGyTsoEVKLIL/mEPg0AkUe6KhewV5C0w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lwy2H4lUhfS5whpG6CXxbNS3hvha6/o71GwzRxdYnSpzVbCpSW5LpNBKoOv010MrObBlspiXBHlaxsqvQc0TtN/o1ao5TRlicS1v8ji4D2bixTLvLZU0rFruqIApjUjM9LRk3Myhj8URALfcygtr084XG4j3TYhz/t4H6GnH448= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jisCl0HC; arc=none smtp.client-ip=74.125.224.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jisCl0HC" Received: by mail-yx1-f50.google.com with SMTP id 956f58d0204a3-6467c5acb7dso1141881d50.1 for ; Thu, 15 Jan 2026 13:14:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768511689; x=1769116489; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7kLMiNGGY+MRW46p7GK2A4XqqTYN5OUlY7xfrS7gvdk=; b=jisCl0HCXkigC7SIhnqaa0souNWOELHCNiD8lLWW4eDiwgpEBCe0rN7GoX5uYJQtxJ mauMDp36aW+a/v6ebZe/C3HAxBIGbdgyGmN5nPF7/i2nZTMcSFFb/GHmBe2caJAG4EWy m6466CDePkKDFNjrAHOi+2eeyGv6aBDspAMVIaEacaKWt0fHeNo5+Fe+La8TUbdPKxUc eITKmNwd+6AlqI/du2QyNQhteMBndK29827/Fu50gt3W4g+6jNKsSkj/h8AwTX4go0ea 5rCicz4h5IxnWqKNbUgItg8FVQxyJQ79W3vRNz7eNXjBEyzLvLm5GsqFFHSKRbdPU4SY GSrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768511689; x=1769116489; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7kLMiNGGY+MRW46p7GK2A4XqqTYN5OUlY7xfrS7gvdk=; b=AZxqquVbBKw6sxO7Z+4HQazso1GFETbNwgaKFZ6i6z/433nkzMTAOK/4hwIYfKjAgp OADy8Lo3B7B5hg32YHFUzF17zBeoLnz5nADoZpSuPZNVQGl0XCpokMIngrWiHgjrNxvW UrBBj6hiSU22Z1mqJ3qeYimx9ASA12WLPjzJm/s338r5bSjiJxVQphTk02So8J5zHoGO kQTzK33b94Dr/iwwfoG3qg4/v/HqitaOW0qDj5+/Dm+jpORVKzdi3LAiOeE18O6h0VQE QYaAlsGIdSQrvQ7TkDYzumrSf7cXth0kNb1L0hpeUuBxe9Q4FVxbqjoikroXszvP0FDa /KEg== X-Forwarded-Encrypted: i=1; AJvYcCUCO4+b6ZjigHd+6LU6ajoVqgeEmAHx1GLM5RqJLkwH0DWtHrgrnAmtNdHGCgAEhKtlFzUNqvil3RuaPU4=@vger.kernel.org X-Gm-Message-State: AOJu0YyiQF2sSj2FlrqCw4XvgBpdgGjQeEDOKnK+bdbMYXL396GI5bLg wQ2rEaZIlHqV0Cj0buKjYl6z5bsW8APM/eVAeMU9dcoHT6/J4219aNUA X-Gm-Gg: AY/fxX7A2pDzTM+do5NY8Q+j2EkraIeLA2fjBcCbHw2NVBuMzQ3vs8p3J+bfwQaq4fi xIL0R92pdLWUVTDmBNgh/JZ62lDaZcCBEVZg/RyW4hRf3eb5TC+f0zzlqXQOJzyQZzCkM74/1hK 4qWQAfA4X2+/6VOus5QgGLFBMKrGRyNpHLvIXF4z8qRhkg4LyjEm/XEzZlbu3XDv5qvzA17xGMU BQDcfTbmUoax0eY1lpeqHangLS6sUUu2L/wRm4KB+XolEclhC+W3YO1Z+c9WM1b6Dg/oIFxBlvN UTwwNCE6TZ2uKGP18+dSe9WbPu4vcInGW3kY+Z93xtNw/e2PJ7Uj++76ndahjxCa5IFy7MAddCd y/5xUJg/tRT1CA4gKdfJk1MwmrKKOMFn+jEpSUWrbsMoNMFoUzk/GtJC8b7okQRjtIgdFtxHGwt 6nxHs2sBHo X-Received: by 2002:a53:ac88:0:b0:646:5127:ad81 with SMTP id 956f58d0204a3-6491774abecmr401978d50.95.1768511689099; Thu, 15 Jan 2026 13:14:49 -0800 (PST) Received: from localhost ([2a03:2880:25ff:5::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-793c68c4167sm1738657b3.52.2026.01.15.13.14.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 13:14:48 -0800 (PST) From: Joshua Hahn To: "David Hildenbrand (Red Hat)" Cc: Andrew Morton , Muchun Song , Oscar Salvador , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/3] mm/hugetlb: Enforce brace style Date: Thu, 15 Jan 2026 16:14:46 -0500 Message-ID: <20260115211446.1429024-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, 15 Jan 2026 21:10:41 +0100 "David Hildenbrand (Red Hat)" wrote: > On 1/15/26 19:14, Joshua Hahn wrote: > > Documentation/process/coding-style.rst explicitly notes that if only one > > branch of a conditional statement is a single statement, braces should > > be used in both branches. Enforce this in mm/hugetlb.c. > > > > No functional change intended. > > > > Signed-off-by: Joshua Hahn > > --- > > [...] > > > update_and_free_hugetlb_folio(h, folio, false); > > return rc; > > @@ -2672,11 +2675,13 @@ void restore_reserve_on_error(struct hstate *h, struct vm_area_struct *vma, > > * be consumed on a subsequent allocation. > > */ > > folio_set_hugetlb_restore_reserve(folio); > > - } else > > + } else { > > /* > > * No reservation present, do nothing > > */ > > vma_end_reservation(h, vma, address); > > + > > But why the empty line? :) Hello David, Whoops, I totally forgot to run checkpatch on this one. I think Andrew also noticed this, he sent a fixlet for it. Sorry for this! I'll fix it up in v2. Thanks again, have a great day David! Joshua