From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B656531A7F7 for ; Thu, 15 Jan 2026 23:38:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768520296; cv=none; b=dwhIwsBr4cCnq96HoYBRyhxgh/7bPV6DvbgJXmTlvvWibeU/IecqN0u5xT9Xmb410gSYr7ydDIv4SEY8gQJQ+cAlpl/IpkehqRuaqhKxAEmyGS2OtpWY/Ck8mCUpCHMBbXYIeJ70vD9Bz82ivZM3V0R5eNUuBWBDGxnS5X6OVuM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768520296; c=relaxed/simple; bh=5R+H7RlBh/BOyc2NDitFJ3MUVbIZZQrMQM5gHfKy/ic=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Obwh9dtuOXYQJqIKIMihuB79OfVwhp8TiEIqwX43pbTXzbQFXC5ycC1CZrgE4GHQPoyznWBggyvtc2vN/fkwr6ONLBa/8Ooy0+2y5lMiGgeyvg58c/HRlzb/pu43EbwPQTwrXNlAzUo7hBQV5/vq8oLgSPgfIt7SFHCPKwpoOQU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PTaOEwvt; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PTaOEwvt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768520292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=35CEsfjRQdQ+OwU9+Cca4TWBbP+9Hnd4LKT+qjgrJ+M=; b=PTaOEwvtd7BvlAZoa83iGEY12nABRWd6w9W5OYA8OuM8YM5WEEYaW2PXjz/Mh9cCKa1bu4 /oGy0aMCF7DxQmyhntsAqBs0Rg9qTypx2ECLIxSqtFlXh1QwNYDbp2mFuxBLi5wCxtT1If w9VjgRYfz/0S8GEib+rPmDrN1A1voC8= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-PqT-3SynOZSXf7O1u9B-Iw-1; Thu, 15 Jan 2026 18:38:09 -0500 X-MC-Unique: PqT-3SynOZSXf7O1u9B-Iw-1 X-Mimecast-MFC-AGG-ID: PqT-3SynOZSXf7O1u9B-Iw_1768520288 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3FFDE19560A1; Thu, 15 Jan 2026 23:38:08 +0000 (UTC) Received: from pauld.westford.csb (unknown [10.22.80.54]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2C5BD30002D6; Thu, 15 Jan 2026 23:38:05 +0000 (UTC) Date: Thu, 15 Jan 2026 18:38:03 -0500 From: Phil Auld To: linux-kernel@vger.kernel.org Cc: linux-tip-commits@vger.kernel.org, Gabriele Monaco , "Peter Zijlstra (Intel)" , x86@kernel.org Subject: Re: [tip: sched/core] sched: Fix build for modules using set_tsk_need_resched() Message-ID: <20260115233803.GD1039042@pauld.westford.csb> References: <20260112140413.362202-1-gmonaco@redhat.com> <176851345987.510.6507406232761244840.tip-bot2@tip-bot2> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <176851345987.510.6507406232761244840.tip-bot2@tip-bot2> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On Thu, Jan 15, 2026 at 09:44:19PM -0000 tip-bot2 for Gabriele Monaco wrote: > The following commit has been merged into the sched/core branch of tip: > > Commit-ID: 8d737320166bd145af70a3133a9964b00ca81cba > Gitweb: https://git.kernel.org/tip/8d737320166bd145af70a3133a9964b00ca81cba > Author: Gabriele Monaco > AuthorDate: Mon, 12 Jan 2026 15:04:13 +01:00 > Committer: Peter Zijlstra > CommitterDate: Thu, 15 Jan 2026 22:41:26 +01:00 > Thank you for both of these, Peter! Cheers, Phil > sched: Fix build for modules using set_tsk_need_resched() > > Commit adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task model") > added a tracepoint to the need_resched action that can be triggered also > by set_tsk_need_resched. > This function was previously accessible from out-of-tree modules but > it's no longer available because the __trace_set_need_resched() symbol > is not exported (together with the tracepoint itself, which was exported > in a separate patch) and building such modules fails. > > Export __trace_set_need_resched to modules to fix those build issues. > > Fixes: adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task model") > Signed-off-by: Gabriele Monaco > Signed-off-by: Peter Zijlstra (Intel) > Reviewed-by: Phil Auld > Link: https://patch.msgid.link/20260112140413.362202-1-gmonaco@redhat.com > --- > kernel/sched/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index b033f97..3cca012 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -1139,6 +1139,7 @@ void __trace_set_need_resched(struct task_struct *curr, int tif) > { > trace_sched_set_need_resched_tp(curr, smp_processor_id(), tif); > } > +EXPORT_SYMBOL_GPL(__trace_set_need_resched); > > void resched_curr(struct rq *rq) > { > --