From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Cc: Loic Poulain <loic.poulain@oss.qualcomm.com>,
Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Robert Foss <rfoss@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/5] dt-bindings: i2c: qcom-cci: Document sm6150 compatible
Date: Fri, 16 Jan 2026 09:28:16 +0100 [thread overview]
Message-ID: <20260116-malachite-spaniel-of-refinement-af22ae@quoll> (raw)
In-Reply-To: <20260115-sm6150_evk-v3-2-81526dd15543@oss.qualcomm.com>
On Thu, Jan 15, 2026 at 06:12:38PM +0800, Wenmeng Liu wrote:
> Add the sm6150 CCI device string compatible.
>
> SM6150 include three clock:
> bus: Bus clock responsible for data transfer.
> iface: Interface clock responsible for register read and write.
> cci: Clock for CCI core operations.
>
> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
> .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> index a3fe1eea6aece9685674feaa5ec53765c1ce23d8..3472670fdc908ef8f3b3afc68ff437c0435b69a7 100644
> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> @@ -33,6 +33,7 @@ properties:
> - qcom,sc8280xp-cci
> - qcom,sdm670-cci
> - qcom,sdm845-cci
> + - qcom,sm6150-cci
> - qcom,sm6350-cci
> - qcom,sm8250-cci
> - qcom,sm8450-cci
> @@ -263,6 +264,23 @@ allOf:
> - const: cpas_ahb
> - const: cci
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sm6150-cci
> + then:
> + properties:
> + clocks:
> + minItems: 3
> + maxItems: 3
> + clock-names:
> + items:
> + - const: bus
> + - const: iface
> + - const: cci
So basically the same as camnoc_axi+cpas_ahb+cci, so just put it into
existing enum with qcom,sm8550-cci.
I asked for this at v1.
https://lore.kernel.org/all/43efa6fd-53c3-4680-8aca-7b37089ca295@kernel.org/
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-16 8:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 10:12 [PATCH v3 0/5] Add CCI and imx577 sensor support for Talos evk Wenmeng Liu
2026-01-15 10:12 ` [PATCH v3 1/5] arm64: dts: qcom: talos: Add camss node Wenmeng Liu
2026-01-15 10:12 ` [PATCH v3 2/5] dt-bindings: i2c: qcom-cci: Document sm6150 compatible Wenmeng Liu
2026-01-16 8:28 ` Krzysztof Kozlowski [this message]
2026-01-16 8:34 ` Wenmeng Liu
2026-01-16 8:54 ` Krzysztof Kozlowski
2026-01-16 10:59 ` Loic Poulain
2026-01-15 10:12 ` [PATCH v3 3/5] arm64: dts: qcom: talos: Add CCI definitions Wenmeng Liu
2026-01-15 10:12 ` [PATCH v3 4/5] arm64: dts: qcom: talos: Add camera MCLK pinctrl Wenmeng Liu
2026-01-15 10:12 ` [PATCH v3 5/5] arm64: dts: qcom: talos-evk-camera: Add DT overlay Wenmeng Liu
2026-01-16 9:12 ` Vladimir Zapolskiy
2026-01-16 9:32 ` Wenmeng Liu
2026-01-16 9:42 ` Vladimir Zapolskiy
2026-01-16 10:06 ` Wenmeng Liu
2026-01-21 9:54 ` [PATCH v3 0/5] Add CCI and imx577 sensor support for Talos evk Andi Shyti
2026-01-21 10:08 ` Wenmeng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116-malachite-spaniel-of-refinement-af22ae@quoll \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
--cc=wenmeng.liu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®