From: "Barnabás Czémán" <barnabas.czeman@mainlining.org>
To: Lee Jones <lee@kernel.org>, Daniel Thompson <danielt@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
Pavel Machek <pavel@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Kiran Gunda <quic_kgunda@quicinc.com>,
Helge Deller <deller@gmx.de>, Luca Weiss <luca@lucaweiss.eu>,
Konrad Dybcio <konradybcio@kernel.org>,
Eugene Lepshy <fekz115@gmail.com>,
Gianluca Boiano <morf3089@gmail.com>,
Alejandro Tafalla <atafalla@dnyon.com>
Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Daniel Thompson" <daniel.thompson@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org,
"Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
"Barnabás Czémán" <barnabas.czeman@mainlining.org>
Subject: [PATCH v3 2/7] backlight: qcom-wled: Support ovp values for PMI8994
Date: Fri, 16 Jan 2026 08:07:34 +0100 [thread overview]
Message-ID: <20260116-pmi8950-wled-v3-2-e6c93de84079@mainlining.org> (raw)
In-Reply-To: <20260116-pmi8950-wled-v3-0-e6c93de84079@mainlining.org>
WLED4 found in PMI8994 supports different ovp values.
Fixes: 6fc632d3e3e0 ("video: backlight: qcom-wled: Add PMI8994 compatible")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
drivers/video/backlight/qcom-wled.c | 41 +++++++++++++++++++++++++++++++++++--
1 file changed, 39 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c
index a63bb42c8f8b..5decbd39b789 100644
--- a/drivers/video/backlight/qcom-wled.c
+++ b/drivers/video/backlight/qcom-wled.c
@@ -1244,6 +1244,15 @@ static const struct wled_var_cfg wled4_ovp_cfg = {
.size = ARRAY_SIZE(wled4_ovp_values),
};
+static const u32 pmi8994_wled_ovp_values[] = {
+ 31000, 29500, 19400, 17800,
+};
+
+static const struct wled_var_cfg pmi8994_wled_ovp_cfg = {
+ .values = pmi8994_wled_ovp_values,
+ .size = ARRAY_SIZE(pmi8994_wled_ovp_values),
+};
+
static inline u32 wled5_ovp_values_fn(u32 idx)
{
/*
@@ -1357,6 +1366,29 @@ static int wled_configure(struct wled *wled)
},
};
+ const struct wled_u32_opts pmi8994_wled_opts[] = {
+ {
+ .name = "qcom,current-boost-limit",
+ .val_ptr = &cfg->boost_i_limit,
+ .cfg = &wled4_boost_i_limit_cfg,
+ },
+ {
+ .name = "qcom,current-limit-microamp",
+ .val_ptr = &cfg->string_i_limit,
+ .cfg = &wled4_string_i_limit_cfg,
+ },
+ {
+ .name = "qcom,ovp-millivolt",
+ .val_ptr = &cfg->ovp,
+ .cfg = &pmi8994_wled_ovp_cfg,
+ },
+ {
+ .name = "qcom,switching-freq",
+ .val_ptr = &cfg->switch_freq,
+ .cfg = &wled3_switch_freq_cfg,
+ },
+ };
+
const struct wled_u32_opts wled5_opts[] = {
{
.name = "qcom,current-boost-limit",
@@ -1423,8 +1455,13 @@ static int wled_configure(struct wled *wled)
break;
case 4:
- u32_opts = wled4_opts;
- size = ARRAY_SIZE(wled4_opts);
+ if (of_device_is_compatible(dev->of_node, "qcom,pmi8994-wled")) {
+ u32_opts = pmi8994_wled_opts;
+ size = ARRAY_SIZE(pmi8994_wled_opts);
+ } else {
+ u32_opts = wled4_opts;
+ size = ARRAY_SIZE(wled4_opts);
+ }
*cfg = wled4_config_defaults;
wled->wled_set_brightness = wled4_set_brightness;
wled->wled_sync_toggle = wled3_sync_toggle;
--
2.52.0
next prev parent reply other threads:[~2026-01-16 7:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 7:07 [PATCH v3 0/7] Fix PMI8994 WLED ovp values and more Barnabás Czémán
2026-01-16 7:07 ` [PATCH v3 1/7] dt-bindings: backlight: qcom-wled: Document ovp values for PMI8994 Barnabás Czémán
2026-01-19 14:50 ` Daniel Thompson
2026-01-16 7:07 ` Barnabás Czémán [this message]
2026-01-19 14:51 ` [PATCH v3 2/7] backlight: qcom-wled: Support " Daniel Thompson
2026-01-16 7:07 ` [PATCH v3 3/7] dt-bindings: backlight: qcom-wled: Document ovp values for PMI8950 Barnabás Czémán
2026-01-19 14:51 ` Daniel Thompson
2026-01-16 7:07 ` [PATCH v3 4/7] backlight: qcom-wled: Change PM8950 WLED configurations Barnabás Czémán
2026-01-19 14:53 ` Daniel Thompson
2026-01-16 7:07 ` [PATCH v3 5/7] arm64: dts: qcom: msm8953-xiaomi-vince: correct wled ovp value Barnabás Czémán
2026-01-16 7:07 ` [PATCH v3 6/7] arm64: dts: qcom: msm8937-xiaomi-land: " Barnabás Czémán
2026-01-16 10:07 ` Konrad Dybcio
2026-01-16 7:07 ` [PATCH v3 7/7] arm64: dts: qcom: msm8953-xiaomi-daisy: fix backlight Barnabás Czémán
2026-01-16 10:07 ` Konrad Dybcio
2026-02-04 10:26 ` (subset) [PATCH v3 0/7] Fix PMI8994 WLED ovp values and more Lee Jones
2026-03-18 13:50 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116-pmi8950-wled-v3-2-e6c93de84079@mainlining.org \
--to=barnabas.czeman@mainlining.org \
--cc=andersson@kernel.org \
--cc=atafalla@dnyon.com \
--cc=conor+dt@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=danielt@kernel.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fekz115@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=luca@lucaweiss.eu \
--cc=morf3089@gmail.com \
--cc=pavel@kernel.org \
--cc=quic_kgunda@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®