From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9175F1DF256 for ; Fri, 16 Jan 2026 01:54:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768528463; cv=none; b=OVwHRbfj6oP3/cPy1L1Z8FD1taaMPO6TbM2tOaogk06nf+xnNSrtJOi+TfvrnGV30ZAp4hUwfsmf3Lxl70wkfry9GZLc+MLdNFKz5QSc7HAAEeLVfFk/EwuexcEv0pDqTnBv/pma1MuONlAJUfR5n0U3YaFvbZrtgF5Xc/tIEQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768528463; c=relaxed/simple; bh=E3VHf3jps9JywfKsABhLUkLhWni3+c+9qdgoykGsHz0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bqrzOrJnsPnDLSKhK3h17am+B/qwQLTgj6nnzyMZBs84R8Dtz697BQ5T7UGsVdB6vls+QlTzL15vuRYJqHOryP6OXefgpcw9noKZQVeh/X2Im3vVNwKf2hgrtUdlGq09SIvymUGX/ru3J5NQgw9hH4z6ZOVDsTF8FeswujBAHrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kkaArhLT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kkaArhLT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDE36C116D0; Fri, 16 Jan 2026 01:54:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768528463; bh=E3VHf3jps9JywfKsABhLUkLhWni3+c+9qdgoykGsHz0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kkaArhLTj4B2/MOE8w/J3+qf/M+KLOQRfQskHWPwtN+LgB/6eGNx986/0paN180VE 9hGa+Jjmqn+3v061l6QAXsL5wqZWfQy9NJ1/XXwHNrXROaCOwBa2xM0Xmb9YPoV6Yt VSYAjMG/r3wNWMMn8eRx1r3X965QPNyqRTzE0TNp5XOotlXzDO7JN2MPi+T+YkU5qS SR2KsFhq1+1Ysoa/6RqoIzA85M6GmRYdqmgmK6bMBTZAloLL77YHzE4PtAdigYyZeN uun/yYwdZM3DF/AMCz0mPvrteQRON4EJT9eIDwowkLKPo78qBhvYVpsurUVSL9+IU4 ovw/uHagOtbGw== From: SeongJae Park To: "David Hildenbrand (Red Hat)" Cc: SeongJae Park , Joshua Hahn , Andrew Morton , Muchun Song , Oscar Salvador , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/3] mm/hugetlb: Enforce brace style Date: Thu, 15 Jan 2026 17:54:14 -0800 Message-ID: <20260116015415.71492-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <63201bd0-4375-48d3-8955-5925221ae241@kernel.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, 15 Jan 2026 22:16:12 +0100 "David Hildenbrand (Red Hat)" wrote: > On 1/15/26 22:14, Joshua Hahn wrote: > > On Thu, 15 Jan 2026 21:10:41 +0100 "David Hildenbrand (Red Hat)" wrote: > > > >> On 1/15/26 19:14, Joshua Hahn wrote: > >>> Documentation/process/coding-style.rst explicitly notes that if only one > >>> branch of a conditional statement is a single statement, braces should > >>> be used in both branches. Enforce this in mm/hugetlb.c. > >>> > >>> No functional change intended. > >>> > >>> Signed-off-by: Joshua Hahn > >>> --- > >> > >> [...] > >> > >>> update_and_free_hugetlb_folio(h, folio, false); > >>> return rc; > >>> @@ -2672,11 +2675,13 @@ void restore_reserve_on_error(struct hstate *h, struct vm_area_struct *vma, > >>> * be consumed on a subsequent allocation. > >>> */ > >>> folio_set_hugetlb_restore_reserve(folio); > >>> - } else > >>> + } else { > >>> /* > >>> * No reservation present, do nothing > >>> */ > >>> vma_end_reservation(h, vma, address); ^ The space here seems unnecessary? > >>> + > >> > >> But why the empty line? :) > > > > Hello David, > > > > Whoops, I totally forgot to run checkpatch on this one. I think Andrew > > also noticed this, he sent a fixlet for it. Sorry for this! I'll fix it up > > in v2. > > Acked-by: David Hildenbrand (Red Hat) > > with that ;) Regardless of my finding, but assuming you will fix David's finding ;) please feel free to add below to the v2. Reviewed-by: SeongJae PArk Thanks, SJ [...]