From: Mouse Zhang <mousezhang7@gmail.com>
To: mousezhang7@gmail.com
Cc: bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com,
peterz@infradead.org, tglx@kernel.org, x86@kernel.org
Subject: [v2] x86/numa: Initialize __apicid_to_node in dummy_numa_init() to prevent OOB
Date: Fri, 16 Jan 2026 16:56:13 +0800 [thread overview]
Message-ID: <20260116085613.6347-1-mousezhang7@gmail.com> (raw)
In-Reply-To: <20260116032321.9841-1-mousezhang7@gmail.com>
When NUMA is disabled (numa=off) or the BIOS does not provide an SRAT
table, the kernel falls back to dummy_numa_init(). This function fakes
a single node (Node 0) and maps all memory to it, but it leaves the
__apicid_to_node[] mapping table uninitialized (filled with NUMA_NO_NODE).
This leads to a potential out-of-bounds access in srat_detect_node()
and other topology-related code. Specifically, when numa_cpu_node()
returns NUMA_NO_NODE, some code paths attempt to use cpu_llc_id as a
fallback for the node ID. On modern systems with large APIC IDs, the
cpu_llc_id (derived from APIC ID) can exceed MAX_NUMNODES. Using this
invalid ID in functions like node_online(node) causes memory corruption
or kernel panic.
Fix this by explicitly mapping all unassigned APIC IDs to Node 0 in
dummy_numa_init(). This ensures that numa_cpu_node() consistently
returns Node 0 in non-NUMA environments, avoiding dangerous fallbacks
and keeping the mapping consistent with the fake Node 0.
Signed-off-by: Mouse Zhang <mousezhang7@gmail.com>
---
Fix bad format.
arch/x86/mm/numa.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
index 7a97327140df..f78b3ff7a67e 100644
--- a/arch/x86/mm/numa.c
+++ b/arch/x86/mm/numa.c
@@ -212,6 +212,14 @@ static int __init dummy_numa_init(void)
node_set(0, numa_nodes_parsed);
numa_add_memblk(0, 0, PFN_PHYS(max_pfn));
+ /* Map all unassociated APIC IDs to the fake node 0 */
+ unsigned int apicid;
+
+ for (apicid = 0; apicid < MAX_LOCAL_APIC; apicid++) {
+ if (__apicid_to_node[apicid] == NUMA_NO_NODE)
+ __apicid_to_node[apicid] = 0;
+ }
+
return 0;
}
--
2.51.0
next prev parent reply other threads:[~2026-01-16 8:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 3:23 [PATCH] " Mouse Zhang
2026-01-16 8:56 ` Mouse Zhang [this message]
2026-01-23 11:31 ` [v2] " Yi Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116085613.6347-1-mousezhang7@gmail.com \
--to=mousezhang7@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®