From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D81EB1E8826 for ; Fri, 16 Jan 2026 17:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768585699; cv=none; b=rWk2rd47C7AlH2f13TNKACO80JnMkwEz7k3OERRbg2zlRza6QESC2gOFfOF0jkd6h3BETnPZ8qTZ3FGiqMaU/Behcr1fuXqi6WY7iEd2+agoPo7L2SAX7D1D8nKSukhUnkdmbntk1xXKUcz+kowr4vO1wBgOAmPi9nFGnYEuxjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768585699; c=relaxed/simple; bh=9IoF5q3KKyMfVT7MFi03ZTQqilgKQY3sTSgULwfRKsU=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=JVluX5S+jTZfNSjVSBrm2EHbwq6fjRrtEzfeWFocclBfZT0yoNRBEczwht57MVjARKRKkcsodqC9k4zwM77Dvfc+mUa9wuuz5hxAnKtUAXt+QHpaduxETvD4Mqd58h8ADuj5qPPvS4kfmSAAk/owpqhLu3UxjEcciv3tV6QYKGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=WwJRE5bQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="WwJRE5bQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FAF5C116C6; Fri, 16 Jan 2026 17:48:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1768585696; bh=9IoF5q3KKyMfVT7MFi03ZTQqilgKQY3sTSgULwfRKsU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WwJRE5bQbvho7uLMix6DCgxSr5U7QZ9Bb3fVfxTJBdA1iaAaP2WAOoY/j9lv/Ds0v p1/mFyTJBFaeMWvZHn25kiEP09tUW93RYFVWiTqbNb3HAUIBtCCCHVGnDNBUGGwPG0 yokZM9ly68yhzVt3XbC+LtQzw4wdTpUhrDiq2EW8= Date: Fri, 16 Jan 2026 09:48:15 -0800 From: Andrew Morton To: William Tambe Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "jcmvbkbc@gmail.com" Subject: Re: [PATCH] mm/highmem: fix __kmap_to_page() build error Message-Id: <20260116094815.ca8ef0ad407a4b8612845d8e@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 16 Jan 2026 17:18:21 +0000 William Tambe wrote: > >From 706fa431358390713c47667f6bcaecce56d071cc Mon Sep 17 00:00:00 2001 > From: William Tambe > Date: Thu, 11 Dec 2025 12:38:19 -0800 > Subject: [PATCH] mm/highmem: fix __kmap_to_page() build error > > This changes fixes following build error which is probably a miss from: > ef6e06b2ef87 highmem: fix kmap_to_page() for kmap_local_page() addresses > > mm/highmem.c:184:66: error: 'pteval' undeclared (first use in this > function); did you mean 'pte_val'? > 184 | idx = arch_kmap_local_map_idx(i, pte_pfn(pteval)); > > In __kmap_to_page(), pteval is used but does not exist in the function. > > ... > > --- a/mm/highmem.c > +++ b/mm/highmem.c > @@ -180,12 +180,13 @@ struct page *__kmap_to_page(void *vaddr) > for (i = 0; i < kctrl->idx; i++) { > unsigned long base_addr; > int idx; > + pte_t pteval = kctrl->pteval[i]; > > idx = arch_kmap_local_map_idx(i, pte_pfn(pteval)); > base_addr = __fix_to_virt(FIX_KMAP_BEGIN + idx); > > if (base_addr == base) > - return pte_page(kctrl->pteval[i]); > + return pte_page(pteval); > } > } lgtm, thanks. Seems to affect only xtensa? I wonder why it took three years to find this.