From: Greg KH <gregkh@linuxfoundation.org>
To: Xin Zhao <jackzxcui1989@163.com>
Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, tj@kernel.org, hch@infradead.org
Subject: Re: [PATCH v8] tty: tty_port: add workqueue to flip TTY buffer
Date: Fri, 16 Jan 2026 14:24:23 +0100 [thread overview]
Message-ID: <2026011615-luxury-hunchback-1b12@gregkh> (raw)
In-Reply-To: <20251230090341.853655-1-jackzxcui1989@163.com>
On Tue, Dec 30, 2025 at 05:03:41PM +0800, Xin Zhao wrote:
> Hi all,
>
> On Tue, 23 Dec 2025 11:48:36 +0800 Xin Zhao <jackzxcui1989@163.com> wrote:
> > On the embedded platform, certain critical data, such as IMU data, is
> > transmitted through UART. The tty_flip_buffer_push() interface in the TTY
> > layer uses system_dfl_wq to handle the flipping of the TTY buffer.
> > Although the unbound workqueue can create new threads on demand and wake
> > up the kworker thread on an idle CPU, it may be preempted by real-time
> > tasks or other high-prio tasks.
> >
> > flush_to_ldisc() needs to wake up the relevant data handle thread. When
> > executing __wake_up_common_lock(), it calls spin_lock_irqsave(), which
> > does not disable preemption but disables migration in RT-Linux. This
> > prevents the kworker thread from being migrated to other cores by CPU's
> > balancing logic, resulting in long delays. The call trace is as follows:
> >
> > ...
>
>
> Are there any other changes needed before the patch is merged?
>
> Jiri has reviewed the patch, and I have made the modifications. :)
I need Jiri to ack it :)
thanks,
greg k-h
next prev parent reply other threads:[~2026-01-16 13:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 3:48 Xin Zhao
2025-12-30 9:03 ` Xin Zhao
2026-01-16 13:24 ` Greg KH [this message]
2026-01-19 7:08 ` Jiri Slaby
[not found] ` <CGME20260127103433eucas1p1ce8d8c194d4fd16d2f1dbbc0e9df28de@eucas1p1.samsung.com>
2026-01-27 10:34 ` Marek Szyprowski
2026-01-27 11:09 ` Tommaso Merciai
2026-01-27 12:02 ` Geert Uytterhoeven
2026-01-27 12:57 ` Greg KH
2026-01-29 10:31 ` Xin Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026011615-luxury-hunchback-1b12@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jackzxcui1989@163.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®