From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5411399A43 for ; Fri, 16 Jan 2026 16:45:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768581907; cv=none; b=FkJy1fzRrC6pXd5qhgxJNm3mtr6ckqHYCjn8lgtkOn1gtJ0M2ykdqH0fRugh2BBPe01QKSF2h8SzcSDqlI1eoVvbtrIL5yHBuSuEIc5H+TpZRwUKFicPqoqCA7Soz/dbYijpqErlMUl4Jw0TXBPLwoqmDVElduFBbZYRwEXTS1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768581907; c=relaxed/simple; bh=Mt+AIfIE+kNbkQrEkcmfpxoC2CZ+7DKdlncxaZ7wHok=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SI1khclR3rlnfmkH3csPA+BXcqB0oEdjByQFlMik8aIcaV+A96MOgKlimgd0WtnOZXktEOCxjJTppQTys67jrqFtqOTN8N2y/mQsDJqV0Mr5RCmz1ey20MFwFPSkDpynVqS9tfqhMqpfRHLenaeflYwNNXcgD1yyoCKXOAGPlnY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eLX29O3W; arc=none smtp.client-ip=209.85.128.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eLX29O3W" Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-7939e7b648aso23094627b3.1 for ; Fri, 16 Jan 2026 08:45:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768581905; x=1769186705; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=48ahlDlvXHvN2XBj96iMS5cMBmYr8ePFnJit57gKV6M=; b=eLX29O3Wt6ek5Xy/KYf+9r+Op0APGtx1Nw5NLvCN582ZqL82pqeR2dRzpEuv+woIIJ kcWxsV65JId+DRvmLA/IHxF64vSuIIpYViU6pQQy/MbM653pto8Hqo+KtagFUe7wUZzO dk7I+MSn4NOqWEJXFAaA5roNlgNB2wf/Yvy/EUsP/Lg7blCW1Aux9HgGuPg9tBwmR14i EbPTQFW0gvxoNeitneWikzA1H4kYRZuLYs6Bs3soX1fsG5pQHLxwx/YqRv5F9m51gJ3X Lt568H2zgV0CwiCjfFVP/KFSg06p9GoxqJKSx4KDq7ahVg4KQTBogLPBbo5L7tqWNEIa WOnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768581905; x=1769186705; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=48ahlDlvXHvN2XBj96iMS5cMBmYr8ePFnJit57gKV6M=; b=wpiwHFgzxlnqbgdT3R3QGajqSdpTUlcXCmV103PEkkyJ3KKUOrdMpSiUkKyPgZKDR4 7Zk1q01vF/8BwVtD7FIi9Dmv90g7PcSBHJ83RUzZxXKwqrhAIuL/vtoBHlYQ6u8JM8sw 1eLvIJQeUCMJ4lAiHWMMuRd53Vxvx4OygN417prY5yF1BlNYwElK1FjVklBMiEHYq7en XQoJZn/5kFRLzBr+Qr3Uj5+3XujGR/2c5M97vTJDo4xAOWnpBvQxsAmiDB4nxYTIG/ZY J4W8S3JfUoAnz3qKI1168Q62pkYXtlxigHd2mA8ZfZLXCXw3Z+ncGB7L9wgOGth3R2Lh Pntw== X-Forwarded-Encrypted: i=1; AJvYcCVRVCo/V0M5s/0HohdzZgFJ53s57IOYJIVjQAe2O0MuwLGVuaBDXMMtsXxB9PdsqIKSyyW2gJY28QTdquI=@vger.kernel.org X-Gm-Message-State: AOJu0YwOcfnmjQDbSKmh+89WTMOWeLzB316efbSGeLVdNko+dXLnZrY8 4uvAO+wGh0FbMdVtugqJFHRBSemFxRsRPU6xRwRnGAItfsnrzKr3Zm73 X-Gm-Gg: AY/fxX6zHUbKtjd/WahlZptDK15VvjjUFaDfXg9YWTjQdMyREN+eAYM9DRT2ZrmE4YO u/plfJQ3RSumFZQCIWegOhPfuJT7mhqVl3ByZrrcL9uyACen9alQmlZQJL0kpRwWc/QCyoiNYc7 pxG1RO2PbQVuxOzbt84vrJ/J86P1LyWYumNrQ+9joc9Bw9CV9q2AOp8aPEpYYZZP0aMXlNqtl/f 2+1EeEfUtHU5+39GLukWq2NpMkwTuCd4+tHYc3almZlNIjksnRNLCk7kxES4WxaJu4YO+UtSO8b VrQjVMJMXBjGx0eDJ+jb3+C/18CnUH5Gnf7jNzT6S9l2v9Z0lvZ8zB5+P3rU9BLisGtePkZ9/v5 plZ3MpnkBGXSmlOjxoz4GhuAP6CxcvqHNVa0UAtDC3XQoVVkUe/wuhGIWQPk5sL2gFtDxUktCrB o3BUx6kM4jjg== X-Received: by 2002:a05:690c:398:b0:788:14a2:8bda with SMTP id 00721157ae682-793c536b298mr34222817b3.38.1768581904585; Fri, 16 Jan 2026 08:45:04 -0800 (PST) Received: from localhost ([2a03:2880:25ff:5c::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-793c68bec97sm10523647b3.50.2026.01.16.08.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 08:45:04 -0800 (PST) From: Joshua Hahn To: SeongJae Park Cc: Andrew Morton , David Hildenbrand , Muchun Song , Oscar Salvador , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/3] mm/hugetlb: Remove unnecessary if condition Date: Fri, 16 Jan 2026 11:45:01 -0500 Message-ID: <20260116164502.517338-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260116013940.71199-1-sj@kernel.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, 15 Jan 2026 17:39:39 -0800 SeongJae Park wrote: > On Thu, 15 Jan 2026 13:14:36 -0500 Joshua Hahn wrote: > > > if (map_chg) is always true, since it is nested in another if statement > > which checks for it already. Remove the check and un-indent for readability. > > > > if (unlikely(map_chg == MAP_CHG_NEEDED && retval == 0)) { > > ... > > > > if (map_chg) { > > ... > > } > > } > > > > No functional change intended. > > > > Signed-off-by: Joshua Hahn > > Reviewed-by: SeongJae Park Thank you, SJ! > > --- > > mm/hugetlb.c | 12 +++++------- > > 1 file changed, 5 insertions(+), 7 deletions(-) > > > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index 88b9e997c9da..432a5054ca1d 100644 > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -3019,13 +3019,11 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma, > > > > rsv_adjust = hugepage_subpool_put_pages(spool, 1); > > hugetlb_acct_memory(h, -rsv_adjust); > > - if (map_chg) { > > - spin_lock_irq(&hugetlb_lock); > > - hugetlb_cgroup_uncharge_folio_rsvd( > > - hstate_index(h), pages_per_huge_page(h), > > - folio); > > - spin_unlock_irq(&hugetlb_lock); > > - } > > + spin_lock_irq(&hugetlb_lock); > > + hugetlb_cgroup_uncharge_folio_rsvd( > > + hstate_index(h), pages_per_huge_page(h), > > + folio); > > Nit. Good chance to reduce one more line by putting 'folio' on the upper line? Ack, will include in the next version of this : -) I hope you have a great day! Joshua