From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: "peter.griffin@linaro.org" <peter.griffin@linaro.org>,
"andre.draszik@linaro.org" <andre.draszik@linaro.org>,
"tudor.ambarus@linaro.org" <tudor.ambarus@linaro.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc3: google: Remove redundant dev_err()
Date: Fri, 16 Jan 2026 17:32:17 +0000 [thread overview]
Message-ID: <20260116173210.5iugbcn3qcjenosx@synopsys.com> (raw)
In-Reply-To: <20260115023800.4142416-1-nichen@iscas.ac.cn>
On Thu, Jan 15, 2026, Chen Ni wrote:
> The platform_get_irq_byname() function already prints an error message
> internally upon failure using dev_err_probe(). Therefore, the explicit
> dev_err() is redundant and results in duplicate error logs.
>
> Remove the redundant dev_err() call to clean up the error path.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/usb/dwc3/dwc3-google.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-google.c b/drivers/usb/dwc3/dwc3-google.c
> index a19857bd6b13..2105c72af753 100644
> --- a/drivers/usb/dwc3/dwc3-google.c
> +++ b/drivers/usb/dwc3/dwc3-google.c
> @@ -228,10 +228,8 @@ static int dwc3_google_request_irq(struct dwc3_google *google, struct platform_d
> int irq;
>
> irq = platform_get_irq_byname(pdev, irq_name);
> - if (irq < 0) {
> - dev_err(google->dev, "invalid irq name %s\n", irq_name);
> + if (irq < 0)
> return irq;
> - }
>
> irq_set_status_flags(irq, IRQ_NOAUTOEN);
> ret = devm_request_threaded_irq(google->dev, irq, NULL,
> --
> 2.25.1
>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
BR,
Thinh
prev parent reply other threads:[~2026-01-16 17:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 2:38 Chen Ni
2026-01-16 17:32 ` Thinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116173210.5iugbcn3qcjenosx@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=andre.draszik@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=peter.griffin@linaro.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®