From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012065.outbound.protection.outlook.com [52.101.43.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF6352E03F1 for ; Fri, 16 Jan 2026 21:00:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.65 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768597216; cv=fail; b=LxbxBfZrci9UtIkrweHjOO6iCYEhQTkVRFnx+Rhgx+MZBLFFu0LHfMdLMO9IfNqQBw8FKYVwVXteCyiFhyCNg3BIRiN2rVPpVhhn79VF6vG6krwy+bvWynUduPxuFpryWKFhAstZpnHzPHjXpHWnOvG2bU5MndK2yyrXcIrxi90= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768597216; c=relaxed/simple; bh=xvDizajLR6dKdief+0iHs5CHu5p4NIBddrU7FOAYXNQ=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=BJ/VxIVR1dqei/WrzEAfnfiY6rjJVkNRSsXzNBudWCTNYlhBw870g25dvgklRTOU3PgzXQ0noUc6FY87GB21FCpuM2L7q5r99vv/UjAnXaHBVqoWoX68Htnw9NBALwWn2MeHQfzdSZMXTv62jPU3qUq+MJWlCAgLw5nv3yCKqA8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=u7Z2qjuT; arc=fail smtp.client-ip=52.101.43.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="u7Z2qjuT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vBKLGP7A6bHKG8jqYkS47gJKx2i6oYTYlwVvWepVPmigXNFCWUHk6tKnarrlDsf26NjlSKgV86YGviT8xuSXGIM/Pv2PdgfG/tpbvM5eUN0LEsN4wvyjSrVUVkKw9gIb00eezpatHzJIFDxyk46Xn2KdPwqH5mHSOUA2FMLui76wJunKiz4wyE6zroGfIi19bVOFmKb7Gib7CJNwnD5EButpIHXxk3/umc1LPS49lTBqXnGbPO0Xl6jLKozzWD+0CAWrjnttqRx0yfLLMMOK3Y0uRs28oMa4D62UPwgbb796gCR4efDhoVYLmH0n0iOI0+gsD/muqq/dl8yFbJtb3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kv1ATwdmQGWOKre8o8JHIC3kqDZXSbP4krSPCmO25hU=; b=TQAUBHW0r6uHDz/zs3tXuGvV67vcrCfqLzTly3RBH535ymOPJLUoQQ0XoSTVu155Rs+Qiki9OwFINxGkRyt6GGNbVximHQcfkl4nJjEInvPj5H0R9a/WBEA+P9a5rtahVsNVLyGyNDcUVnTtE4Nf6XAYtRZFeJGgRgeu82yJRvhuFXVfJV+xjCCU0FK92ysvtyh9cG+8qYWg4VinMkAR49GcXOYzSElrOGzQ4JgsBmYA1+ty/pkNbN0+xmkHX0QbtSDgZqr+eaTmo9BoQTCOjJJxiC/QEgnSyRUKvjQ1bD+k/ocx9xLQdNCJ81JxSy6VXH/Dsnm1MyTpMBw9msKrLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kv1ATwdmQGWOKre8o8JHIC3kqDZXSbP4krSPCmO25hU=; b=u7Z2qjuTPDAJlrn5cy5swKftxNcq6drG9CqtjQlTbXkj9sOT704B+XR31Mn7IvPxJsWjHQw7jhueltzi7gEcVKqe13o7Xeuhj/j9LZ4os6/ftQXz9riW9jxIlUhb5ok+oTnGMsMCoWTLV2ZLHnRhydAOBFP9WgL/ZZdcCNbio6Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from IA1PR12MB6354.namprd12.prod.outlook.com (2603:10b6:208:3e2::11) by PH7PR12MB6490.namprd12.prod.outlook.com (2603:10b6:510:1f5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.9; Fri, 16 Jan 2026 21:00:12 +0000 Received: from IA1PR12MB6354.namprd12.prod.outlook.com ([fe80::1d15:ff5e:339:c009]) by IA1PR12MB6354.namprd12.prod.outlook.com ([fe80::1d15:ff5e:339:c009%4]) with mapi id 15.20.9520.005; Fri, 16 Jan 2026 21:00:12 +0000 Date: Fri, 16 Jan 2026 16:00:03 -0500 From: Yazen Ghannam To: "Mario Limonciello (AMD)" Cc: Jean Delvare , linux-kernel@vger.kernel.org, Borislav Petkov , Mario Limonciello Subject: Re: [PATCH v3 4/5] firmware: dmi: Add pr_fmt() for dmi_scan.c Message-ID: <20260116210003.GB471170@yaz-khff2.amd.com> References: <20260110134835.1296600-1-superm1@kernel.org> <20260110134835.1296600-5-superm1@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260110134835.1296600-5-superm1@kernel.org> X-ClientProxiedBy: MN2PR08CA0018.namprd08.prod.outlook.com (2603:10b6:208:239::23) To IA1PR12MB6354.namprd12.prod.outlook.com (2603:10b6:208:3e2::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6354:EE_|PH7PR12MB6490:EE_ X-MS-Office365-Filtering-Correlation-Id: eb86dfe2-bce8-48fb-077f-08de55423da4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Snqt6o9fQciO7sjfe9S/nV6DRgGFKJK/kIY7asq7gaHLb7Qc0ATfZb1q6K2x?= =?us-ascii?Q?AMBU41JUzDL0wOiVPjl4ly8ClJ3ZYJQe9OuoY5Zx9obm3YeGBFcCuz37rxzK?= =?us-ascii?Q?Pd/XAcMnMNzXBeTroHDBFTXizaoqivu78Gy8MzHTQA8d3bJ8rIweKJunjRWo?= =?us-ascii?Q?OlZAOcqM9Z4QwwbWh0hAm5HWDfOhi1+I72zRgvtWOHL2KrAfBZt1SD4xfRl5?= =?us-ascii?Q?6VnxaltoddbikofNqTzJGFPxzzgcQrEqJQsVWHpl1g2GEbOJALfWYJCl3kmB?= =?us-ascii?Q?RCj27ChHfN3V2Ej5Y6GKEhORKqoeD/5qvKE+l3Jpq/C7/+Yu146qTlBIXUhM?= =?us-ascii?Q?IGQRnyT/Yzp9ttpSoV6QV+nJN6DS3NxuAJX3f4WHaYTDFCVZZfSolirGayYa?= =?us-ascii?Q?EIFEUkyDmttykBVmmZEgdUK4rn3sDBNBRcZ6tKreccaVqOd/s2yiyPuw5SHx?= =?us-ascii?Q?+sgxqhUwETA/V3QvFf/igWqP5Moxg3QilU6IEpNrd/fD0KeOXcV+JT6gqR58?= =?us-ascii?Q?Pipnah1s+U4tqcDiivKroXINrAQq0O2i4wXcYYgNSAXqimG7NC9CWrkqZ7hF?= =?us-ascii?Q?4iA6pLz7aodjhauD8NP5uD5JFbECNmpKP2z6DX+dgUTPZPrLbrQi1ugisK7r?= =?us-ascii?Q?oMCbts4FG/ty/eHlO0yp+hWINPlJcVx7SbdUyRYWHVCYDB9+2TQLE5UflsaH?= =?us-ascii?Q?mDEcX+n4wXgbbQFWspjUOf8Icq1yhEUGurEtH8eQsJjYGjdXnzr+GjwWDd+3?= =?us-ascii?Q?SfvvthrYzZKiffQ8npH766eOQiSbOsSCN8rYsE/iqFvOCa1PmvLpJMVtdiAe?= =?us-ascii?Q?n0OPAOcpwXCmVwNTUxAVrejcGjiV0jYDhT0nTA/C6Ae1wyzw9/y3oFpx+oRB?= =?us-ascii?Q?rhtPDQoSKeYMYq+7jupy+ZA2Yk9sM8WwdmfNH0ZKMxoD6yYUEutooNggLYer?= =?us-ascii?Q?MvSn5ZVKDsF5AzwE4w+JIjz02KPtbA7tonbEKvau1bBXcwKRnkvwevJr7/hh?= =?us-ascii?Q?TZFApefofT3uBzkUpfhcILklMn05pFV3R/WuU+uzWmU59i6/QzTORijZJn7C?= =?us-ascii?Q?1oNwRlgaUYFXkF28PUJI6fSzPyeQ78NtW3RAcP9f0uv/E6hT7yvdpONhn0aT?= =?us-ascii?Q?Rlpc1yiA9z4Az5+0p9kcpYkb+mvpiQV0kSagBzu1V1o+ECeZj+3DaAumfk/R?= =?us-ascii?Q?iEmlCaDHhVMfqe0gUMfVHqfQR3BG6iP/qzwkL5ePPYZWovJUAuJt15jpvT/S?= =?us-ascii?Q?yzMpBOREVullSI1GV+WYNNs9P/wJdDh0y10hqjCiwK0lfzb1MzByQZIMBsjn?= =?us-ascii?Q?jiOtMcO97sGlLqJ9u+jXEWZ6oP4I1WCu5qTD5BkPsL5qhQhcz2S2r56M3JJN?= =?us-ascii?Q?a1n5F8wqkhd/VLPTm1yszM/XdDfHx3PezVU3I5Mj/6JWo1CZYF7QTE31gzlz?= =?us-ascii?Q?vcoyol+R9KjAWnpL3OwjKF1XGWXfgQYzhGzMdwl4peBAVFQ9HtjD2/gs35CS?= =?us-ascii?Q?KXd02VbagAzAShN1BqnNPVWCNaWXs61RNQU25GheYQOfOGgaRlDasTqEy6/1?= =?us-ascii?Q?AeMHpuIxDTT41ciVm2Q=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR12MB6354.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RXMvbo432lTtp/2xRwrufQYaH5HhZNHyXluAZukpuAPlQ6FtlYGkcX8QFybV?= =?us-ascii?Q?8LeADlwlsEJPRLX+HXXDzmzTOIYIjOEMuEo7xbPdYmHj+43Sv0JbjoYYqc5d?= =?us-ascii?Q?cN9TXEDA343tq6MgHfBjH355Ooos+f5pvp1kwKVj+R2L/WQBB9rRZ1sGfNxg?= =?us-ascii?Q?9T1hfdxKJqgR25l6/s2atG/av5r16jgnUAeywvqb/NagSfowM1dwt1Vlgpb5?= =?us-ascii?Q?DcH3wZIEdgkJY8fDk1/FlDMSliTbAie7ruwge9+Q8sZXKjwBTq32MXBlTmfj?= =?us-ascii?Q?AAaKfCobJwZZsoe0CsQlp2ST9EW3p4zSQD9o27jkgMcNixLh3/9DqRKBzXvL?= =?us-ascii?Q?UYff8RitO8B8VdP/iPo9LAjBfZYMpQpWeAzcUr7/0hL1pUDqQntdEgyQHgA+?= =?us-ascii?Q?HPju4kkHRqxDHsb9g6dlgic82IDkrdzwLviLCvM24OJinAukXMwlatvQ9f/t?= =?us-ascii?Q?wnE3+XEIq1QrnWQImcqQVR78tzoGNXo0VWILoUMPyn/CLQTpaiDl/rHP3l/H?= =?us-ascii?Q?cmiIc1za0gokNDFS9WAymY2sH0427ziyofG7LvNG+aLx+6zKtudk6dg0sarB?= =?us-ascii?Q?+lDFwW5tkpz5Q4Xvt/YxRs/dC/Od4ku1Fna+wCoaz3hlwU26at90R4XOZD2z?= =?us-ascii?Q?4qbULul3VbA+sKNEO/jAfdoBExdkwZVeA7Xb9BGnd6PmVqxfIcIKp7T3j9b4?= =?us-ascii?Q?Y4yAYQQi/u2E7vvqSj3+2z+NsSfmlSM5LsVI3srtN9fpkXOjQi5lfEDFr4ir?= =?us-ascii?Q?XCOPGuPQFrCPfQA9N3oebSKP6iqythp5b2EKalwjAePnDfaGaftLFwY/5EXw?= =?us-ascii?Q?7PeXwCNpf9P8EQ8kGUHndHTIvJjtqWUePlaUAalelJ2CKKHc/jSxZqLtwbgP?= =?us-ascii?Q?ePPQM3Q2OUT6glP9gQnU41cKvOIsTL8SV5V9l3PUoByR6KbuUfbbdnyorXB1?= =?us-ascii?Q?BfwVsANui7hcXZEpyW/2rZCJpl/4IdnMbM3jCphivlYs15+7taJ/LpUCJdGR?= =?us-ascii?Q?h1YQkYWK5odq+SRV9qV3HIpuqlS+h2IKMmzmZOXu8IjuViYMhbsX/cWWsC7f?= =?us-ascii?Q?HabGg+QVAZJwIILcYJ8ElriLQh82zqXJRunINZ9R+u0AZ/TiGBBJSKtdHzlm?= =?us-ascii?Q?V+a7pGREIhEdFS3aJmlTpF9NCNDKr7eOAzVuGVINk0ZOGeFhGuL6L0XJUPzk?= =?us-ascii?Q?um25B+pHzeyhMvbC9deE3oocHD2yRZH04mbEgLTSAk2NouwkpDRZBY6oh09p?= =?us-ascii?Q?tYz62frENyF5xzLig3380XQjN7Yc6gOAA/ihldRjbFW+U1k6RI007Xr7Kvm/?= =?us-ascii?Q?ftMA7LT6YA6H4wIx5K00WlJo47BG3xTQK+4zkolmdZtmLzrq0UWTwLumBNfh?= =?us-ascii?Q?JyJ25lt04i5ec1cFdsn8y/VGzV4Ar7lsNBae2l2K6QDGEQvASth12RWX401q?= =?us-ascii?Q?BcsZP3mWl+PeAWiYPd3EG/tZKiuuF0BDr+EXK83hymwAKz2VSLm4VFHIUn94?= =?us-ascii?Q?A41giua+mY4aUflICMe2F+9Jzc/W9YJNpfVEZ+HSV2vw3G2rdeH3kbfEr5u0?= =?us-ascii?Q?NxCAWmrNzIPHVCeAvZRlnmeh/ZOZtZRGaNi038zz62jxwDEtxSq9aORzI830?= =?us-ascii?Q?DhLli2U1odwVLbDRfUrd6J7ojXnx9mQnCdv8IoY2Z8qeBI5tUJ+/lBjOHQyk?= =?us-ascii?Q?OUVK1yxjT+70b/y04KgJ3v8B1bbRSIWpElmlIaehCQKeH9alaSi6coX6oBqN?= =?us-ascii?Q?liAfePbt9Q=3D=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb86dfe2-bce8-48fb-077f-08de55423da4 X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6354.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2026 21:00:12.5042 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2sC85BLQlmyOKZa61uAZyTwDeNJQat30oMP6jkxHgrlFEfVaT0UsnSXipLxZBZxbqUrJ3LhAoCM4KfpJJe5sHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6490 On Sat, Jan 10, 2026 at 07:48:33AM -0600, Mario Limonciello (AMD) wrote: > From: Mario Limonciello > > Several prints inconsistently use DMI: or dmi: or nothing. To make > it clear which prints come from dmi_scan.c, add a pr_fmt macro. > > Signed-off-by: Mario Limonciello > --- > drivers/firmware/dmi_scan.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c > index 80aded4c778bc..caa09ddf0dfa7 100644 > --- a/drivers/firmware/dmi_scan.c > +++ b/drivers/firmware/dmi_scan.c > @@ -1,4 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0-only > + > +#define pr_fmt(fmt) "DMI: " fmt > + > #include > #include > #include > @@ -634,7 +637,7 @@ static int __init dmi_present(const u8 *buf) > dmi_ver >> 16, (dmi_ver >> 8) & 0xFF); > } > dmi_format_ids(dmi_ids_string, sizeof(dmi_ids_string)); > - pr_info("DMI: %s\n", dmi_ids_string); > + pr_info("%s\n", dmi_ids_string); > return 0; > } > } > @@ -663,7 +666,7 @@ static int __init dmi_smbios3_present(const u8 *buf) > dmi_ver >> 16, (dmi_ver >> 8) & 0xFF, > dmi_ver & 0xFF); > dmi_format_ids(dmi_ids_string, sizeof(dmi_ids_string)); > - pr_info("DMI: %s\n", dmi_ids_string); > + pr_info("%s\n", dmi_ids_string); > return 0; > } > } > @@ -810,7 +813,7 @@ static int __init dmi_init(void) > kobject_del(tables_kobj); > kobject_put(tables_kobj); > err: > - pr_err("dmi: Firmware registration failed.\n"); > + pr_err("Firmware registration failed.\n"); > > return ret; > } > @@ -831,7 +834,7 @@ void __init dmi_setup(void) > return; > > dmi_memdev_walk(); > - pr_info("DMI: Memory slots populated: %d/%d\n", > + pr_info("Memory slots populated: %d/%d\n", > dmi_memdev_populated_nr, dmi_memdev_nr); > dump_stack_set_arch_desc("%s", dmi_ids_string); > } > -- > What about dropping "DMI" from this one too? pr_info("DMI not present or invalid.\n"); Thanks, Yazen