From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C48402FF662 for ; Fri, 16 Jan 2026 15:28:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768577335; cv=none; b=hAgTf/wnBlIcipqSJ/b4LhwPjAn+zRSOazzTPpjFrKR6wZ75b3twqAtqguoISBubcGfNaHtesHo6LpvINE1BxP0m1PudsiLiJ93t1WuSloPgYmpOsruwcEXzW3HP56uRYybwmAjxzIVJ4Kw0GbkR89cI/NUDKW3jQsXnxIVaikk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768577335; c=relaxed/simple; bh=BGoXSNv5pkTXCVvsmGrxGtsfUnz4YzPUe64588WFz70=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XwdVeV6KKmV0SnCJaeLd0MCDzFoZJHS9lWwCudMQqlltso9SXNSDBRV7yFRraKSpB93ofmdMluWTXa1qkJl9uJiKmKTA0Y7ciz5XayK0OYLF9Cgk0eEThipNmBp+NaWD0z+nZh9gmeSRoxf4ZEgeq86yBaJAN93uDPjR2zcJCOc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2RnuVIku; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2RnuVIku" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B13DC116C6; Fri, 16 Jan 2026 15:28:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1768577335; bh=BGoXSNv5pkTXCVvsmGrxGtsfUnz4YzPUe64588WFz70=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2RnuVIku+7DIE9KART+VnxcOV7/AxYwUQ/BnaCL09o69mtADzzKuf0pOWL+n6smkb kFqzrGupNZ4pdNMLY+mUY6kp/3q/C69vNjo6aG2vrVO4vqyt84YGGSwoKvqO8IAsLa I5oDJyA2AL0FYPFuPu2UMDeglnQ56I+Sk1DRebbI= Date: Fri, 16 Jan 2026 16:28:52 +0100 From: Greg KH To: Minu Jin Cc: arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] char: mem: fix typo and use pr_err() for logging Message-ID: <2026011646-disengage-enticing-4f86@gregkh> References: <20260102062759.3749606-1-s9430939@naver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260102062759.3749606-1-s9430939@naver.com> On Fri, Jan 02, 2026 at 03:27:59PM +0900, Minu Jin wrote: > Fix a typo in the comment of read_mem(): funcion -> function > > Replace a raw printk() call in chr_dev_init() with pr_err(). > The original call lacked a log level, which is discouraged. > > Using pr_err() ensures the error is properly categorized and > follows modern logging practices. This is two different things, it should be 2 different patches (yes, I'm being pedantic, sorry, that's because:) > if (register_chrdev(MEM_MAJOR, "mem", &memory_fops)) > - printk("unable to get major %d for memory devs\n", MEM_MAJOR); > + pr_err("unable to get major %d for memory devs\n", MEM_MAJOR); This change doesn't really do anything different, so it's not needed. Let's leave it alone as it's been this way for decades. thanks, greg k-h