From: Krzysztof Kozlowski <krzk@kernel.org>
To: Luca Weiss <luca.weiss@fairphone.com>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Robert Foss <rfoss@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: i2c: qcom-cci: Document Milos compatible
Date: Sat, 17 Jan 2026 12:54:58 +0100 [thread overview]
Message-ID: <20260117-obedient-galago-from-eldorado-8e0ba4@quoll> (raw)
In-Reply-To: <20260116-milos-cci-v1-2-28e01128da9c@fairphone.com>
On Fri, Jan 16, 2026 at 02:38:56PM +0100, Luca Weiss wrote:
> Add Milos compatible for the CAMSS CCI interfaces.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> index a3fe1eea6aec..c57d81258fba 100644
> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> @@ -27,6 +27,7 @@ properties:
> - items:
> - enum:
> - qcom,kaanapali-cci
> + - qcom,milos-cci
> - qcom,qcm2290-cci
> - qcom,sa8775p-cci
> - qcom,sc7280-cci
> @@ -263,6 +264,23 @@ allOf:
> - const: cpas_ahb
> - const: cci
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,milos-cci
> + then:
> + properties:
> + clocks:
> + minItems: 3
> + maxItems: 3
> + clock-names:
> + items:
> + - const: soc_ahb
> + - const: cpas_ahb
> + - const: cci
Same comments as other discussion these days - I guess that soc_ahb
serves the same purpose as camnoc_axi, so this is just last entri in the
if:then: blocks.
I really find this binding terrible - around six names for AHB - so I do
not want another combination...
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-17 11:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 13:38 [PATCH 0/4] Add CCI support for Milos, enable on Fairphone (Gen. 6) Luca Weiss
2026-01-16 13:38 ` [PATCH 1/4] dt-bindings: eeprom: at24: Add compatible for Puya P24C128F Luca Weiss
2026-01-16 13:58 ` Konrad Dybcio
2026-01-19 10:15 ` (subset) " Bartosz Golaszewski
2026-01-16 13:38 ` [PATCH 2/4] dt-bindings: i2c: qcom-cci: Document Milos compatible Luca Weiss
2026-01-17 11:54 ` Krzysztof Kozlowski [this message]
2026-01-20 13:18 ` Konrad Dybcio
2026-02-13 13:16 ` Luca Weiss
2026-03-13 10:43 ` Luca Weiss
2026-03-13 16:18 ` Dmitry Baryshkov
2026-03-16 8:03 ` Luca Weiss
2026-03-19 16:58 ` Krzysztof Kozlowski
2026-03-20 7:58 ` Luca Weiss
2026-03-19 16:57 ` Krzysztof Kozlowski
2026-01-16 13:38 ` [PATCH 3/4] arm64: dts: qcom: milos: Add CCI busses Luca Weiss
2026-01-20 10:59 ` Konrad Dybcio
2026-01-16 13:38 ` [PATCH 4/4] arm64: dts: qcom: milos-fairphone-fp6: Add camera EEPROMs on " Luca Weiss
2026-01-16 13:59 ` Konrad Dybcio
2026-01-16 14:54 ` Luca Weiss
2026-01-19 10:42 ` Konrad Dybcio
2026-02-13 13:39 ` Luca Weiss
2026-02-17 12:42 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260117-obedient-galago-from-eldorado-8e0ba4@quoll \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=luca.weiss@fairphone.com \
--cc=phone-devel@vger.kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®