From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8042B2DB78F for ; Sat, 17 Jan 2026 12:06:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768651600; cv=none; b=fWM+yYiXfp1yPIZSiz1fIHWIrp/vJKyXJnpMhtOOJdjNJqcdH/SQDPDWdO//6lFiSl4NSfYaO8OHLVOOcr0jbXYOnk9Xj8ooqvrK9F4aCZOhdBbUOJRooCHz1wQ/Z0wsKC57Fna2BtxxbGtjt9yMMEkdHSDgsyG14BE9Sk2BqKk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768651600; c=relaxed/simple; bh=Xuc98TObcn38gZY7CMrM88f1rNXWeDYWgmRVNN20vTU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VdzBE+mIsPEB8yLcDulKhZascCqwxpLSIZv2pCPIYzUwNdCiK8YLoComtEeZuNM0GYp42GH7zfJNOWX/KBVtaDpllI9qpNY83mt5h/DUOFrczp5/+WQ6XUoe19yqlhfk3XAyXFOx5yrC4Zc8Y/cYkiGhv6j+8gXsYJVw6ecMWZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IzlzJA/X; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IzlzJA/X" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-432da746749so1379685f8f.0 for ; Sat, 17 Jan 2026 04:06:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768651598; x=1769256398; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Hgzz2g9xI3B7sKWHIbum1LJH2UJJWU63NtgcfullTeY=; b=IzlzJA/XnWZNQGYLxGdx5GX57judtiJOYIyo2FBZHzQ5zpgt5VxNWe1HfGz3T/5FqM cGtcP1BD/eEbCtWJCd9GxrlewMonBcnXXNr+zX9m79zwLgw/tVW7XvvqIFjwvzJwWKfI SwA8L2B29AMsjX4ZuMNNtKiBWda2RtyT9WqdQLrdKUEdFjyugByE+5AU4lecwmFMiHUt 5bldbxRvcFKBr7PrXqtMAY1tcnbGBzKPSDDwkDXHaXVi6em0Fd1NMyy+bux7TO9TodQu 0dWjIKV4XUYw93WjdqTi3qlQb6meOYWFGmx82sHPJMxobqc/wDbdQ23Op1P+TNZRYgVN 7+ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768651598; x=1769256398; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Hgzz2g9xI3B7sKWHIbum1LJH2UJJWU63NtgcfullTeY=; b=FG1D1bj2Gr4BwCCRI2GTcn6zwPVBshHXMfRd3NllK/NYddIuW72ZhO2/3AKlek9vKJ 2FWECkXrTNCfQeHu4OJRZg/t+0/2ppCGHJ3ZY49Q7b6IDZ3NQ0p+RsSxnLE6Nvho047H 3KXADxhx5UgypDmohOfrPpiLvQX34/80Nzh04to32Uqsj55J4dJJF993I6XJDU7R81nk F53WXaV2SQj+vqgwH5h/TZw+je3eIcGT/z40euwRgi3jez/gaB48bbo3Ze5pkx/lrH21 WyiFxxhZVVOq2WZGWc0AcBTm38AbYUxFSk6Rwqxw8vrez1n69k7ft3kMlCfTQiJxpiPJ WWng== X-Forwarded-Encrypted: i=1; AJvYcCXpk4/XDuNiUwMPcZWA59gpAK6V5yw//91qbThhOm8+CXLyp8QeNaRfPQ3f+vSBW+UWODPg8Wi9Oio9sO0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9bITo0Z5F6CIcluatqJE7SROQh6QkSi6yPjmx6j8UCjVoEPr6 KD2xAVbbvQUP/G3snNP+Gi5gpr985fDYRjXIkCJO/a7neu/ilvwcII+L X-Gm-Gg: AY/fxX5uWpz7ZP43boYpH3eLJU0YljLDj/YgtEwe0/3u1IO5wuxva9tVqd9y+4mAvwQ GFKMtYZOX/hL3ny9LlAKJq05k9WXdx8mfK/fee9vj3109e+SZtw9D5l6gqDGl7iHMzWszkky0Yh CynCAmnWWjZFJKINRatWMaCXXoXH79+FBoRSh1zSmqnKJtybwpRVNrsrSnQgIpwWTPQMwHJZMmN sXjm1FrF9raho7K3bNP5nR/xXrjc7CDFg6HbStYGRekf60/1d+iE25AslmKZvf644hW9SqYJRz5 Bq8aSlv05SmqUW2o7ta7peRzcv/USuBBnhPy8Ly6rwlP0gKkflCZ+Fwzg4YIv7HEvV40h+pz6C9 moVL22IO5NX5JK+W1xaZi+Tt679KtSXcm2jsNBxeJQxYwEqtpmszTLxSE3Khbj5M9co6yMGgFmU AD4ANn6Yb097ONB0Lnhaw6B+fICJI/uMknjguy/ca9fv/Kk+4NAXsI X-Received: by 2002:a5d:64e5:0:b0:432:dc1f:6982 with SMTP id ffacd0b85a97d-435699928ebmr6938489f8f.16.1768651597711; Sat, 17 Jan 2026 04:06:37 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435699982aasm11193342f8f.42.2026.01.17.04.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Jan 2026 04:06:37 -0800 (PST) Date: Sat, 17 Jan 2026 12:06:32 +0000 From: David Laight To: Greg KH Cc: Weigang He , mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] usb: xhci: fix missing null termination after copy_from_user() Message-ID: <20260117120632.75e3c394@pumpkin> In-Reply-To: <2026011725-ecosystem-proved-a6ba@gregkh> References: <20260117094631.504232-1-geoffreyhe2@gmail.com> <2026011725-ecosystem-proved-a6ba@gregkh> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 17 Jan 2026 10:58:41 +0100 Greg KH wrote: > On Sat, Jan 17, 2026 at 09:46:31AM +0000, Weigang He wrote: > > The buffer 'buf' is filled by copy_from_user() but is not properly > > null-terminated before being used with strncmp(). If userspace provides > > fewer than 10 bytes, strncmp() may read beyond the copied data into > > uninitialized stack memory. > > But that's fine, it will not match the check, and so it will stop when > told, so no overflow happens anywhere. That's not entirely true. If the user passes "complianc" (without a '\0') and the on-stack buf[9] happens to be 'e' then the test will succeed rather than fail. But the only thing that will get upset is KASAN. More 'interestingly': - why is it min_t() not min(), everything is size_t. - why sizeof(buf) - 1, reading into the last byte won't matter. - why buf[32] not buf[10], even [16] would be plenty for 'future expansion'. David