From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D4433398A for ; Sun, 18 Jan 2026 08:17:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768724243; cv=none; b=iKOCr+fOpV/mpuEVwk2n1rxfmeFTnEi/jjtxA1uz1VwDgdd+zVhNpLWMTBtb55YRa58GKZ6PPbMDnkIpfPz+Pbc/wBcFg7GjUI1zqIXwan0l4TzHS65SxjScIqqKQ+wGMFOu1cF4UXn/SStlRnNJ6ZMegOGyqV/AJEOc6HkBWNA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768724243; c=relaxed/simple; bh=Pj1sPigIp/NebNJ8oa/bhXNBS40dnz2XB0+eNSKkJvo=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=Ry3p0kMoiVwMuZope947defT065h4rjpwba0s17ZmDr17tJcpc47tWSk3nmvZOYnQYINjCFYL9whP4iRSQWXNps2LfYUOOUaWOwvH6iI/sOejdBw6GpEFK5ngu40WM+8+ddfkLy1ojzMuMrnVsWdfMyZvCjDXwsqVs82mx+vP4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iWwZKq09; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iWwZKq09" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-b553412a19bso1291964a12.1 for ; Sun, 18 Jan 2026 00:17:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768724241; x=1769329041; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=eEP5iKdXQBSTEl9I4Q+Cs17dhqRzcqmuf37yAQk7v9Q=; b=iWwZKq09MSYQu0avfOEQBEEyb6WzCtjjYNO+WZd/Ul2R/MZ9z6e4pJNelAJggKCsPp zMPmyxFInbNQR9mynkFO2SHw46qFWnKDSIJ5xkRxDabd08wPtEXwamKNwDbnha4htTiK K4sukEgVk0jbyxdrYXsbLH05tr+MAb4I7j9RTUyPTTxnsVqhVHxps5m3R9Ps4S+7iRhD iU+tPr/3c+/RpESiKG6BlOhwR9+fdep2+wR1T1rtntm+1Rw1i7uDrtNMDXMeOiwL0ZwH rZTtJgnnr/c5BQq8LU9rRjfPvaO89oWLDNS80L9sBxb8LxEhkZnn3exCbQdlM6Oh3flK uEtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768724241; x=1769329041; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eEP5iKdXQBSTEl9I4Q+Cs17dhqRzcqmuf37yAQk7v9Q=; b=UtPiYmNpoqYCnQcsHjO2ZOOrERx88BIFb21STTY7qCWHKzripV+LnXS53u/Wa6ilRS dvQBMKosKyR2U0UwlWTNzhkf/t/fx7PPF/GtmYEfZZV5Mo3zYgv/UFPDFBcdTGvcZSDC /CldAN/ldxx3urUzZLqbm3ayR/mX0nhKQLjm8rarccsRM0aZKqY/4AR+gTWkup8dM0ld +KIrAYd1NH3xDyeLK/SsfAlPZ1NTgnpRVPUh78ayZPyrQEqjfBvJO5qWBn9kSbggbXhF wEVgaOK0KR6j2zrBZ3brfllDi4hi9OAMfvKULKY5q/JoA/J69fLdJ4aPqwa3Bas9ZVoN gjJQ== X-Forwarded-Encrypted: i=1; AJvYcCVfkaviV29JxuEALZ8fXA/mxL0gi9krfbsBU2J34aGrRkUPVNt9PMGsXX/C8kY5+gs7fqg3ra5NasDIpWI=@vger.kernel.org X-Gm-Message-State: AOJu0YwleIQ05MaD+ZI3XTc2uOCZ37yR/VXBsKjYBZ0HE9b4UOOQLcVv ism4SaWM2k86/gSZZfsV1RftZmhly0ITR+RtHzVZXHuVwgXRwaT1YYri X-Gm-Gg: AY/fxX62By1tqTsiFM6FuT37nf4s2I0vFZROb8Fy7OVjtaRgWwFragekFzsHuU4ODaD IZOqQ9uxVdHUDi6BkCGJ09A4pZbvA3P8zC4UeTYgUpx6hFEAC2w6q+3eKt2Ap0sthM00yqIwFkG 6QikZndhrccB6OO6/Zq2JluL/YdbVPWbTjYxGh2wzNW+T3DKDUTjgejQudfoI1hDNPCyOFQc7IA gVQjRPMDiVgU2Cn9IM5h90TbJJ96wSpemngApwXgh0Uvzgh515zZAdUP3WIh6BL0+Nqua+JW70l 6s5S2xqc61gL14u/E2A+TTyCTarm3I3eafTXk0D5cB1Ja9lOULc5sD/Geo1agO0Q7nCDUYaM/CI 8bN6z8RbbfA9nguzb3+b9/p0npbymcHEdpEuSENlgP54KAnTWqiy6yoKrinL9OG7/Schm/Jx34r meCP/RQdMB X-Received: by 2002:a05:6a20:a10e:b0:363:e4d7:2c34 with SMTP id adf61e73a8af0-38dfe772e84mr8200324637.57.1768724240888; Sun, 18 Jan 2026 00:17:20 -0800 (PST) Received: from [127.0.0.1] ([38.207.158.11]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c5edf32d1f1sm5917393a12.22.2026.01.18.00.17.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 00:17:20 -0800 (PST) From: Zesen Liu Subject: [PATCH bpf RESEND v2 0/2] bpf: Fix memory access flags in helper prototypes Date: Sun, 18 Jan 2026 16:16:38 +0800 Message-Id: <20260118-helper_proto-v2-0-ab3a1337e755@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAOaWbGkC/43OPQ+CMBAG4L9COlvTnlDQyUFWBx2NMeW4QhOwp BCiMfx3K4mJA4PjfTx374v15C31bBe9mKfR9tbdQwGriGGt7xVxW4aagYBEAgheU9ORv3XeDY6 bQpGKZQaxSlkgnSdjH/O5Cys6E53yc348sGuY1bYfnH/On0Y5bywfHSUXPHQViXIbA5T7qtW2W aNrPz8CUkKKdAlJoxPYGETzP6JNlpLIIJWIP+gTeYRvzCUMAceYKCgQdaKzXzxN0xsyWYlHWwE AAA== X-Change-ID: 20251220-helper_proto-fb6e64182467 To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Matt Bobrowski , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Daniel Xu Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, Shuran Liu , Peili Gao , Haoran Ni , Zesen Liu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2233; i=ftyghome@gmail.com; h=from:subject:message-id; bh=Pj1sPigIp/NebNJ8oa/bhXNBS40dnz2XB0+eNSKkJvo=; b=owGbwMvMwCXWI1/u+8bXqJ3xtFoSQ2bOdI4//0sX75KOcjrXvYe55mrw5e0XJHZeXj5VMbQ0q CVCwVKqo5SFQYyLQVZMkaX3h+HdlZnmxttsFhyEmcPKBDKEgYtTACbi18/IMLv3wQezHzKJzzyr r18qVbapNmMOZatc/jf7MtOqHF2fA4wME+5tnLUier6H2NdcfwHmbH2FSZpqxwQ5T1/RNtiZYaH DCQA= X-Developer-Key: i=ftyghome@gmail.com; a=openpgp; fpr=8DF831DDA9693733B63CA0C18C1F774DEC4D3287 Hi, This series adds missing memory access flags (MEM_RDONLY or MEM_WRITE) to several bpf helper function prototypes that use ARG_PTR_TO_MEM but lack the correct flag. It also adds a new check in verifier to ensure the flag is specified. Missing memory access flags in helper prototypes can lead to critical correctness issues when the verifier tries to perform code optimization. After commit 37cce22dbd51 ("bpf: verifier: Refactor helper access type tracking"), the verifier relies on the memory access flags, rather than treating all arguments in helper functions as potentially modifying the pointed-to memory. Using ARG_PTR_TO_MEM alone without flags does not make sense because: - If the helper does not change the argument, missing MEM_RDONLY causes the verifier to incorrectly reject a read-only buffer. - If the helper does change the argument, missing MEM_WRITE causes the verifier to incorrectly assume the memory is unchanged, leading to errors in code optimization. We have already seen several reports regarding this: - commit ac44dcc788b9 ("bpf: Fix verifier assumptions of bpf_d_path's output buffer") adds MEM_WRITE to bpf_d_path; - commit 2eb7648558a7 ("bpf: Specify access type of bpf_sysctl_get_name args") adds MEM_WRITE to bpf_sysctl_get_name. This series looks through all prototypes in the kernel and completes the flags. It also adds a new check (check_func_proto) in verifier.c to statically restrict ARG_PTR_TO_MEM from appearing without memory access flags. Changelog ========= v2: - Add missing MEM_RDONLY flags to protos with ARG_PTR_TO_FIXED_SIZE_MEM. Thanks, Zesen Liu --- Zesen Liu (2): bpf: Fix memory access flags in helper prototypes bpf: Require ARG_PTR_TO_MEM with memory flag kernel/bpf/helpers.c | 2 +- kernel/bpf/syscall.c | 2 +- kernel/bpf/verifier.c | 17 +++++++++++++++++ kernel/trace/bpf_trace.c | 6 +++--- net/core/filter.c | 20 ++++++++++---------- 5 files changed, 32 insertions(+), 15 deletions(-) --- base-commit: ab86d0bf01f6d0e37fd67761bb62918321b64efc change-id: 20251220-helper_proto-fb6e64182467 Best regards, -- Zesen Liu