From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D495C1AAE13 for ; Sun, 18 Jan 2026 20:44:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768769075; cv=none; b=UEW6irX7YXyvcJYrVWRnxZv8mlrgpy93jVK9a2nFtNVmOnTaNp7+2mFy25HkIn3/ZnMinNCbp6u8Y0A3IHwVxNUzo26at7OCXEpmz9Loj9njZIWE8MUi7B14K0F3XZezJYth4zoJ/36UEoDZU8RLrG0hCbyCRlZB4h5ZsZXn6A4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768769075; c=relaxed/simple; bh=sqJ245TxhB3hXOJHOVAyYYh5zihTcSs2G475AGyJx0w=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=mDxxt+l83mXs56QQcwH90yg0kM11EbWNM2P3JOibIf8kEPpudHnYjLveYbL10gSaCjdq4ldDjmuRPQMLmrqFdAq5R9xL2dSK1AhCXEMQnRZRL03wTtXGD70U/h6K+Hm94xGGgoOBJzpOXmGA+Tym49Bv/Iq6MkRtMLZ9IDYmcUg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=K1xVxNC1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="K1xVxNC1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EE24C19423; Sun, 18 Jan 2026 20:44:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1768769075; bh=sqJ245TxhB3hXOJHOVAyYYh5zihTcSs2G475AGyJx0w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K1xVxNC1b4g2KuU7q+EzfJcxD9FYRFCGTJRMWfcVd1bFuYEcNfIIriai3T4CLhSzH d6d6S7anKWGZJX4sfevXoxkUMWCjBG47vXN8r989EYuec8icPEiDF8XL9h6Z6r6UsK jC8yWKC7sjtGonDOy9Q7BwNn6qJfUlRCcosDOh6Y= Date: Sun, 18 Jan 2026 12:44:34 -0800 From: Andrew Morton To: Pnina Feder Cc: pmladek@suse.com, bhe@redhat.com, linux-kernel@vger.kernel.org, lkp@intel.com, mgorman@suse.de, mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, tglx@linutronix.de, vkondra@mobileye.com Subject: Re: [PATCH v1] panic: add panic_redirect_cpu declaration to header Message-Id: <20260118124434.1373ffe0f314019381257a7f@linux-foundation.org> In-Reply-To: <20260118120149.986849-1-pnina.feder@mobileye.com> References: <20260118120149.986849-1-pnina.feder@mobileye.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 18 Jan 2026 14:01:49 +0200 Pnina Feder wrote: > Add the extern declaration for panic_redirect_cpu to linux/panic.h > to fix the sparse warning: > > kernel/panic.c:305:10: sparse: sparse: symbol 'panic_redirect_cpu' > was not declared. Should it be static? > > The variable needs to be declared in the header alongside panic_cpu > since it is used for synchronization when redirecting panic to a > specific CPU via the panic_force_cpu= boot parameter. > Thanks, I added this as a squashable fix against your earlier patch "panic: add panic_force_cpu= parameter to redirect panic to a specific CPU". (It's nice to tell people when a patch fixes a pending patch in this manner - otherwise everyone has to run around trying to figure out which tree is being patched and why).