mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: Rob Herring <robh@kernel.org>,
	Saravana Kannan <saravanak@kernel.org>,
	 Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	 Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Peng Fan <peng.fan@nxp.com>
Subject: [PATCH 2/5] regulator: of: Use of_property_read_u32_default()
Date: Mon, 19 Jan 2026 10:02:55 +0800	[thread overview]
Message-ID: <20260119-add_dt_default-v1-2-db4787ea7a9e@nxp.com> (raw)
In-Reply-To: <20260119-add_dt_default-v1-0-db4787ea7a9e@nxp.com>

From: Peng Fan <peng.fan@nxp.com>

Convert open-coded patterns that read optional DT properties and fallback
to defaults into the new of_property_read_u32_default() helper. Keep the
existing behaviour while reducing boilerplate code.

No functional changes.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/regulator/of_regulator.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
index 33463926a2a6c10ccfd9aa59d31c0b0c3635833e..83b8a1db8f99c1eefee73ad1e7f234b2280076dc 100644
--- a/drivers/regulator/of_regulator.c
+++ b/drivers/regulator/of_regulator.c
@@ -178,12 +178,9 @@ static int of_get_regulation_constraints(struct device *dev,
 	if (!ret)
 		constraints->enable_time = pval;
 
-	ret = of_property_read_u32(np, "regulator-uv-less-critical-window-ms", &pval);
-	if (!ret)
-		constraints->uv_less_critical_window_ms = pval;
-	else
-		constraints->uv_less_critical_window_ms =
-				REGULATOR_DEF_UV_LESS_CRITICAL_WINDOW_MS;
+	constraints->uv_less_critical_window_ms =
+		of_property_read_u32_default(np, "regulator-uv-less-critical-window-ms",
+					     REGULATOR_DEF_UV_LESS_CRITICAL_WINDOW_MS);
 
 	constraints->soft_start = of_property_read_bool(np,
 					"regulator-soft-start");
@@ -313,11 +310,10 @@ static int of_get_regulation_constraints(struct device *dev,
 				"regulator-suspend-max-microvolt", &pval))
 			suspend_state->max_uV = pval;
 
-		if (!of_property_read_u32(suspend_np,
-					"regulator-suspend-microvolt", &pval))
-			suspend_state->uV = pval;
-		else /* otherwise use min_uV as default suspend voltage */
-			suspend_state->uV = suspend_state->min_uV;
+		/* Use min_uV as default suspend voltage if fail to get property */
+		suspend_state->uV =
+			of_property_read_u32_default(suspend_np, "regulator-suspend-microvolt",
+						     suspend_state->min_uV);
 
 		if (of_property_read_bool(suspend_np,
 					"regulator-changeable-in-suspend"))

-- 
2.37.1


  parent reply	other threads:[~2026-01-19  2:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19  2:02 [PATCH 0/5] of: Introduce *_read_*_default helpers and convert regulator drivers Peng Fan (OSS)
2026-01-19  2:02 ` [PATCH 1/5] of: Add of_property_read_[u32,s32]_default Peng Fan (OSS)
2026-01-20 22:21   ` Rob Herring
2026-01-23  6:58     ` Peng Fan
2026-01-19  2:02 ` Peng Fan (OSS) [this message]
2026-01-19  2:02 ` [PATCH 3/5] regulator: adp5055: use of_property_read_[u32|s32]_default() Peng Fan (OSS)
2026-01-19  2:02 ` [PATCH 4/5] regulator: max77620: Use of_property_read_u32_default() for DT parsing Peng Fan (OSS)
2026-01-19  2:02 ` [PATCH 5/5] regulator: fan53555: " Peng Fan (OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260119-add_dt_default-v1-2-db4787ea7a9e@nxp.com \
    --to=peng.fan@oss.nxp.com \
    --cc=alexisczezar.torreno@analog.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=robh@kernel.org \
    --cc=saravanak@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®