From: "Michal Koutný" <mkoutny@suse.com>
To: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>
Cc: linux-kernel@vger.kernel.org, "Michal Koutný" <mkoutny@suse.com>
Subject: [PATCH 2/3] sched/rt: Move group schedulability check to sched_rt_global_validate()
Date: Mon, 19 Jan 2026 18:41:20 +0100 [thread overview]
Message-ID: <20260119-sched-rert_groups-v1-2-80c1e5269910@suse.com> (raw)
In-Reply-To: <20260119-sched-rert_groups-v1-0-80c1e5269910@suse.com>
The sched_rt_global_constraints() function is a remnant that used to set
up global RT throttling but that is no more since commit 5f6bd380c7bdb
("sched/rt: Remove default bandwidth control") and the function ended up
only doing schedulability check.
Move the check into the validation function where it fits better.
(The order of validations sched_dl_global_validate() and
sched_rt_global_validate() shouldn't matter.)
Signed-off-by: Michal Koutný <mkoutny@suse.com>
---
kernel/sched/rt.c | 21 +++++++++++----------
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 2dfdf2d9471be..c621e61568359 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -2810,15 +2810,7 @@ long sched_group_rt_period(struct task_group *tg)
#ifdef CONFIG_SYSCTL
static int sched_rt_global_constraints(void)
{
- int ret = 0;
- if (!rt_group_sched_enabled())
- return ret;
-
- mutex_lock(&rt_constraints_mutex);
- ret = __rt_schedulable(NULL, 0, 0);
- mutex_unlock(&rt_constraints_mutex);
-
- return ret;
+ return 0;
}
#endif /* CONFIG_SYSCTL */
@@ -2850,7 +2842,16 @@ static int sched_rt_global_validate(void)
NSEC_PER_USEC > max_rt_runtime)))
return -EINVAL;
- return 0;
+ int ret = 0;
+#ifdef CONFIG_RT_GROUP_SCHED
+ if (!rt_group_sched_enabled())
+ return ret;
+
+ mutex_lock(&rt_constraints_mutex);
+ ret = __rt_schedulable(NULL, 0, 0);
+ mutex_unlock(&rt_constraints_mutex);
+#endif
+ return ret;
}
static void sched_rt_do_global(void)
--
2.52.0
next prev parent reply other threads:[~2026-01-19 17:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 17:41 [PATCH 0/3] sched/rt: Fix schedulable check with rt_group_sched=0 and cleanups Michal Koutný
2026-01-19 17:41 ` [PATCH 1/3] sched/rt: Skip group schedulable check with rt_group_sched=0 Michal Koutný
2026-01-19 17:41 ` Michal Koutný [this message]
2026-02-11 7:57 ` [PATCH 2/3] sched/rt: Move group schedulability check to sched_rt_global_validate() K Prateek Nayak
2026-01-19 17:41 ` [PATCH 3/3] sched/rt: Cleanup global RT bandwidth functions Michal Koutný
2026-02-02 14:13 ` [PATCH 0/3] sched/rt: Fix schedulable check with rt_group_sched=0 and cleanups Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260119-sched-rert_groups-v1-2-80c1e5269910@suse.com \
--to=mkoutny@suse.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®