From: jongan.kim@lge.com
To: aliceryhl@google.com
Cc: arve@android.com, brauner@kernel.org, cmllamas@google.com,
gregkh@linuxfoundation.org, heesu0025.kim@lge.com,
ht.hong@lge.com, jongan.kim@lge.com, jungsu.hwang@lge.com,
kernel-team@android.com, linux-kernel@vger.kernel.org,
sanghun.lee@lge.com, seulgi.lee@lge.com, sunghoon.kim@lge.com,
tkjos@android.com
Subject: Re: [PATCH RESEND] binder: handle PID namespace conversion for freeze operation
Date: Mon, 19 Jan 2026 09:56:07 +0900 [thread overview]
Message-ID: <20260119005607.11352-1-jongan.kim@lge.com> (raw)
In-Reply-To: <aWoYeQcg-OYcglIf@google.com>
Alice Ryhl @ 2026-01-16 10:52 UTC wrote:
> On Fri, Jan 16, 2026 at 02:52:22PM +0900, jongan.kim@lge.com wrote:
> > Alice Ryhl @ 2026-01-15 8:41 UTC wrote:
> > > On Thu, Jan 15, 2026 at 05:06:19PM +0900, jongan.kim@lge.com wrote:
> > > > As Alice mentioned, since only the freeze operation takes a pid as input, it
> > > > receives the local pid of the namespace. This patch converts this pid to the
> > > > global pid of the init namespace for matching pid of binder_procs properly.
> > > > (binder_procs has `task->group_leader->pid`). Are there any concerns or
> > > > problems for this logic?
> > >
> > > This isn't new with your changes ... but it does have a race where the
> > > target process dies and gets replaced by a new process with the same pid
> > > just before you invoke the freeze ioctl.
> >
> > Thanks for sharing! Has this issue been encountered before? I think there may
> > be a potential problem, although it is very unlikely to occur. (It is also very
> > hard to fix and verify the problem I guess...)
> > For now I want to focus on the patch submitted regarding the PID namespace on
> > this thread. Please check if there are any issues with merging this patch into
> > the binder driver.
>
> I do think it makes sense for freeze to convert pids like this. The Rust
> driver should also be updated with the same change at the same time.
Thanks for confirmation. I will update the patch after changing and verifying
the rust driver.
Thanks. // JongAn, Kim
next prev parent reply other threads:[~2026-01-19 1:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 2:41 [PATCH] " jongan.kim
2026-01-08 1:10 ` [PATCH RESEND] " jongan.kim
2026-01-08 5:37 ` Greg KH
[not found] ` <696087cf.050a0220.9a5fe.0a86SMTPIN_ADDED_BROKEN@mx.google.com>
2026-01-09 7:50 ` Greg KH
2026-01-09 8:39 ` Alice Ryhl
2026-01-15 8:06 ` jongan.kim
2026-01-15 8:41 ` Alice Ryhl
2026-01-16 5:52 ` jongan.kim
2026-01-16 10:52 ` Alice Ryhl
2026-01-19 0:56 ` jongan.kim [this message]
2026-01-09 4:44 ` jongan.kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260119005607.11352-1-jongan.kim@lge.com \
--to=jongan.kim@lge.com \
--cc=aliceryhl@google.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heesu0025.kim@lge.com \
--cc=ht.hong@lge.com \
--cc=jungsu.hwang@lge.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sanghun.lee@lge.com \
--cc=seulgi.lee@lge.com \
--cc=sunghoon.kim@lge.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®