From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 945E01494DB for ; Mon, 19 Jan 2026 23:49:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768866588; cv=none; b=MB83Qtld/BkJ8UXFA6TFoins+q+x9JqZYqLSLUfbB7WyS3PLqHJEBnbUs4mb5+fhlC4LejsR02euOa7oUlXPV5ko/kLGPr5WSx0o32jT42GVjCBvlHUglkWX2S7niNtjUZpuwfDA/asOlfOgr7WyXjtxoY5AMB3zVopqmX7sYk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768866588; c=relaxed/simple; bh=dl4NfLFLRXwMEPRJZE/eVHiegg6qB2fc1iGd20FqEkA=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=sJtJHExLWiCAoccos7wgO2nD7VDehYcC6wpRb3mLvwLx74+6JFzaxwmihh+/5mGX4vhV/RtxifxE7iJka6Z0XBOITJh87aAHYOi4VTj8M7QW1JXVF707Hbw/r0S8yGTv0p1+7lTVGTSVN8WJmzToM0jjbbabz0jiNpycTpqv3v0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=F1sdcYr4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="F1sdcYr4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5FF6C116C6; Mon, 19 Jan 2026 23:49:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1768866588; bh=dl4NfLFLRXwMEPRJZE/eVHiegg6qB2fc1iGd20FqEkA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=F1sdcYr41mj7u5GNBeON6roRdsjj9MA61KysbE5ZD0+DK7Gx8H4LEGBOPzjEDXih9 6zBnK2Zno4pcDfzPJ8jqL/kbTeXssZm3huJStpAl+ROSzJl3JMl0ZNBTBXmuAm9s6H 6JqxjQp+CLsr9IHQWqdk118THRMnnCRGDZfQLvvc= Date: Mon, 19 Jan 2026 15:49:47 -0800 From: Andrew Morton To: Qiang Ma Cc: bhe@redhat.com, catalin.marinas@arm.com, will@kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] kexec: add kexec flag to control debug printing Message-Id: <20260119154947.e351bfb8e97d91305932e2eb@linux-foundation.org> In-Reply-To: <20251219093134.2268620-1-maqianga@uniontech.com> References: <20251219093134.2268620-1-maqianga@uniontech.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 19 Dec 2025 17:31:30 +0800 Qiang Ma wrote: > The commit cbc2fe9d9cb2 ("kexec_file: add kexec_file flag to control > debug printing") added the kexec_file flag to control debug printing. > However, for arm64, after commit 6f8c1da071a4 ("kexec_file, arm64: print > out debugging message if required"), when using the kexec_load interface, > the kexec_image_info function is called to print debug message, but > it uses kexec_dprintk, which is only available under kexec_file, > then when specifying 'kexec -d', kexec_load interface will print nothing. > > For riscv, commit eb7622d908a09 ("kexec_file, riscv: print out debugging > message if required") remove kexec_image_info(), because the content has > been printed out in generic code in kexec_file_load, but not in kexec_load. > > Therefore, in order to solve the two problems mentioned above, for this > patchset, several things need to be done: > > 1. Enabling kexec_dprintk is available for kexec_load. > 2. Add some debugging message of the deleted kexec_image_info > to generic code. > 3. Remove duplicate debugging prints for arm64. Some additional review input on this series would be good, if someone has the time.