From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DB5E26E6E8 for ; Mon, 19 Jan 2026 16:59:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768841995; cv=none; b=cm8jzFn4IvjNxNt0NwNPvZom2Vx+80jXxAtwzfDeWOw3TExuMRNLFkDmnY5YUm/qoQ1yZ2jpF3DpxgNLxpZ+78Cnr1DVlgV3aQ0CldqrZHsIVJHypK1Q2mlgnQ7WJuLzoacnRLoU7BlhOVlqMxqgl+asdfJ9bhqzLXtt1RgJQUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768841995; c=relaxed/simple; bh=bhDzKe3hBaMep6hb4Ruwhdat9qUjuZInlAgPSftgqs8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T2Apnz6aSIdRfBMqrpRcQ49nlDYbTfJ0+b+Fby3A268CcgM9jZFblpZvES7wCTH6QJ886VrlVNd03aREKaR5oaLh6YYr87twMkLLKKRSPyspmxYV30oKkVQOGa5sUQtszGBywyIjd/qNdbV3pWlPwcY0LWLtfQPqa6/c6xqGJaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=PcdR0EK4; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="PcdR0EK4" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-50143fe869fso51901041cf.1 for ; Mon, 19 Jan 2026 08:59:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1768841992; x=1769446792; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=TPsA7s1a/5IQbuetD0KLnhoW9jbCMPzN3lJpfuVRncw=; b=PcdR0EK43JTx60gis7CFG3xkG/NxLT5THwvgfbiJvSZZ5OLMwewfa5seKHPFfJ59W6 ++EalUij4O7QvK7DVAsbqXikrhQnP54gv4aD9zMUy70Mwiqwvwg/S1guw9n/L+ORoBqa cFSQYnafWkvrpgiMFogqwcqDgIwtX8qk/jjG0oMFehi4NAEC6Nc0ahhq907bxw09MwGY s5yrqryAgTqoErepfDtJA7QvdEzqu6gio4mVCC5X+M292/Vsu/OYK+MZv3hcRsvGjKLk kvOEh5eTxnR+68YNdRvNq1mZCqAEoCk+mW63/bYvN/K5sO+eA9WfQn42b1+DRxQ076d2 WtNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768841992; x=1769446792; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TPsA7s1a/5IQbuetD0KLnhoW9jbCMPzN3lJpfuVRncw=; b=FN5e4PmPWU1DwedPlpU8l+/d1s9vHFoiRzleqS74kloX7nVutFIAWETN8DA9d9vOcD Av3qiKkXPioANjdTUIOrX1v9Iifd/DADNINo5tF6OKHGEe4wNL+XjH2I3Bdi0rZkz/1Z W1AsP+pZYcsIOzZZ4v+3KkKcDtZ2kDDiH6ggFxj6q1c8DjuWTB0IfsNZAjTrXIcwgIvT r3MlY9Ifr/nIKrxg9403LGw3KRxAgvmg/TlwMMenqsJTTuqwLeijJ9KL2xiDCcTvAEDY h00l7THkJn69uLAzkAZwtFj/7Fp32fSH/EGiS+77OQtf65FtmkJg+kz7SGd+fN9zYqPB O3Rw== X-Forwarded-Encrypted: i=1; AJvYcCV8vREhAOYCKWTjbDpmRs+d9QxCDnOR+ZfzxhtIKx4awLoik/JY+hkQry6WZeIVhZVvvxT0f3Tu+7E86K4=@vger.kernel.org X-Gm-Message-State: AOJu0YzOm/QMOc8DEAkSfWSCKt0yz4sLENxNUJY52J3mRj6A6z5qZGbG HafBqQyq7LMxmWFSfxJyJ8ze9K7SM/zpZTZKRYjgYdSGVf5gbRY5NiKvn8/OGeZgk5I= X-Gm-Gg: AY/fxX6h7gsiillz6KLN9ieMGKhQQwdf1khY9tvPks+cwVx+1BldtKAI0UBCLTJiu7s nmxgEYdbMsM49tFolktOEvTmZzLc6O3sXkhn+c0t8TGRrpmkm5MALgiyhRn5M0PQNR5v0cUl8CA LU2rOu4a4p+hxk03NtxTI4pCwwW7zBKfJZxUIsKhOlkuC8wfvbNJ1ZiSq9dCW6CeSmhSBoKzK/9 Ynyf7W8fJFBMoz3Uou1100ErhNIWj7aV+L7Mubbngo2+1m8GYU8AJJBSFXmpsw588FBp4nZ+gyO bhr4+8ZmuGf05+DmihHL/bhK1YP3SWLYiszCzBk6b/UM9ZFeoDiU/ThiFIozBhPPDgPIEmGMJ3A RF6EUuzPOBFR8UpdbSDAxbjdIPgP7G35pBBVwpAdZSK7oLLQJe6+6HN9Nm3GZ1XGxEmp4q1BfOh +PByxg+ckziTVBPI2tLzi/va7UidmAjOWd7Rf0BapkPw7PZdS/kKl+uvdn89V6FlpkMKo= X-Received: by 2002:ac8:7f56:0:b0:501:50cd:cd3a with SMTP id d75a77b69052e-502a16b363amr184663241cf.43.1768841992288; Mon, 19 Jan 2026 08:59:52 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8942e5e4d79sm93947786d6.2.2026.01.19.08.59.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 08:59:51 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vhsbX-00000005IQz-1QSu; Mon, 19 Jan 2026 12:59:51 -0400 Date: Mon, 19 Jan 2026 12:59:51 -0400 From: Jason Gunthorpe To: Leon Romanovsky Cc: Sumit Semwal , Christian =?utf-8?B?S8O2bmln?= , Alex Deucher , David Airlie , Simona Vetter , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lucas De Marchi , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , Rodrigo Vivi , Kevin Tian , Joerg Roedel , Will Deacon , Robin Murphy , Alex Williamson , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org Subject: Re: [PATCH v2 3/4] iommufd: Require DMABUF revoke semantics Message-ID: <20260119165951.GI961572@ziepe.ca> References: <20260118-dmabuf-revoke-v2-0-a03bb27c0875@nvidia.com> <20260118-dmabuf-revoke-v2-3-a03bb27c0875@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260118-dmabuf-revoke-v2-3-a03bb27c0875@nvidia.com> On Sun, Jan 18, 2026 at 02:08:47PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > IOMMUFD does not support page fault handling, and after a call to > .invalidate_mappings() all mappings become invalid. Ensure that > the IOMMUFD DMABUF importer is bound to a revoke‑aware DMABUF exporter > (for example, VFIO). > > Signed-off-by: Leon Romanovsky > --- > drivers/iommu/iommufd/pages.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/iommufd/pages.c b/drivers/iommu/iommufd/pages.c > index 76f900fa1687..a5eb2bc4ef48 100644 > --- a/drivers/iommu/iommufd/pages.c > +++ b/drivers/iommu/iommufd/pages.c > @@ -1501,16 +1501,22 @@ static int iopt_map_dmabuf(struct iommufd_ctx *ictx, struct iopt_pages *pages, > mutex_unlock(&pages->mutex); > } > > - rc = sym_vfio_pci_dma_buf_iommufd_map(attach, &pages->dmabuf.phys); > + rc = dma_buf_pin(attach); > if (rc) > goto err_detach; > > + rc = sym_vfio_pci_dma_buf_iommufd_map(attach, &pages->dmabuf.phys); > + if (rc) > + goto err_unpin; > + > dma_resv_unlock(dmabuf->resv); > > /* On success iopt_release_pages() will detach and put the dmabuf. */ > pages->dmabuf.attach = attach; > return 0; Don't we need an explicit unpin after unmapping? Jason