From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org
Cc: Juergen Gross <jgross@suse.com>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
kernel test robot <lkp@intel.com>
Subject: [PATCH v4 1/6] x86/irqflags: Fix build failure
Date: Mon, 19 Jan 2026 19:26:27 +0100 [thread overview]
Message-ID: <20260119182632.596369-2-jgross@suse.com> (raw)
In-Reply-To: <20260119182632.596369-1-jgross@suse.com>
Commit 22cc5ca5de52 ("x86/paravirt: Move halt paravirt calls under
CONFIG_PARAVIRT") moved some paravirt hooks from the CONFIG_PARAVIRT_XXL
umbrella to CONFIG_PARAVIRT, but missed to move the associated
"#include <asm/paravirt.h>" in irqflags.h from CONFIG_PARAVIRT_XXL to
CONFIG_PARAVIRT.
This hasn't resulted in build failures yet, as all use cases of
irqflags.h had paravirt.h included via other header files, even without
CONFIG_PARAVIRT_XXL being set.
In order to allow changing those other header files, e.g. by no longer
including paravirt.h, fix irqflags.h by moving inclusion of paravirt.h
under the CONFIG_PARAVIRT umbrella.
Fixes: 22cc5ca5de52 ("x86/paravirt: Move halt paravirt calls under CONFIG_PARAVIRT")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202601152203.plJOoOEF-lkp@intel.com/
Signed-off-by: Juergen Gross <jgross@suse.com>
---
V4:
- merge into slow_io series as prereq patch (Boris Petkov)
- rewrite commit message (Boris Petkov)
---
arch/x86/include/asm/irqflags.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h
index a1193e9d65f2..4d4d02e31287 100644
--- a/arch/x86/include/asm/irqflags.h
+++ b/arch/x86/include/asm/irqflags.h
@@ -96,11 +96,11 @@ static __always_inline void halt(void)
native_halt();
}
#endif /* __ASSEMBLY__ */
+#else
+#include <asm/paravirt.h>
#endif /* CONFIG_PARAVIRT */
-#ifdef CONFIG_PARAVIRT_XXL
-#include <asm/paravirt.h>
-#else
+#ifndef CONFIG_PARAVIRT_XXL
#ifndef __ASSEMBLER__
#include <linux/types.h>
--
2.52.0
next prev parent reply other threads:[~2026-01-19 18:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 18:26 [PATCH v4 0/6] x86: Cleanups around slow_down_io() Juergen Gross
2026-01-19 18:26 ` Juergen Gross [this message]
2026-03-21 15:47 ` [tip: x86/cleanups] x86/irqflags: Preemptively move include paravirt.h directive where it belongs tip-bot2 for Juergen Gross
2026-03-22 7:47 ` tip-bot2 for Juergen Gross
2026-01-19 18:26 ` [PATCH v4 2/6] x86/paravirt: Replace io_delay() hook with a bool Juergen Gross
2026-03-21 15:47 ` [tip: x86/cleanups] " tip-bot2 for Juergen Gross
2026-03-22 7:46 ` tip-bot2 for Juergen Gross
2026-01-19 18:26 ` [PATCH v4 3/6] block/floppy: Don't use REALLY_SLOW_IO for delays Juergen Gross
2026-03-21 15:47 ` [tip: x86/cleanups] " tip-bot2 for Juergen Gross
2026-03-22 7:46 ` tip-bot2 for Juergen Gross
2026-01-19 18:26 ` [PATCH v4 4/6] x86/io: Remove REALLY_SLOW_IO handling Juergen Gross
2026-03-26 8:39 ` Juergen Gross
2026-03-26 10:04 ` Borislav Petkov
2026-03-26 10:23 ` Jürgen Groß
2026-01-19 18:26 ` [PATCH v4 5/6] x86/io_delay: Switch io_delay() default mechanism to "none" Juergen Gross
2026-03-20 22:02 ` Borislav Petkov
2026-03-21 6:29 ` Jürgen Groß
2026-03-21 11:32 ` Borislav Petkov
2026-01-19 18:26 ` [PATCH v4 6/6] x86/io_delay: Add config option for controlling build of io_delay Juergen Gross
2026-02-02 10:27 ` [PATCH v4 0/6] x86: Cleanups around slow_down_io() Juergen Gross
2026-02-09 9:11 ` Juergen Gross
2026-02-09 10:19 ` Borislav Petkov
2026-03-11 9:16 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260119182632.596369-2-jgross@suse.com \
--to=jgross@suse.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox