From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B62E12DC32A for ; Mon, 19 Jan 2026 19:53:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768852413; cv=none; b=EPf7NA6p6A0yxnU4BASRfHt+Cx+7dZQInesqFmo3LzipraYPzxghwGz/WrpnCccn40A7bOsFEbd4M9wCLNHRzk1QIrADSGFo6OapRsgvPh0nx0XZv6wiDEM6X/Jz+QfxrxuaDWvWX8iLuEX/UHGCg7mdpOJshHl542FS0/pfSsc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768852413; c=relaxed/simple; bh=rqoI5uyocgM27IONRP5gEmMX8bQQMYkjatu0IrsfKxs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pSejrzI6RFV6ZEpuL2rIUwmGeBuZm3PFax1AZ/JfqlB0q7snpX+QHZrDrmTDjmWR9ZXeRfO/mE3HkzQPXKjX0o0G2sVGq5NiTh1jNSWmM5ZA998abb4VDrEFKzqvqqcH+S4LB392PIWTA7/RJFnOvAOat+DybNP5rTw0nwJjDo4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=gLfA7C75; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="gLfA7C75" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-8c52c67f64cso493321685a.0 for ; Mon, 19 Jan 2026 11:53:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1768852411; x=1769457211; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Auqm2oRMuolYRtJcTB8WdTd3/j+UhJ4pFiILLt/xjHA=; b=gLfA7C75kJ1AORdn59L5v/+OpVs9328RBbGGoDIgG4wotmEAIL65SP/befkYCowaBB JXQ3bRVTzBvH17THMUlWW0klp4185HZTz+9odcBnr0t3+NOBpr9fB8WwITRVrChaj/fR BJNATmI/GK7A+Uu2s+UYnyUW76119b20DEGQ3OAyIOPSt9teQYMTnvMj3xX2zbbmCzW3 MJNOJCEXhc77O7E3cD8h1WeD3jOOFG0xiYrDPGy6lv5ja5T+wVx/kOZHY3CpU0SzFN0L JFGaaqYt5t9MYv63UEZxe5eYZi0gTjsJ2FkGaqtuHjW0oigeD5ykGMAYyanHalfHJ7TT iAcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768852411; x=1769457211; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Auqm2oRMuolYRtJcTB8WdTd3/j+UhJ4pFiILLt/xjHA=; b=l4oRORb8dfs9zUeSkB2Zeo6U4Z9/cWjGzHdrHaJk+YXQIdZ4Fv3B+xLUwldPb0UbL/ Ws86MuVs3ZDkkNzRsHxOzFto7VOfVGe1OBr9ikGsWZiRAcmjT47wc0Bfwi6K9G4ga15B Q12hos8YkyYUa+QljUdp4f+ZMSH+KQ5iMR8RjJ2AOz/o1AZqPoX2I5IBaJz7ekgf8z01 QHQX3gew/+Z/+Bs5e+H6OMGWJUwssGXY+ReUeasXGMdbQSy7tU8SFpvW/izGoejvD4LV +6pEAnI9PqIgn+FEmaJ7SYhOcEs3zaoeET3Dhd1gLEZRIdlin8DW9o/QJ/y2vb5fQM1f jeVg== X-Forwarded-Encrypted: i=1; AJvYcCXpCHHJ20MnNL8Xv05bnzBb/Fpre5/C6oUKMZAHKUKA2pGpaEVf2hBZyxqyq/H0a/iWZs0+yQ8YEDvldD0=@vger.kernel.org X-Gm-Message-State: AOJu0YzY97L2KZbktSz9c2ksQc3ZH1mGO4bAM6cMboARMf9e970HpgFU 8hxFsQWkW1jSWh3tIid7nL5BTf+lASRU6ejobA1zJXIMjuAbVNBZ6RJIZDUDqRNKwxo= X-Gm-Gg: AY/fxX74oLigPY5qJSn2O1CjL7wsR9f2ixwjJZRMOK3kV/5NYnpZPOprkAZDJh2d834 Mk8Xek2iaGyqoUUFydnIM4mEsD/iwslL2ZM6w0P6ngxu2TifWf939ttwz0mAVWeO0g6qNWXI9Dy +JXNkbSSy0xaDT7vnyFKxL+2SCzcBefegwYse5DMarnFVpZQaj5siNiWeBegAnmzysRCx0hl53q MZDFzw9sHAFlt+4aXc3NMZn87jIYjkI4bH7hwm2rJdUA7cQ+T/zDdJYfyQrDYagmrFsvAKZ/rp1 tf02sYcZnxuA915eDoARd+NOyP0vt5eS1EpXo9IqzLfauuJsmO8bs0cB+IfdnA7DvS9WI8ZhGPN aw1izzD2XAJ69C3+p27zEWyk6NyIC+vjQzBP4OypHruqrcTK97eV8/RlcT7vzNtczZtIVfodO2b r75UcM5maX4ufRBSCNbWKyGBDe+hbtOpbO1E3qB9CHQ4RiXw+IjM+6wTMIB+HEmkYJIA4= X-Received: by 2002:a05:620a:178d:b0:848:81e5:446e with SMTP id af79cd13be357-8c6a67a1249mr1427854285a.72.1768852410680; Mon, 19 Jan 2026 11:53:30 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c6a71ab272sm873214885a.2.2026.01.19.11.53.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 11:53:30 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vhvJZ-00000005JQ9-1uZH; Mon, 19 Jan 2026 15:53:29 -0400 Date: Mon, 19 Jan 2026 15:53:29 -0400 From: Jason Gunthorpe To: Sharath Srinivasan Cc: Leon Romanovsky , Parav Pandit , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH rdma-next] RDMA/core: release devices_rwsem when calling device_del Message-ID: <20260119195329.GK961572@ziepe.ca> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jan 19, 2026 at 11:43:52AM -0800, Sharath Srinivasan wrote: > The sync strategy in remove_all_compat_devs() can improved > by adopting that of rdma_dev_exit_net() which releases devices_rwsem > before calling remove_one_compat_dev()/device_del(). > > Also fixes a comment typo in rdma_dev_exit_net(). You cannot change this locking without writing a huge commit message explaining in detail the reason why any change like this is safe.. Jason