mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Petr Hodina <petr.hodina@protonmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"David Heidelberg" <david@ixit.cz>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/3] doc: add Device Tree binding for AMS TCS3400 light sensor
Date: Tue, 20 Jan 2026 11:37:22 +0100	[thread overview]
Message-ID: <20260120-nifty-hasty-ibex-aff3cc@quoll> (raw)
In-Reply-To: <20260119-tsc3400-v1-1-82a65c5417aa@protonmail.com>

On Mon, Jan 19, 2026 at 06:19:06PM +0100, Petr Hodina wrote:
> Adds a new YAML binding describing the AMS TCS3400 I2C light sensor,
> including compatible string, registers, interrupts, power supply, and an
> example node.
> 
> Signed-off-by: Petr Hodina <petr.hodina@protonmail.com>
> ---
>  .../devicetree/bindings/iio/light/ams,tcs3400.yaml | 54 ++++++++++++++++++++++
>  MAINTAINERS                                        |  6 +++
>  2 files changed, 60 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/ams,tcs3400.yaml b/Documentation/devicetree/bindings/iio/light/ams,tcs3400.yaml
> new file mode 100644
> index 000000000000..2c5a9295af1a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/ams,tcs3400.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/iio/light/ams,tcs3400.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

Never tested.

> +
> +title: AMS TCS3400 Color Light-to-Digital Converter
> +
> +maintainers:
> +  - name: Petr Hodina
> +    email: petr.hodina@protonmail.com

Don't send us LLM code. Never. Why do I think you sent us LLM microslop?
Because such syntax does not exist. Nowhere.

I finished the review here, everything futher has more trivial issues
which you would fix easily if you took recent binding as starting point.

Best regards,
Krzysztof


  parent reply	other threads:[~2026-01-20 10:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19 17:19 [PATCH 0/3] iio: light: add AMS TCS3400 driver Petr Hodina via B4 Relay
2026-01-19 17:19 ` [PATCH 1/3] doc: add Device Tree binding for AMS TCS3400 light sensor Petr Hodina via B4 Relay
2026-01-19 17:37   ` David Heidelberg
2026-01-20 10:37   ` Krzysztof Kozlowski [this message]
2026-01-20 10:38   ` Krzysztof Kozlowski
2026-01-20 14:09   ` Daniel Baluta
2026-01-19 17:19 ` [PATCH 2/3] iio: light: add AMS TCS3400 RGB and RGB-IR color sensor driver Petr Hodina via B4 Relay
2026-01-19 18:58   ` Andy Shevchenko
2026-01-20 10:06   ` kernel test robot
2026-01-20 11:03   ` Konrad Dybcio
2026-01-20 13:33     ` Andy Shevchenko
2026-01-20 13:51       ` phodina
2026-01-20 13:58         ` Konrad Dybcio
2026-01-20 11:32   ` kernel test robot
2026-01-23  9:11   ` Jonathan Cameron
2026-01-19 17:19 ` [PATCH 3/3] sdm845: tama: Add AMS TCS3400 ambient light sensor Petr Hodina via B4 Relay
2026-01-19 17:33   ` David Heidelberg
2026-01-20 11:06   ` Konrad Dybcio
2026-01-20 19:49 ` [PATCH 0/3] iio: light: add AMS TCS3400 driver Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260120-nifty-hasty-ibex-aff3cc@quoll \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=petr.hodina@protonmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®