mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Desobry <david.desobry@formalgen.com>
To: tglx@kernel.org, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com
Cc: x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
	David Desobry <david.desobry@formalgen.com>
Subject: [PATCH] x86/lib: Fix num_digits() signed overflow for INT_MIN
Date: Tue, 20 Jan 2026 10:42:58 +0100	[thread overview]
Message-ID: <20260120094258.41313-1-david.desobry@formalgen.com> (raw)

In num_digits(), the negation of the input value "val = -val"
causes undefined behavior when val is INT_MIN, as its absolute
value cannot be represented as a signed 32-bit integer.

This leads to incorrect results (returning 2 instead of 11).
By promoting the value to long long before negation, we ensure
the absolute value is correctly handled.

Signed-off-by: David Desobry <david.desobry@formalgen.com>
---
 arch/x86/lib/misc.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/x86/lib/misc.c b/arch/x86/lib/misc.c
index 40b81c338ae5..c975db6ccb9f 100644
--- a/arch/x86/lib/misc.c
+++ b/arch/x86/lib/misc.c
@@ -8,15 +8,16 @@
  */
 int num_digits(int val)
 {
+	long long v = val;
 	long long m = 10;
 	int d = 1;
 
-	if (val < 0) {
+	if (v < 0) {
 		d++;
-		val = -val;
+		v = -v;
 	}
 
-	while (val >= m) {
+	while (v >= m) {
 		m *= 10;
 		d++;
 	}
-- 
2.43.0


             reply	other threads:[~2026-01-20 10:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-20  9:42 David Desobry [this message]
2026-01-20 16:23 ` H. Peter Anvin
2026-01-20 16:40   ` Borislav Petkov
2026-01-20 18:02     ` H. Peter Anvin
2026-01-20 18:17       ` H. Peter Anvin
2026-01-20 19:16         ` Borislav Petkov
2026-01-20 19:50           ` H. Peter Anvin
2026-01-20 20:13             ` Borislav Petkov
2026-01-21 10:59               ` David Laight
     [not found]           ` <14738799-afb2-428b-9829-f1ed038f3872@formalgen.com>
2026-01-20 20:24             ` H. Peter Anvin
2026-01-20 21:22               ` Borislav Petkov
2026-01-20 21:21             ` Borislav Petkov
2026-01-20 17:48   ` David Desobry
2026-01-20 22:15     ` David Laight
2026-01-20 18:58   ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260120094258.41313-1-david.desobry@formalgen.com \
    --to=david.desobry@formalgen.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®