From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DC793254A0; Tue, 20 Jan 2026 15:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768923623; cv=none; b=aj+3VDbedCseC3iuMTXqewfWFuJp7CBupq10f5zQokmegR933GpAMTRW4t1jTB8FUtydQlxrko0z+9asgfruXz9U9pcs/vYB3KT8ZL/P9vHJ6Hy1j+BDxJbg++KAYscjp+bIydF0U9JfgcO4YNw8KXOoIHI6baKI+uVLYFk9sVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768923623; c=relaxed/simple; bh=JDDqSwYFPFdNPo+wfJrfkyuC39HEgDEVEXAsS2iGrgA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MjhUpBuurOTXLeWblwqLDVM6X56NthBhKhjya/om5qowseXIrkwxC5ATU58WrIcXHU49etGb2ou6yCtthmgHkCRLWwRLiv4+Krq9/9wl3lWiyCFmG+f9Bj6FfKVKIRW9SC9jGyNZPXDZDPOwU4FKFlQLgXJ2yxLEcfCohMnZrEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GdcaY16e; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GdcaY16e" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768923622; x=1800459622; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=JDDqSwYFPFdNPo+wfJrfkyuC39HEgDEVEXAsS2iGrgA=; b=GdcaY16eHU7NX/jqnjYLlDRmryQQw7rWGp36jA6EKvmlVcloHt7SBXBi Mckx5WcvY7UNrczeQC9wmFsdgmH8ma8wP8G1zVo1reFK6VzmsYHC3hDAA cLxjc9Jf4EK+ztUJUGjXv9bmwHv9N3A6+MVxWyBJohQ2UEe3wZcMUs6/J CxMZveB14E/ZCvYj2txBcEZNpdQQlRdl7AUmIK3hs/rDcuI7EBB0xG0QA k6wSAvah2Xg2lrtYy0U45RwzZhuQSoh8IV6KQqqJFt/Yehdus372z+HQ1 5gg3rNvJJhxPnjj7QQiFl0l1COkQyK4BC6Ef8WXiTK+t0XheAJPKsH0kD A==; X-CSE-ConnectionGUID: BjZropz9Q4iXRdTaBqwRRA== X-CSE-MsgGUID: yKwLFdLcSPi86/rQ7hpVFA== X-IronPort-AV: E=McAfee;i="6800,10657,11677"; a="74003571" X-IronPort-AV: E=Sophos;i="6.21,240,1763452800"; d="scan'208";a="74003571" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2026 07:40:21 -0800 X-CSE-ConnectionGUID: dPmelVMISu2HqsQy/FSosg== X-CSE-MsgGUID: aWIltVHTQt+32AFN/1ZsPw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,240,1763452800"; d="scan'208";a="237410797" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa001.fm.intel.com with ESMTP; 20 Jan 2026 07:40:18 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 13B3498; Tue, 20 Jan 2026 16:40:18 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown Subject: [PATCH v1 1/1] ACPI: PCI: simplify code with acpi_get_local_u64_address() Date: Tue, 20 Jan 2026 16:40:15 +0100 Message-ID: <20260120154015.1764021-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Now we have a helper so there's no need to open-code. Signed-off-by: Andy Shevchenko --- drivers/acpi/pci_slot.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/acpi/pci_slot.c b/drivers/acpi/pci_slot.c index 741bcc9d6d6a..1053ab4a9681 100644 --- a/drivers/acpi/pci_slot.c +++ b/drivers/acpi/pci_slot.c @@ -42,8 +42,9 @@ static int check_slot(acpi_handle handle, unsigned long long *sun) { int device = -1; - unsigned long long adr, sta; + unsigned long long sta; acpi_status status; + u64 adr; struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL }; acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer); @@ -56,10 +57,9 @@ check_slot(acpi_handle handle, unsigned long long *sun) goto out; } - status = acpi_evaluate_integer(handle, "_ADR", NULL, &adr); - if (ACPI_FAILURE(status)) { - pr_debug("_ADR returned %d on %s\n", - status, (char *)buffer.pointer); + if (acpi_get_local_u64_address(handle, &adr)) + pr_debug("_ADR returned with failure on %s\n", + (char *)buffer.pointer); goto out; } -- 2.50.1