From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6369544BC9E for ; Tue, 20 Jan 2026 14:07:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768918068; cv=none; b=tMr3gAi6hVi4VdIF6PDTVeYJO45zB9sCR8xa8GkOOKOTXp2096zRTHPJM0//xKuBtwlmtEriUwuSE2UaPsKS5liKs0nk2SGzubIJfuWCYAW5GcaxZYZQRrKvMzdXoKQF8E9NBc2lF9kOhZK6ntda9FOJ4Z41pg2Abf4KXPS4/mI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768918068; c=relaxed/simple; bh=SbA2hDa2S5c61CXJw05EMr+AnMS1pi6+xa34NHiQ+HQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hpkKrlA/QX+nZpOtEFPSa0uJ/ovIxhziBQEla6y8tkl9YsFr17wIVdl8hiK+ZukJESFsAZ5g6zV4HI1kKLoFM4q0ZP2tlqhYPimOKUkWus/1J9Zimrcr+PNjyjvXQ3Mz0KmAPZAgvyZtVYsePdcnvlrCXl6qsf/kvtokQMbMVpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=aF/dAc5u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="aF/dAc5u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99891C19422; Tue, 20 Jan 2026 14:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1768918068; bh=SbA2hDa2S5c61CXJw05EMr+AnMS1pi6+xa34NHiQ+HQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aF/dAc5uspHb8J/RH8ZgswQJO4cp4g070fIuCI/QnRaA/0Ouc3hYEFsDRWQV/v6vE iNLIJSboPoPmuxPLQgBgzCWRQ7KUbNWHqjLIwz7F5HVq9xTF6VX954vrXfzJYAyKuu EFhikI/ssWURDTVv3PiaT7JShJKpT7JXIqI+eQA4= Date: Tue, 20 Jan 2026 15:07:45 +0100 From: Greg KH To: Li Nan Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, wanghai38@huawei.com, "yi.zhang@huawei.com" , "yangerkun@huawei.com" Subject: Re: [PATCH v2] char: lp: Fix NULL pointer dereference of cad Message-ID: <2026012055-excretory-afternoon-d123@gregkh> References: <20260108024155.3800149-1-linan666@huaweicloud.com> <2026011644-glimpse-eatery-c556@gregkh> <2026012041-catfight-fetal-9347@gregkh> <7d2eab46-bad4-3e28-50e7-92a34e22ecd8@huaweicloud.com> <2026012049-scroll-smog-edf1@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 20, 2026 at 09:21:11PM +0800, Li Nan wrote: > Do you think we need cleanups/fixes in this driver, or should we wait > for real-world users to encounter issues and discuss them separately? As no one who actually has this hardware has reported anything in the decades that the code has been like this, I would recommend just leaving it as-is. thanks, greg k-h