From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id B254D330650
	for <linux-kernel@vger.kernel.org>; Wed, 21 Jan 2026 11:16:20 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1768994182; cv=none; b=El/RGBGm+wWvEiabF6TALbSi4q1juO+xeN7Tr+19t0rNVTNwqvpmlZMGczg/Zfr4wewzWSzE7v7w2CPKhm/pFEUGajN9Ok2VNYFsqGwmaHGO9StZbIIH98bCfOXUDikBwJ9njdw6BXaOHOtNRal57KBNzTWmMm0L+uO+bl+MDTU=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1768994182; c=relaxed/simple;
	bh=9c+1M4DKoQ7Vr1FAh6mvN4T2TW32I9XT5ET232tS/JM=;
	h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type:
	 Content-Disposition; b=LO6nCnGj6pKcyeFIOSnRas1xpLYU1K6HFDEHwRFbGdKUVlgvMKKLWBur3mKDhop2gQkDD5OXq+uYidvOnV8s0ODrg36wgbEIKXBZv1H704QsD+9HwQZjBwO9QnFUummIE3uK+rvGwwsvBzfonppu1dkWPKFvoGzM+EcEyJ9/29M=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=HjcZmkyL; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=eJAjpf+c; arc=none smtp.client-ip=193.142.43.55
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="HjcZmkyL";
	dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="eJAjpf+c"
Date: Wed, 21 Jan 2026 12:16:17 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1768994179;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type;
	bh=9vdgLI4cVNMO4DdUpeFc8rmpV+Px5mpciPM7KI0NYHE=;
	b=HjcZmkyLOsA5RxlN+By4mVW2Ti5mBrMzyegXZ7LWoGpwUKjXSK+uYStraEYfHB8Veit9db
	MWz46VRrcMo+oV0OSAhqzTJpERrBKjrNWDtd/mvNfbvEn87YNUpiabzaK626xmbh+HHTrc
	Pxay+2wjgqgzYmSLnW7uGwqjlL/S2Xu6Rk3rpkncixWTg6Ud6H6piE3tuZNEws2PzpNVq+
	YNcOPa2ZEgYHHDxWnZ700S0QISC+k6M8HPV+zUm4rtb1cG9Xd+kXMkB5dXMFHBN9ak7+aA
	GQwwWutF5+LPU7RjOCNacIE2orPHowXGPZ8Ivwm7PaJu9qFXv05+0nmv0BStuQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1768994179;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type;
	bh=9vdgLI4cVNMO4DdUpeFc8rmpV+Px5mpciPM7KI0NYHE=;
	b=eJAjpf+cphXkzLOuvLwGYEU29+JoO+8hUbkRhip1+mv/ih+ctn35Ckwo67tand6uHIVMJO
	uxcgvRXBoP2xNzCQ==
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: patches@opensource.cirrus.com, linux-kernel@vger.kernel.org
Cc: Lee Jones <lee@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: request_irq() usage in wm8350_register_irq().
Message-ID: <20260121111617.quQxFcZK@linutronix.de>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline

Hi,

I've been staring wm8350_register_irq(). It does

| request_threaded_irq(irq + wm8350->irq_base, NULL,
| 		handler, flags, name, data);

and every single user passes 0 as flags. This means it asks for a
threaded IRQ and does not pass IRQF_ONESHOT. 

So either this is not working because it triggers the warnings
	Threaded irq requested with handler=NULL and !ONESHOT

followed by -EINVAL _or_ every single user of this driver sits in
system where the irqchip is IRQCHIP_ONESHOT_SAFE marked.
Which is it?

Sebastian