From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25D3A3EFD09
	for <linux-kernel@vger.kernel.org>; Wed, 21 Jan 2026 11:37:01 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1768995423; cv=none; b=qplgRWDetxdgoMnueiobOtDa2v+OamCLLfKN31HXmkftkYSC+69M2HM6p34qIFtOgFNmUDwTR2YW9Mpfhfx6HRNETxnj6u62dUE56exSF5rCMERlvpfBACBhjXHQ1GiWbOf8oPQMPEy8eqkV+qKSGJ6rlhk1jIs3PZNLRE91seM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1768995423; c=relaxed/simple;
	bh=7XH0ryJ6lKdJ7877y1EvBufKce+zqbojYk9NmzRkjHw=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=IPjj7B5EGkYmVPI2zW3rtmXO7UK7EOsaLGXiVIxP6/tVzOFRGtUOsXUNAAUD/gTwdTaMqazimyOBu4c9xYbvWi23aYv4byoUgp2pAglmgJ37EgYklVSaxWNs2z/g+olVjrTL9RFbfX24BDywlwZzFzL9nMAHD/MtDoCNRmRDXRs=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=UxWHCQha; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=t/IJ3f7b; arc=none smtp.client-ip=193.142.43.55
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="UxWHCQha";
	dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="t/IJ3f7b"
Date: Wed, 21 Jan 2026 12:36:59 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1768995420;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Fk7RwZ5BqCvc2JlcGLL84jjIXFy/aWC6gwG0s50V2vo=;
	b=UxWHCQharMF8iXqWLUoB+OuilPj92sqPZ4IOJ7tAyaHPGEVD9l0Lp1fIXkkKmvUh2F+Kkc
	kRK65PNaHBIGNkoIcqGZrKVeksDGZqIZd4NK7eUQq3zgSdJLqlgD2zWYv8xth4Y5qMoTPH
	/LX9KQj8i7A6IVkiFiXpbXQKMVRSTs8o0dXoNZhKE2qx9Z2gEWB5ouRHi7yeD+L4C7kt+V
	9KzjW41H6YHScRMjazdK2ZRTQuq0Vu57PTrmR9x8HgUpZNrkPBMweVxex/qZzhXktVE8hD
	r57IZe8EnZ1QjMcJqwNgRBwzvZn1AlvZiPVJg2lDVkda/jWBRz9IUYo/+Jr7Ig==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1768995420;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Fk7RwZ5BqCvc2JlcGLL84jjIXFy/aWC6gwG0s50V2vo=;
	b=t/IJ3f7bQKlVM21s/Kp5+jUt7JkbIm6HOqdcdv5hUc6myBe2sMhT0f5Lnr2HneYgNn/DDK
	UZ3C7KxOiLzpApBg==
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
	Lee Jones <lee@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: request_irq() usage in wm8350_register_irq().
Message-ID: <20260121113659.CCJtYuQS@linutronix.de>
References: <20260121111617.quQxFcZK@linutronix.de>
 <fbd0ffc0-d308-4064-893b-3c1b51a13a35@opensource.cirrus.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <fbd0ffc0-d308-4064-893b-3c1b51a13a35@opensource.cirrus.com>

On 2026-01-21 11:22:32 [+0000], Richard Fitzgerald wrote:
> Or because request_threaded_irq() supplies a default handler, so
> handler!=3DNULL when it calls __setup_irq().
>=20
>=20
> int request_threaded_irq(unsigned int irq, irq_handler_t handler,
> 			 irq_handler_t thread_fn, unsigned long irqflags,
> 			 const char *devname, void *dev_id)
> {
>=20
> ...
>=20
> 	if (!handler) {
> 		if (!thread_fn)
> 			return -EINVAL;
> 		handler =3D irq_default_primary_handler;
> 	}
>=20
> ...
>=20
>=20
> 	retval =3D __setup_irq(irq, desc, action);
>=20
> ...
> }

->

|         } else if (new->handler =3D=3D irq_default_primary_handler &&
|                    !(desc->irq_data.chip->flags & IRQCHIP_ONESHOT_SAFE)) {
=E2=80=A6
|                 pr_err("Threaded irq requested with handler=3DNULL and !O=
NESHOT for %s (irq %d)\n",
|                        new->name, irq);
|                 ret =3D -EINVAL;

Sebastian