From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 486A22E54D1
	for <linux-kernel@vger.kernel.org>; Wed, 21 Jan 2026 13:18:15 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1769001496; cv=none; b=TXdoM7hnGwKGvfUFgvCrFj3NW1sz3eI+/0BcGDp0SecKgQFFPItFa08fzyMPmoCUmcUHnK4zuIpScGAaba4p+6MyyhmH2JZUQeKImrLsvIpPl2dCeRILLU3cRuhcQwbImd3UYIjf/+Z72L6LmiPwLfXQVB/ErFTuA6O9SQZG0TY=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1769001496; c=relaxed/simple;
	bh=ybxA754tCEbwpr9uYBBYODzYrK9RBtsa8Si5DuniXQ0=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=mjKWvXDAokZa0f5xEutyWKQeYFhsannfyCVdQYt51fLGWEaClMl3yYwZwzYu63zSpQSx4fCSXYUqnmZgzjbdTqO3Dy92JObOINJy8QAqTLJ/HSKgJbZJDOf7WTDthYf9kLrA88rXSBRkRk/8CO98lLYhOY3f8MbjJRPQMY8Ov+U=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=0bUBsBVi; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=2Hz8Tixu; arc=none smtp.client-ip=193.142.43.55
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="0bUBsBVi";
	dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="2Hz8Tixu"
Date: Wed, 21 Jan 2026 14:18:11 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1769001493;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=NHv8gu1wL59GfFLJBOeVPGBch5OZijFQqj4lUTLEtGw=;
	b=0bUBsBViogTS5AHZQpnKCoAV+WxGoJxPdgGHR8amiZjYFlMhzIVzIOIIdW1AfMu6SSedz+
	kxgxflUPK9JqqpZ8T+COH6HE5DK7Y7PInZuIV2R9jlp9aL092peKpXaQ1kFaf/Kfnj2AK+
	JkqVCNEvYOHMM1zqFYJnbZl3SMMF3xOa+R2kC7Aj81iw7GtDiwwLnSo8qy5Ogsrh73RbDq
	YYHJZdU283Qukq33XAhfl9G0nrcYzJ9I06NMWBkv7sUJMLfCpgPXSUdZpTK6yOtmS3w5fC
	60hbqMA9gAVMi9Lwqa9sM2U6LYHwB4PX4qUJcrhmfUnaDr15RtFK2otub0VWMw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1769001493;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=NHv8gu1wL59GfFLJBOeVPGBch5OZijFQqj4lUTLEtGw=;
	b=2Hz8TixuANx5TkBomNCl/geukQ1cBRLTqZsYaxGboJ+PIvu2pz+jBnq2nlXdPSKeaM/2YP
	ppH/oicQlsS49CAA==
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
	Lee Jones <lee@kernel.org>
Subject: Re: request_irq() usage in wm8350_register_irq().
Message-ID: <20260121131811.O5jxhLXH@linutronix.de>
References: <20260121111617.quQxFcZK@linutronix.de>
 <fbd0ffc0-d308-4064-893b-3c1b51a13a35@opensource.cirrus.com>
 <20260121113659.CCJtYuQS@linutronix.de>
 <90b80379-6799-4600-886d-08ef48d9a35f@opensource.cirrus.com>
 <20260121115723.oVTfTOS5@linutronix.de>
 <aXDJ_5iQFdvTqbkf@smile.fi.intel.com>
 <994ae390-f5c2-4b52-bd08-8826dbbde8e8@sirena.org.uk>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <994ae390-f5c2-4b52-bd08-8826dbbde8e8@sirena.org.uk>

On 2026-01-21 13:12:36 [+0000], Mark Brown wrote:
> What was the question?

to quote myself:

I've been staring wm8350_register_irq(). It does

| request_threaded_irq(irq + wm8350->irq_base, NULL,
| 		handler, flags, name, data);

and every single user passes 0 as flags. This means it asks for a
threaded IRQ and does not pass IRQF_ONESHOT.

So either this is not working because it triggers the warnings
	Threaded irq requested with handler=NULL and !ONESHOT

followed by -EINVAL _or_ every single user of this driver sits in
system where the irqchip is IRQCHIP_ONESHOT_SAFE marked.
Which is it?

Sebastian