From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16EA530FC1F for ; Wed, 21 Jan 2026 13:45:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769003115; cv=none; b=A8+T4ULwkUBzu5is9D5DTVY0vk2ufbW3eOcRRY6WmH5flhWbWLhCESh/wqQcPma6t86Xo6uPaZJ74KaqDtgzKV75iGiDhy9odjvc+IoQd462x8Mpz5FvfW8aqkVCPqOIMWHsXz5iUJpuVD34rLXAeh3Te42b0E6jChuiJ3ktBK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769003115; c=relaxed/simple; bh=A94X7+N5Fp9KaU9h6HBNesO/xv7uwQvK5L2eP3QNlrU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TfQi7U1DU+f5dzkmmXAocLZZeu+BhAsQtLWNwiMFbLd+dLzn8X1flOitzxKF/HH9inF/5ZZQzXIgcoe6khxkfNPG527hnW8hWckX5J0i3bt6NGkcZMowS1keUuhKEXZTra3d63xMf7UJkC6NFKgCvkejiDc/FAmrjTFaXvl2dR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=ZqO0wpKC; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=hJsIM41D; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ZqO0wpKC"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="hJsIM41D" Date: Wed, 21 Jan 2026 14:45:08 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1769003110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W9I75ZV96d5spC5BXCWdclikFkwJ90U+Tr3qgB5riA8=; b=ZqO0wpKCB2OeSMyIKuPe6pMeh1hBqOFhmAbFbkZnBfIVWbXaJQ4BeClh22w4DWsQEk0Bjm 7pdEeCtNcKBEeQ9f9y3o92hdCIqIuaMO7Lb8qgKuoSHdrYczFjHop7r78fIDAkzQYUhaal Gg5fmrytl0wI+gaqohRY3SKmW+QE1io+T72W3ENciz6arzGcreskbAEnT2F6OkipPZYohm q0IO24r6brKqJ3D8J4rCTOCqZn8cnqGG3SBLvcz1kCXHRo2WBo04wQjOa1SUIbiam1KmU8 8ODGCIEbrHXDt8BBloGiyMGgjpVPLt/3xMxGgtG6bBwVXXBYAV4h00t5FLTCeA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1769003110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W9I75ZV96d5spC5BXCWdclikFkwJ90U+Tr3qgB5riA8=; b=hJsIM41DXgWmJtm4Zy/YkZ5brxXvU/auzwrE8vD1jpOubo8ZCGU8TFdpwyQxS8EuwkBadf nsymqJFxGhYHwzBw== From: Sebastian Andrzej Siewior To: Mark Brown Cc: Andy Shevchenko , Richard Fitzgerald , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Lee Jones Subject: Re: request_irq() usage in wm8350_register_irq(). Message-ID: <20260121134508.aS-h9DpX@linutronix.de> References: <20260121111617.quQxFcZK@linutronix.de> <20260121113659.CCJtYuQS@linutronix.de> <90b80379-6799-4600-886d-08ef48d9a35f@opensource.cirrus.com> <20260121115723.oVTfTOS5@linutronix.de> <994ae390-f5c2-4b52-bd08-8826dbbde8e8@sirena.org.uk> <20260121131811.O5jxhLXH@linutronix.de> <2fcb799a-de89-47e0-a38a-a3a828d0b834@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <2fcb799a-de89-47e0-a38a-a3a828d0b834@sirena.org.uk> On 2026-01-21 13:37:09 [+0000], Mark Brown wrote: > On Wed, Jan 21, 2026 at 02:18:11PM +0100, Sebastian Andrzej Siewior wrote: >=20 > > I've been staring wm8350_register_irq(). It does >=20 > > | request_threaded_irq(irq + wm8350->irq_base, NULL, > > | handler, flags, name, data); >=20 > > and every single user passes 0 as flags. This means it asks for a > > threaded IRQ and does not pass IRQF_ONESHOT. >=20 > > So either this is not working because it triggers the warnings > > Threaded irq requested with handler=3DNULL and !ONESHOT >=20 > > followed by -EINVAL _or_ every single user of this driver sits in > > system where the irqchip is IRQCHIP_ONESHOT_SAFE marked. > > Which is it? >=20 > The chip is only accessable via I2C or SPI so the primary interrupt > handler is itself always running and reporting child interrupts in > threaded context. They can't really deliver a hardirq context > interrupt. In that case it lacks the needed IRQF_ONEHOST flag and nobody noticed that request_irq() fails for a few years now. I add a patch to my stack=E2=80=A6 Thanks Mark. Sebastian